Fix users list not showing on split confirm

[kowczarz]

Details

Fixed Issues

$ #19235
PROPOSAL: #19235 (comment)

Tests

1. Open any group chat on web app
2. Click + icon in composer > Split bill
3. Copy url from address bar (url should be like this format: http://localhost:8080/split/new/xxx)
4. Open desktop app (logout if already logged in)
5. Paste url in new tab and open desktop app from popup
6. Enter any amount and click Next

• Verify that no errors appear in the JS console

Offline tests

Same as above

QA Steps

Same as above

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android / native
  • Android / Chrome
  • iOS / native
  • iOS / Safari
  • MacOS / Chrome / Safari
  • MacOS / Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-06-07.at.14.54.27.mov

Mobile Web - Chrome

Screen.Recording.2023-06-07.at.15.22.48.mov

Mobile Web - Safari

Simulator.Screen.Recording.-.iPhone.14.Pro.-.2023-06-07.at.18.32.32.mp4

Desktop

Screen.Recording.2023-06-07.at.14.50.08.mov

iOS

Simulator.Screen.Recording.-.iPhone.14.Pro.-.2023-06-07.at.18.46.23.mp4

Android

Screen.Recording.2023-06-07.at.15.20.32.mov

[melvin-bot]

@amyevans @aimane-chnaif One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[amyevans]

@kowczarz can you take care of the linter errors first please?

[kowczarz]

@amyevans done ✅

[amyevans]

@aimane-chnaif can you review/complete the checklist please?

[kowczarz]

Hey, FYI I will be OOO on next days, so I will be able to respond earliest on Wednesday.

[aimane-chnaif]

personalDetails is replaced with allPersonalDetails in https://github.com/Expensify/App/pull/21113/files#diff-93b9622394e69d864cda6653a30240e791f97ce4cb4a1e0c2a0de679b2557fe9R111

This is what I suggest:
As withCurrentUserPersonalDetails HOC already includes personalDetails in props, allPersonalDetails is redundant in MoneyRequestModal component.

• So remove:

-       allPersonalDetails: {
-           key: ONYXKEYS.PERSONAL_DETAILS_LIST,
-       },

• replace all allPersonalDetails occurrences with personalDetails

• And update default state value: (this is redundant because it's set again on component mount)

-    const [selectedOptions, setSelectedOptions] = useState(
-        ReportUtils.isPolicyExpenseChat(props.report)
-            ? OptionsListUtils.getPolicyExpenseReportOptions(props.report)
-            : OptionsListUtils.getParticipantsOptions(props.report, props.allPersonalDetails),
-    );
+    const [selectedOptions, setSelectedOptions] = useState([]);

[aimane-chnaif]

Also, it doesn't make sense to pre-fill participants list from FAB. Only from report screen.

Suggested change

	useEffect(() => {
	setSelectedOptions(
	useEffect(() => {
	if (!props.report.reportID) return;
	setSelectedOptions(

[kowczarz]

I see that in PR #17964 whole file was refactored and it seems it might fix the issue, but currently I'm not able to test if it works because deeplinks fails with error:

[53075:0623/102551.645362:ERROR:CONSOLE(1)] "Request Network.loadNetworkResource failed. {"code":-32602,"message":"Unsupported URL scheme"}", source: devtools://devtools/bundled/core/protocol_client/protocol_client.js (1)

[aimane-chnaif]

Please test production web and desktop app. If it's not reproducible anymore, we can close this PR.

[amyevans]

Closing per #19235 (comment)