-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Setup deep links for iOS / Android #2052
Conversation
Hey, I noticed you changed some webpack configuration files. This can break production builds. Did you remember to run a production build locally to verify they still work? |
Hey, I noticed you changed some webpack configuration files. This can break production builds. Did you remember to run a production build locally to verify they still work? |
3 similar comments
Hey, I noticed you changed some webpack configuration files. This can break production builds. Did you remember to run a production build locally to verify they still work? |
Hey, I noticed you changed some webpack configuration files. This can break production builds. Did you remember to run a production build locally to verify they still work? |
Hey, I noticed you changed some webpack configuration files. This can break production builds. Did you remember to run a production build locally to verify they still work? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
iOS worked fine for me! On Android, however, I got no response on the emulator when running npx uri-scheme open expensify-cash://settings --android
I saw the following output in the terminal
npx: installed 1 in 1.055s
› Android: Attempting to open URI "expensify-cash://settings" in emulator
But no response in the Android app. I tried running the command while the app was backgrounded as well as open.
Thanks for catching that @Jag96/ Updated this with some more intent filter guys. Having one per combination of scheme + host seems to have fixed this issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That worked! LGTM
Whoops! This PR is causing iOS builds to fail https://github.com/Expensify/Expensify.cash/runs/2189376685?check_suite_focus=true |
@marcaaron Hello! This PR looks like internal QA. If so, can you let me know when it's QA'd in staging so I can check it off the deploy list? Thanks in advance! |
This PR can be tested actually!
I just tested this on Android. iOS may need to wait for changes here -> https://github.com/Expensify/Expensify/issues/154510#issuecomment-807705014 |
Alright so quick heads up here.. This did not pass on the latest iOS TestFlight build. I also can't think of any reason why it wouldn't be working. But it doesn't seem to be causing any issues for the TestFlight build so probably not a blocker. |
I got the same behaviour as you in the iOS app, a mWeb page was opened instead of the App. Android app was a pass tho 🎉 Let me know if I should open a separate issue about the iOS behaviour. |
FYI - I don't think iOS has been deployed yet |
Should we check this off the list if Android was a pass? We could check iOS once it's out. |
Yes, let's check it off ✅ |
cc @AndrewGable @Jag96
Not sure if we need to do anything else here I think the last step is to just add the capability here?✅ Thanks Andrew!Details
Sets up deep links / universal links for the iOS app. Will do Android next.
Fixed Issues
Fixes https://github.com/Expensify/Expensify/issues/146908
Tests
Local Test
iOS
xcrun simctl openurl booted expensify-cash://settings
Android
npx uri-scheme open expensify-cash://settings --android
Production Test
https://expensify.cash/apple-app-site-association
leads to a JSON filehttps://expensify.cash/settings
and verify it opens in the mobile appTested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android