Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 20200: Fails to Proceed with Similar Routing and Account Numbers Without Error Message #20560

Merged
merged 5 commits into from
Jun 20, 2023
Merged

Fix 20200: Fails to Proceed with Similar Routing and Account Numbers Without Error Message #20560

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
56e734f
add client check to display error when routing and account number are…
tienifr Jun 10, 2023
fb87967
change error message
tienifr Jun 10, 2023
f418490
change spanish message routingAndAccountNumberCannotBeSame according …
tienifr Jun 18, 2023
08d0866
Merge branch 'main' into fix/20200-no-error-message-with-similar-rout…
tienifr Jun 19, 2023
865dd65
fix prettier error
tienifr Jun 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/languages/en.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -835,6 +835,7 @@ export default {
restrictedBusiness: 'Please confirm company is not on the list of restricted businesses',
routingNumber: 'Please enter a valid routing number',
accountNumber: 'Please enter a valid account number',
routingAndAccountNumberCannotBeSame: 'The routing number and account number cannot be the same',
companyType: 'Please select a valid company type',
tooManyAttempts: 'Due to a high number of login attempts, this option has been temporarily disabled for 24 hours. Please try again later or manually enter details instead.',
address: 'Please enter a valid address',
Expand Down
1 change: 1 addition & 0 deletions src/languages/es.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -837,6 +837,7 @@ export default {
restrictedBusiness: 'Por favor, confirma que la empresa no está en la lista de negocios restringidos',
routingNumber: 'Por favor, introduce un número de ruta válido',
accountNumber: 'Por favor, introduce un número de cuenta válido',
routingAndAccountNumberCannotBeSame: 'El número de ruta y el número de cuenta no pueden ser iguales',
companyType: 'Por favor, selecciona un tipo de compañía válido',
tooManyAttempts:
'Debido a la gran cantidad de intentos de inicio de sesión, esta opción se ha desactivado temporalmente durante 24 horas. Vuelve a intentarlo más tarde o introduce los detalles manualmente.',
Expand Down
3 changes: 3 additions & 0 deletions src/pages/ReimbursementAccount/BankAccountManualStep.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,9 @@ class BankAccountManualStep extends React.Component {
if (!routingNumber || !CONST.BANK_ACCOUNT.REGEX.SWIFT_BIC.test(routingNumber) || !ValidationUtils.isValidRoutingNumber(routingNumber)) {
errorFields.routingNumber = 'bankAccount.error.routingNumber';
}
if (values.accountNumber === routingNumber) {
errorFields.accountNumber = this.props.translate('bankAccount.error.routingAndAccountNumberCannotBeSame');
}
if (!values.acceptTerms) {
errorFields.acceptTerms = 'common.error.acceptTerms';
}
Expand Down