fixed user's own message is unread on different plaforms
#2059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcaaron
requested changes
Mar 24, 2021
parasharrajat
force-pushed
the
parasharrajat/unread-fix
branch
from
668c574 to
85afd82
Compare
marcaaron
reviewed
Mar 24, 2021
parasharrajat
force-pushed
the
parasharrajat/unread-fix
branch
from
85afd82 to
406e5e5
Compare
timszot
approved these changes
Mar 26, 2021
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review @marcaaron
Details
we were using the stale reference to
lastReadSequenceNumberwhich caused the linked issue. I have refactored the code and fixed it.Fixed Issues
Fixes #1985Tests
Tried sending messages as explained in the issue.
Tested On
Screenshots
screen-.2.mp4
screen-.3.mp4