Fix 20152: In split bill upon selection of 8 participants first user gets highlighted. #20649

tienifr · 2023-06-13T03:21:48Z

Details

This PR adds a shouldTriggerArrowDownWhenMaxIndexExceeded prop into ArrowKeyFocusManager component with default value true. The prop is set to false in BaseOptionSelector, which prevents the highlighted options from resetting to 1 when the maximum number of selection is reached. This PR fix the issue in the MoneyRequestParticipantsSelector component (split bill page) and the NewChatPage (new group chat page).

Fixed Issues

$ #20152
PROPOSAL: #20152 (comment)

Tests

Click on the plus sign.
Go to "Split Bill."
Enter the amount
Click "Next."
Now select a maximum of 8 users.
When selecting the 8th participant, verify that the first user is not highlighted.

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Click on the plus sign.
Go to "Split Bill."
Enter the amount
Click "Next."
Now select a maximum of 8 users.
When selecting the 8th participant, verify that the first user is not highlighted.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

20152-web.mov

Mobile Web - Chrome

20152-mweb-chrome.mov

Mobile Web - Safari

20152-mweb-safari.mov

Desktop

20152-desktop.mov

iOS

20152-ios.mov

Android

https://drive.google.com/file/d/1_zitMb0UvCpXVZ5DSl4xQq47Elzxm9uQ/view?usp=sharing

…er to determine whenever arrow down action is triggered or not when the maximum participant number is exceeded

melvin-bot · 2023-06-13T05:43:50Z

@Julesssss @eVoloshchak One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Julesssss · 2023-06-13T08:11:58Z

src/components/ArrowKeyFocusManager.js

@@ -21,11 +21,15 @@ const propTypes = {

    /** If this value is true, then we exclude TextArea Node. */
    shouldExcludeTextAreaNodes: PropTypes.bool,
+
+    /** If this value is true, then the arrow down callback would be triggered when the max index is exceeded */
+    shouldTriggerArrowDownWhenMaxIndexExceeded: PropTypes.bool,


I'm trying to think of a simpler name for this.

Maybe something like isArrowDownAllowedBeyondMax or shouldArrowDownExtendBeyondComponent? They kinda suck though.

since the main purpose of the arrowDown operation in this case is to reset the index of the highlighted item to 0 (introduced in #18955), can we name it shouldResetFocusedIndexWhenMaxIndexExceeded?

Since the max index exceeded means we've reached the end of the list, we can call it shouldResetIndexOnEndReached
I'm also ok with shouldResetFocusedIndexWhenMaxIndexExceeded, it's long but self-explanatory

I like shouldResetIndexOnEndReached, can we use that please

eVoloshchak · 2023-06-14T13:34:50Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-06-14.at.16.44.22.mov

Mobile Web - Chrome

screen-20230614-164809.mp4

Mobile Web - Safari

Screen.Recording.2023-06-14.at.16.41.23.mov

Desktop

Screen.Recording.2023-06-14.at.16.43.36.mov

iOS

Screen.Recording.2023-06-14.at.16.42.11.mov

Android

screen-20230614-164736.mp4

Julesssss

Looking good, will approve once we have updated the var name

tienifr · 2023-06-15T08:21:51Z

@Julesssss @eVoloshchak I just updated the props name

OSBotify · 2023-06-15T09:54:14Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-06-16T18:51:34Z

🚀 Deployed to staging by https://github.com/Julesssss in version: 1.3.29-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-06-21T02:19:04Z

🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.29-11 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

add shouldTriggerArrowDownWhenMaxIndexExceeded inn ArrowKeyFocusManag…

25d9c34

…er to determine whenever arrow down action is triggered or not when the maximum participant number is exceeded

tienifr changed the title ~~add shouldTriggerArrowDownWhenMaxIndexExceeded inn ArrowKeyFocusManag…~~ Fix 20152: In split bill upon selection of 8 participants first user gets highlighted. Jun 13, 2023

tienifr marked this pull request as ready for review June 13, 2023 05:43

tienifr requested a review from a team as a code owner June 13, 2023 05:43

melvin-bot bot removed the request for review from a team June 13, 2023 05:43

melvin-bot bot requested review from eVoloshchak and Julesssss June 13, 2023 05:43

tienifr mentioned this pull request Jun 13, 2023

[HOLD for payment 2023-06-28] [$1000] In split bill upon selection of 8 participants first user gets highlighted. #20152

Closed

6 tasks

Julesssss reviewed Jun 13, 2023

View reviewed changes

dostongulmatov mentioned this pull request Jun 13, 2023

[HOLD for payment 2023-06-28] [$1000] Web - Web- Send money - Green payment button is partially visible #20262

Closed

6 tasks

Julesssss assigned tienifr Jun 15, 2023

Julesssss reviewed Jun 15, 2023

View reviewed changes

fix: rename props

0e427cf

Julesssss approved these changes Jun 15, 2023

View reviewed changes

eVoloshchak approved these changes Jun 15, 2023

View reviewed changes

Julesssss merged commit c22c5e1 into Expensify:main Jun 15, 2023

OSBotify mentioned this pull request Jun 16, 2023

Deploy Checklist: New Expensify 2023-06-16 #20928

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix 20152: In split bill upon selection of 8 participants first user gets highlighted. #20649

Fix 20152: In split bill upon selection of 8 participants first user gets highlighted. #20649

tienifr commented Jun 13, 2023 •

edited

Loading

melvin-bot bot commented Jun 13, 2023

Julesssss Jun 13, 2023 •

edited

Loading

tienifr Jun 13, 2023

eVoloshchak Jun 14, 2023

Julesssss Jun 15, 2023

eVoloshchak commented Jun 14, 2023 •

edited

Loading

Julesssss left a comment

tienifr commented Jun 15, 2023

OSBotify commented Jun 15, 2023

OSBotify commented Jun 16, 2023

OSBotify commented Jun 21, 2023

Fix 20152: In split bill upon selection of 8 participants first user gets highlighted. #20649

Fix 20152: In split bill upon selection of 8 participants first user gets highlighted. #20649

Conversation

tienifr commented Jun 13, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jun 13, 2023

Julesssss Jun 13, 2023 • edited Loading

Choose a reason for hiding this comment

tienifr Jun 13, 2023

Choose a reason for hiding this comment

eVoloshchak Jun 14, 2023

Choose a reason for hiding this comment

Julesssss Jun 15, 2023

Choose a reason for hiding this comment

eVoloshchak commented Jun 14, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

Julesssss left a comment

Choose a reason for hiding this comment

tienifr commented Jun 15, 2023

OSBotify commented Jun 15, 2023

OSBotify commented Jun 16, 2023

OSBotify commented Jun 21, 2023

tienifr commented Jun 13, 2023 •

edited

Loading

Julesssss Jun 13, 2023 •

edited

Loading

eVoloshchak commented Jun 14, 2023 •

edited

Loading