Fix: Remain focus when selecting option #20736

dukenv0307 · 2023-06-14T03:40:32Z

Details

Remain focus on search input when selecting an option

Fixed Issues

$ #19231
PROPOSAL: #19231 (comment)

Tests

Click on FAB
Click on "Split bill"
Type an email and select the contact that shows up in the below suggestion
Verify that the search input is highlighted/selected after user selects/deselects

Verify that no errors appear in the JS console

Offline tests

same above

QA Steps

Click on FAB
Click on "Split bill"
Type an email and select the contact that shows up in the below suggestion
Verify that the search input is highlighted/selected after user selects/deselects

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-07-04.at.16.25.48.mov

Mobile Web - Chrome

356781946_6203181973068095_6430592905541164488_n.mp4

Mobile Web - Safari

Screen.Recording.2023-07-04.at.17.24.44.mov

Desktop

Screen.Recording.2023-07-04.at.17.18.45.mov

iOS

Screen.Recording.2023-07-04.at.17.12.02.mov

Android

Screen.Recording.2023-07-04.at.19.56.51.mov

melvin-bot · 2023-06-28T00:45:04Z

@sobitneupane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

sobitneupane

@dukenv0307 Looks like you have missed the following point from the comment.

Similar to Create Group, both on selecting or deselecting a row, value input in the search field should be selected.

Screen.Recording.2023-06-28.at.14.44.38.mov

dukenv0307 · 2023-06-28T10:30:34Z

@sobitneupane Thanks for your reminder. I just checked again. This issue doesn't happen on the Split Bill page. It is so weird and seems that it is another bug. I will investigate more if we decide to fix this PR

sobitneupane · 2023-06-28T10:34:25Z

@dukenv0307 We want it to be fixed in this PR. And we want the text input to be selected in SplitBill page as well.

dukenv0307 · 2023-06-28T10:38:38Z

And we want the text input to be selected in SplitBill page as well.

@sobitneupane Do you mean that the behavior on the New Group Page is correct (the text should be selected)?

sobitneupane · 2023-06-28T10:39:23Z

Yes

dukenv0307 · 2023-06-28T10:41:21Z

For more information, #20948 (comment)
In all mutil-selection pages, we are planing to clear text input when the user selects a new option

dukenv0307 · 2023-06-28T10:48:22Z

@sobitneupane I just updated the input text that should be selected when the user unselects an option

This is result

Screen.Recording.2023-06-28.at.17.47.18.mov

sobitneupane · 2023-06-29T08:13:24Z

Added my comments on https://expensify.slack.com/archives/C01GTK53T8Q/p1687282549853709. Let's HOLD the PR for now.

dukenv0307 · 2023-07-03T16:53:19Z

@sobitneupane Do you agree to extend the scope of this PR and also fix this issue #20948

sobitneupane · 2023-07-04T09:04:05Z

@dukenv0307 We decided to highlight/select the text input after user selects/deselects any row. So, I don't think any change will be required in New Group Page.

You can go forward with the change.

dukenv0307 · 2023-07-04T09:07:51Z

@sobitneupane Sorry about the confusion, I mean that we Fix the 'Split Bill' page to align with other pages in this PR, right?

sobitneupane · 2023-07-04T09:08:39Z

Yes @dukenv0307.

dukenv0307 · 2023-07-04T09:08:45Z

Currently, when selecting a new member in the split bill, the search value will be cleared

dukenv0307 · 2023-07-04T09:09:11Z

Oke make sense, I will fix immediately

sobitneupane · 2023-07-04T12:24:09Z

@dukenv0307 Is it ready for review? Please let me know when it's ready for review.

dukenv0307 · 2023-07-04T12:59:07Z

@sobitneupane The PR is ready for review. Sorry for my delay, I need to update all screenshot to match the expected

sobitneupane

@dukenv0307 New group page in mWeb has quite different behavior. Can you please check it out. Let's try to keep our change consistent with New Group Page.

Also please do merge main. Only few rows are being displayed in the Optionslist.

src/pages/iou/steps/MoneyRequstParticipantsPage/MoneyRequestParticipantsSplitSelector.js

…rticipantsSplitSelector.js Co-authored-by: Sobit Neupane <073bct543.sobit@pcampus.edu.np>

dukenv0307 · 2023-07-04T17:23:51Z

@sobitneupane

New group page in mWeb has quite different behavior. Can you please check it out. Let's try to keep our change consistent with New Group Page.

What is the difference?

This is the expected as @fedirjh commented on the Slack, right?

When selecting a new user , the search term is highlighted and input is still focused
When deselecting a user , the search term is highlighted and input is still focused

sobitneupane · 2023-07-05T06:22:04Z

What is the difference?

For mWeb, we don't select the text input.

App/src/pages/NewChatPage.js

Line 200 in 11b8908

shouldFocusOnSelectRow={props.isGroupChat && !Browser.isMobile()}

sobitneupane

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-07-05.at.11.51.15.mov

Mobile Web - Chrome

vidma_recorder_edited_05072023_121012.mp4

Mobile Web - Safari

Screen.Recording.2023-07-05.at.11.52.19.mov

Desktop

Screen.Recording.2023-07-05.at.11.57.17.mov

iOS

Screen.Recording.2023-07-05.at.11.55.33.mov

Android

Screen.Recording.2023-07-05.at.12.02.29.mov

arosiclair

👍

OSBotify · 2023-07-05T14:35:54Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-07-05T17:30:56Z

🚀 Deployed to staging by https://github.com/arosiclair in version: 1.3.37-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-07-07T10:36:22Z

🚀 Deployed to production by https://github.com/Julesssss in version: 1.3.37-7 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

dukenv0307 added 5 commits June 14, 2023 10:29

fix: remain focus when selecting option

ee20216

fix: lint

ab6dd45

fix: lint

0debd1c

fix: lint

59a6ffc

merge main

c66b061

dukenv0307 marked this pull request as ready for review June 28, 2023 00:44

dukenv0307 requested a review from a team as a code owner June 28, 2023 00:44

melvin-bot bot requested review from sobitneupane and removed request for a team June 28, 2023 00:45

dukenv0307 mentioned this pull request Jun 28, 2023

[HOLD for payment 2023-07-14] [$1000] Placeholder not moving back to it's place after selecting a contact #19231

Closed

6 tasks

sobitneupane reviewed Jun 28, 2023

View reviewed changes

select text when user unselect member

77930ee

fedirjh mentioned this pull request Jul 2, 2023

[Hold for #20736] [$1000] Search in new group does not delete current search after result selection like it does in split bill search #20948

Closed

6 tasks

merge main

13b1ce8

dukenv0307 added 2 commits July 4, 2023 16:15

merrge main

50eae34

retain search input in split bill

f825d17

remove redandunt

9c3f92c

arosiclair assigned dukenv0307 Jul 4, 2023

arosiclair self-requested a review July 4, 2023 15:23

sobitneupane reviewed Jul 4, 2023

View reviewed changes

src/pages/iou/steps/MoneyRequstParticipantsPage/MoneyRequestParticipantsSplitSelector.js Outdated Show resolved Hide resolved

dukenv0307 and others added 4 commits July 5, 2023 00:03

Update src/pages/iou/steps/MoneyRequstParticipantsPage/MoneyRequestPa…

f4776fe

…rticipantsSplitSelector.js Co-authored-by: Sobit Neupane <073bct543.sobit@pcampus.edu.np>

add import

a93b78a

merge main

22c44e6

remove empty line

fdb9f85

sobitneupane approved these changes Jul 5, 2023

View reviewed changes

arosiclair approved these changes Jul 5, 2023

View reviewed changes

arosiclair merged commit 0faef9d into Expensify:main Jul 5, 2023

OSBotify mentioned this pull request Jul 5, 2023

Deploy Checklist: New Expensify 2023-07-05 #22282

Closed

58 tasks

allroundexperts mentioned this pull request Jul 5, 2023

Selecting user doesn't clear input text from search field on Split Bill page #22298

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix: Remain focus when selecting option #20736

Fix: Remain focus when selecting option #20736

dukenv0307 commented Jun 14, 2023 •

edited

Loading

melvin-bot bot commented Jun 28, 2023

sobitneupane left a comment

dukenv0307 commented Jun 28, 2023

sobitneupane commented Jun 28, 2023 •

edited

Loading

dukenv0307 commented Jun 28, 2023 •

edited

Loading

sobitneupane commented Jun 28, 2023

dukenv0307 commented Jun 28, 2023 •

edited

Loading

dukenv0307 commented Jun 28, 2023 •

edited

Loading

sobitneupane commented Jun 29, 2023

dukenv0307 commented Jul 3, 2023

sobitneupane commented Jul 4, 2023

dukenv0307 commented Jul 4, 2023 •

edited

Loading

sobitneupane commented Jul 4, 2023

dukenv0307 commented Jul 4, 2023 •

edited

Loading

dukenv0307 commented Jul 4, 2023

sobitneupane commented Jul 4, 2023

dukenv0307 commented Jul 4, 2023

sobitneupane left a comment •

edited

Loading

dukenv0307 commented Jul 4, 2023 •

edited

Loading

sobitneupane commented Jul 5, 2023

sobitneupane left a comment •

edited

Loading

arosiclair left a comment

OSBotify commented Jul 5, 2023

OSBotify commented Jul 5, 2023

OSBotify commented Jul 7, 2023

Fix: Remain focus when selecting option #20736

Fix: Remain focus when selecting option #20736

Conversation

dukenv0307 commented Jun 14, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jun 28, 2023

sobitneupane left a comment

Choose a reason for hiding this comment

dukenv0307 commented Jun 28, 2023

sobitneupane commented Jun 28, 2023 • edited Loading

dukenv0307 commented Jun 28, 2023 • edited Loading

sobitneupane commented Jun 28, 2023

dukenv0307 commented Jun 28, 2023 • edited Loading

dukenv0307 commented Jun 28, 2023 • edited Loading

sobitneupane commented Jun 29, 2023

dukenv0307 commented Jul 3, 2023

sobitneupane commented Jul 4, 2023

dukenv0307 commented Jul 4, 2023 • edited Loading

sobitneupane commented Jul 4, 2023

dukenv0307 commented Jul 4, 2023 • edited Loading

dukenv0307 commented Jul 4, 2023

sobitneupane commented Jul 4, 2023

dukenv0307 commented Jul 4, 2023

sobitneupane left a comment • edited Loading

Choose a reason for hiding this comment

dukenv0307 commented Jul 4, 2023 • edited Loading

sobitneupane commented Jul 5, 2023

sobitneupane left a comment • edited Loading

Choose a reason for hiding this comment

Reviewer Checklist

Screenshots/Videos

arosiclair left a comment

Choose a reason for hiding this comment

OSBotify commented Jul 5, 2023

OSBotify commented Jul 5, 2023

OSBotify commented Jul 7, 2023

dukenv0307 commented Jun 14, 2023 •

edited

Loading

sobitneupane commented Jun 28, 2023 •

edited

Loading

dukenv0307 commented Jun 28, 2023 •

edited

Loading

dukenv0307 commented Jun 28, 2023 •

edited

Loading

dukenv0307 commented Jun 28, 2023 •

edited

Loading

dukenv0307 commented Jul 4, 2023 •

edited

Loading

dukenv0307 commented Jul 4, 2023 •

edited

Loading

sobitneupane left a comment •

edited

Loading

dukenv0307 commented Jul 4, 2023 •

edited

Loading

sobitneupane left a comment •

edited

Loading