Close Keyboard on iOS/Android using Swipeable View

[barun1997]

<If necessary, assign reviewers that know the area or changes well. Feel free to tag any additional reviewers you see fit.>

Details

I created SwipeableView to wrap ReportActionCompose Component.

Not sure if I should make SwipeableView cross-platform and separate ReportView to have SwipeableView wrap ReportActionCompose in iOS instead. Please let me know what you suggest!

Fixed Issues

Fixes GH_LINK #1870

Tests

1. Click on a chat with someone
2. Type something (toggle software keyboard on if you're on iOS Simulator)
3. Swipe down on the message window
4. Verify swiping down closes the keyboard

Tested On

• iOS

Screenshots

IOS

Screen.Recording.2021-03-25.at.09.46.31.mov

[barun1997]

@marcaaron -- My initial proposal was to use onPanResponderMove and close the keyboard using it. But it led to too many callbacks, and on second thought, I thought calling the onSwipeDown callback on onPanResponderRelease -- when the gesture has completed, was a better solution. Please let me know what you think!

[barun1997]

@marcaaron I have made SwipeableView available in Android as well and addressed other issues. Please let me know if you have any suggestions!

[marcaaron]

Code looks nice and simple, but noticing that swipes are not registered on the text input field itself. I think makes this less useful than we were hoping since it's kind of hard to swipe on the smaller areas around the text input to get the keyboard to dismiss?

Example:

2021-03-26_10-45-00.mp4

[barun1997]

@marcaaron This should fix it! The text input field seems to be receiving touch gestures now.
https://user-images.githubusercontent.com/19339044/112693537-e6a2a200-8ea8-11eb-8aea-0923d373e4fd.mov

[marcaaron]

Tests great and working well. Once the Podfile.lock is resolved I will merge.

[barun1997]

Hi @marcaaron, I reverted the changes in Podfile.lock with a new commit.

[marcaaron]

Hi @marcaaron, I reverted the changes in Podfile.lock with a new commit.

Sorry, it's still there. Maybe you did not push the change?

[barun1997]

Hi @marcaaron, I reverted the changes in Podfile.lock with a new commit.

Sorry, it's still there. Maybe you did not push the change?

Does 49f729c not resolve it?

[marcaaron]

Sorry, no, I think because you removed a new line from this file. It should not show as one of the changes files.

[barun1997]

@marcaaron Ah you're right :) I've updated it. Thank you for your patience! 💯

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.