Fix: Find solution to low resolution large images on Android, and the Canvas crash#20798

Merged

Julesssss merged 161 commits intoExpensify:mainfrom margelo:@terrysahaidak/attachment-gallery

Aug 7, 2023

+1,917-580

Commits on May 15, 2023

wip new pager
terrysahaidak
committed

Commits on May 16, 2023

use Image component
terrysahaidak
committed

Commits on May 17, 2023

Commits on May 18, 2023

Merge remote-tracking branch 'upstream/main' into @terrysahaidak/attachment-gallery
terrysahaidak
committed

Commits on May 25, 2023

Merge remote-tracking branch 'upstream/main' into @terrysahaidak/attachment-gallery
terrysahaidak
committed

Commits on Jun 15, 2023

Merge branch 'main' into @terrysahaidak/attachment-gallery
Christoph Pader
committed
fix: prettier
Christoph Pader
committed
use correct import
Christoph Pader
committed
add dimensions with scale
Christoph Pader
committed

Commits on Jun 16, 2023

Merge branch 'main' into @terrysahaidak/attachment-gallery
Christoph Pader
committed
prefer early return
Christoph Pader
committed
simplify AttachmentCarousel structure
Christoph Pader
committed
fix: wrong bindings
Christoph Pader
committed
fix: eslint warning
Christoph Pader
committed
fix: paging
Christoph Pader
committed
forward PagerRef
Christoph Pader
committed

Commits on Jun 19, 2023

Merge branch 'main' into @terrysahaidak/attachment-gallery
Christoph Pader
committed
fix: merge changes
Christoph Pader
committed
stop reversing the attachments on native in "AttachmentCarousel"
Christoph Pader
committed
only show pager if container is big enough
Christoph Pader
committed
hide buttons on gesture
Christoph Pader
committed
fix: minor issues
Christoph Pader
committed
update comment
Christoph Pader
committed

Commits on Jun 21, 2023

Merge branch 'main' into @terrysahaidak/attachment-gallery
Christoph Pader
committed

Commits on Jun 23, 2023

Merge branch 'main' into @terrysahaidak/attachment-gallery
Christoph Pader
committed
fix: nothing shown
Christoph Pader
committed

Commits on Jun 27, 2023

Merge branch 'main' into @terrysahaidak/attachment-gallery
Christoph Pader
committed
add "activeSource" logic
Christoph Pader
committed
fix: reversing attachments
Christoph Pader
committed
use container size measurements in carousel implementations
Christoph Pader
committed
fix: panning for very tall images
Christoph Pader
committed
refine swipe down gesture (currently not in use)
Christoph Pader
committed
add propTypes
Christoph Pader
committed
add onClose callback to <AttachmentCarousel />
Christoph Pader
committed
fix: null checking
Christoph Pader
committed
Merge branch 'main' into @terrysahaidak/attachment-gallery
Christoph Pader
committed
wrap Pager in GestureHandlerRootView for android
Christoph Pader
committed

Commits on Jun 28, 2023

Merge branch 'main' into @terrysahaidak/attachment-gallery
Christoph Pader
committed
fix: prop types
Christoph Pader
committed
use styles from global stylesheet
Christoph Pader
committed
move constants to top
Christoph Pader
committed
update page scrolling
Christoph Pader
committed
fix paging
Christoph Pader
committed
fix: attachment carousel on web
Christoph Pader
committed
extract propTypes
Christoph Pader
committed

Commits on Jul 10, 2023

Merge branch 'main' into @terrysahaidak/attachment-gallery
Christoph Pader
committed

Commits on Jul 11, 2023

Merge branch 'main' into @terrysahaidak/attachment-gallery
Christoph Pader
committed

Commits on Jul 12, 2023

Merge branch 'main' into @terrysahaidak/attachment-gallery
Christoph Pader
committed

Commits on Jul 13, 2023

Merge branch 'main' into @terrysahaidak/attachment-gallery
Christoph Pader
committed

Commits on Jul 14, 2023

Merge branch 'main' into @terrysahaidak/attachment-gallery
Christoph Pader
committed
fix: lint error
Christoph Pader
committed

Commits on Jul 16, 2023

Merge branch 'main' into @terrysahaidak/attachment-gallery
Christoph Pader
committed

Commits on Jul 17, 2023

feat: implement real size image rendering
Christoph Pader
committed
fix: resizing
Christoph Pader
committed

Commits on Jul 18, 2023

fix: typo
Christoph Pader
committed
Fix: implement scaling of non active images and improve loading state
Christoph Pader
committed
simplify ImageTransformer
Christoph Pader
committed
fix: propTypes and extract itemExtractor from lightbox
Christoph Pader
committed
simplify
Christoph Pader
committed
move autoHideArrow logic to native
Christoph Pader
committed
move initial arrow showing logic to native implementation
Christoph Pader
committed
simplify Lightbox and add propTypes to ImageTransformer
Christoph Pader
committed
extract more logic from AttachmentCarousel and improve propTypes and memoizing
Christoph Pader
committed
add more propTypes
Christoph Pader
committed
Merge branch 'main' into @terrysahaidak/attachment-gallery
Christoph Pader
committed
further simplify Lightbox
Christoph Pader
committed
omit updating the image dimensions if already set
Christoph Pader
committed
fix: further simplify Lightbox
Christoph Pader
committed
fix: loading state never ending
Christoph Pader
committed
improve state in AttachmentCarousel
Christoph Pader
committed
fix: state
Christoph Pader
committed
fix: image should not be "flippable"
Christoph Pader
committed
remove log
Christoph Pader
committed
fix: on tap not working
Christoph Pader
committed
fix: arrows
Christoph Pader
committed
fix: flashing
Christoph Pader
committed

Commits on Jul 19, 2023

Merge branch 'main' into @terrysahaidak/attachment-gallery
Christoph Pader
committed
rename component
Christoph Pader
committed
major re-structure
Christoph Pader
committed
fix: imports
Christoph Pader
committed
extract more propTypes
Christoph Pader
committed
add "isUsedInCarousel" prop
Christoph Pader
committed
split up AttachmentCarouselPage logic
Christoph Pader
committed
add isAuthTokenRequired prop to carousel page
Christoph Pader
committed
fix: imports
Christoph Pader
committed
fix: imports
Christoph Pader
committed
fix: invalid import
Christoph Pader
committed
simplify propTypes and fix pdfs
Christoph Pader
committed
extract pdf logic
Christoph Pader
committed
simplify attachment initialization
Christoph Pader
committed
improve web AttachmentCarouselView
Christoph Pader
committed
simplify AttachmentCarousel logic
Christoph Pader
committed
fix: jsdoc and params
Christoph Pader
committed
remove log
Christoph Pader
committed
extract arrow showing logic
Christoph Pader
committed
simplify
Christoph Pader
committed
Merge branch 'main' into @terrysahaidak/attachment-gallery
Christoph Pader
committed
last fixes
Christoph Pader
committed
only disable arrows on tap on touchscreen devices
Christoph Pader
committed
fix: remaining issues
Christoph Pader
committed

Commits on Jul 20, 2023

Merge branch 'main' into @terrysahaidak/attachment-gallery
Christoph Pader
committed
fix: AttachmentView issues propTypes
Christoph Pader
committed
remove null check
Christoph Pader
committed
fix: wrong import
Christoph Pader
committed
fix types and restructure
Christoph Pader
committed
remove unused prop for now
Christoph Pader
committed

Commits on Jul 22, 2023

Merge branch 'main' into @terrysahaidak/attachment-gallery
Christoph Pader
committed
adapt min/max scales by initial image scale
Christoph Pader
committed
adjust double tap scale too
Christoph Pader
committed
fix: wrong import
Christoph Pader
committed
fix: use doubleTapScale
Christoph Pader
committed
simplify scaling logic
Christoph Pader
committed

Commits on Jul 23, 2023

remove file from propTypes
Christoph Pader
committed

Commits on Jul 27, 2023

Merge branch 'main' into @terrysahaidak/attachment-gallery
Christoph Pader
committed
fix: maxScale based on max imageScale
Christoph Pader
committed
rename and simplify pinch gesture variables
Christoph Pader
committed
simplify zoomToCoordinates
Christoph Pader
committed
pass both horizontal and vertical iamge scale to ImageTransformer
Christoph Pader
committed
simplify variables
Christoph Pader
committed

Commits on Aug 1, 2023

Merge branch 'main' into @terrysahaidak/attachment-gallery
Christoph Pader
committed
disallow panning, when image has smaller width than canvas
Christoph Pader
committed
simplify zoomToCoordinates variables
Christoph Pader
committed
remove old variable
Christoph Pader
committed
add comment about totalScale calculation
Christoph Pader
committed
simplify ImageTransformer render structure
Christoph Pader
committed
remove unused import
Christoph Pader
committed
improve doubleTap zoom to fill
Christoph Pader
committed
improve max/min scales
Christoph Pader
committed
fix: focal point on double tap to zoom
Christoph Pader
committed
gray out date in MoneyRequestView

c3024
authored and
Christoph Pader
committed
converted emojipickermenu native to functional component

shubham1206agra
authored and
Christoph Pader
committed
small bug fix

shubham1206agra
authored and
Christoph Pader
committed
removed unecessary comment

shubham1206agra
authored and
Christoph Pader
committed
prettier lint

shubham1206agra
authored and
Christoph Pader
committed
ReBump Reanimated to 3.4.0

shubham1206agra
authored and
Christoph Pader
committed
updated for newer definition

shubham1206agra
authored and
Christoph Pader
committed
append current time to the downloaded file name

bernhardoj
authored and
Christoph Pader
committed
create unit test

bernhardoj
authored and
Christoph Pader
committed
update wording

bernhardoj
authored and
Christoph Pader
committed
prettier

bernhardoj
authored and
Christoph Pader
committed
add jsdoc

bernhardoj
authored and
Christoph Pader
committed
rename function

bernhardoj
authored and
Christoph Pader
committed
make the date format consistent

bernhardoj
authored and
Christoph Pader
committed
remove spaces between hyphen

bernhardoj
authored and
Christoph Pader
committed
increase animation speed
Christoph Pader
committed
Merge branch 'main' into @terrysahaidak/attachment-gallery
Christoph Pader
committed
fix: arrows not showing on web
Christoph Pader
committed
add bounce effect
Christoph Pader
committed
simplify code
Christoph Pader
committed
Merge branch 'main' into @terrysahaidak/attachment-gallery
Christoph Pader
committed

Commits on Aug 2, 2023

Merge branch 'main' into @terrysahaidak/attachment-gallery
Christoph Pader
committed
fix: focal point not correct in image double tap
Christoph Pader
committed
remove log and fix doubleTapScale
Christoph Pader
committed
only show image after onLoadEnd is triggered
Christoph Pader
committed
return undefined style instead of empty object
Christoph Pader
committed
fix: initial page not stopping to load
Christoph Pader
committed
fix: initial load of first active page
Christoph Pader
committed
fix: don't unmount next inactive pages
Christoph Pader
committed
increase max zoom scale
Christoph Pader
committed

Commits on Aug 6, 2023

Merge branch 'main' into @terrysahaidak/attachment-gallery
Christoph Pader
committed