Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update appstore profile #2081

Merged
merged 1 commit into from
Mar 25, 2021
Merged

Update appstore profile #2081

merged 1 commit into from
Mar 25, 2021

Conversation

Jag96
Copy link
Contributor

@Jag96 Jag96 commented Mar 25, 2021 •
edited
Loading

@marcaaron will you please review this? cc @AndrewGable @roryabraham

Details

This PR updates the appstore provisioning profile using the directions listed here.

Fixed Issues

Fixes broken iOS deploy coming from slack

Tests

  1. I downloaded the appstore profile from developer.apple.com and double-clicked it
  2. Opened Xcode and confirmed that under Signing, there were no warnings about the profile such as
error: Provisioning profile "chat_expensify_appstore" doesn't support the Associated Domains capability

@Jag96 Jag96 requested a review from marcaaron March 25, 2021 17:14
@Jag96 Jag96 self-assigned this Mar 25, 2021
@Jag96 Jag96 requested a review from a team as a code owner March 25, 2021 17:14
@botify botify requested review from Gonals and removed request for a team March 25, 2021 17:14
marcaaron
marcaaron approved these changes Mar 25, 2021
View reviewed changes
Copy link
Contributor

@marcaaron marcaaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for helping with this !

@marcaaron
Copy link
Contributor

Not sure if there is anything to test here, but LGTM.

@marcaaron marcaaron merged commit 6059b63 into master Mar 25, 2021
@marcaaron marcaaron deleted the joe-update-mobileprovision branch March 25, 2021 17:54
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Mar 25, 2021
Closed
85 tasks
sketchydroide
sketchydroide reviewed Mar 25, 2021
View reviewed changes
Copy link
Contributor

@sketchydroide sketchydroide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM to

@isagoico
Copy link

@Jag96 Hello! This PR looks like internal QA. If so, can you let me know when it's QA'd in staging so I can check it off the deploy list? Thanks in advance!

@Jag96
Copy link
Contributor Author

Jag96 commented Mar 25, 2021

This is good to check off!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sketchydroide sketchydroide sketchydroide left review comments

@marcaaron marcaaron marcaaron approved these changes

@AndrewGable AndrewGable AndrewGable approved these changes

@Gonals Gonals Awaiting requested review from Gonals

Assignees

@Jag96 Jag96

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Jag96 @marcaaron @OSBotify @isagoico @sketchydroide @AndrewGable