Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[No QA]Update readme to include link for updating encrypted secrets #2083

Merged
merged 2 commits into from
Mar 27, 2021

Conversation

Jag96
Copy link
Contributor

@Jag96 Jag96 commented Mar 25, 2021

@AndrewGable will you please review this? Lmk if there's any other info we want to add here

Details

This PR updates the workflow.md to include the help link for updating encrypted secrets used in the repo.

Tests

See the changes in https://github.com/Expensify/Expensify.cash/blob/joe-encrypted-secrets-readme/.github/workflows/README.md#secrets

@Jag96 Jag96 requested a review from AndrewGable March 25, 2021 17:44
@Jag96 Jag96 self-assigned this Mar 25, 2021
@Jag96 Jag96 requested a review from a team as a code owner March 25, 2021 17:44
@botify botify requested review from Beamanator and removed request for a team March 25, 2021 17:44
Copy link
Contributor

@Beamanator Beamanator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and helpful! 👍🏽

@AndrewGable AndrewGable changed the title Update readme to include link for updating encrypted secrets [No QA]Update readme to include link for updating encrypted secrets Mar 27, 2021
@AndrewGable AndrewGable merged commit 5653942 into master Mar 27, 2021
@AndrewGable AndrewGable deleted the joe-encrypted-secrets-readme branch March 27, 2021 00:50
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants