-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix "user is typing..." indicator - key by accountID #21029
Conversation
@allroundexperts Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
@s77rt i'm testing on all platforms then will fill out the checklist, please test if you get the chance |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had a couple of questions. Will test.
Co-authored-by: Marc Glasser <marc.aaron.glasser@gmail.com>
Also to clarify the test steps... There is a comment on the report that says:
So the expected behavior is to see "Someone is typing" until they "post" If so, this is what I see: |
✅ Make sure display name shows in "is typing" indicator |
@marcaaron that's strange you don't see "Concierge is typing..." 😅 I see that all the time in my branch 🍕 |
Gonna try to update all the repos maybe something is badly out of date for me locally. |
@Beamanator How are we supposed to get the "Someone" is typing? we always fallback to the login first (email) |
@s77rt - true we always fall back to the login IF it exists, but it doesn't always exist in Onyx. For example, right when you join a public room, before you type anything nobody should have your personal details
|
Ok "Concierge is typing" issue looks fixed now so we are ✅ there. The "Someone is typing" step is still failing. It seems like User A will always see the display names (I am guessing they get updated with the personal details whenever someone joins the public room, but I haven't confirmed this yet). Is that a blocker for this? Or are we good to merge? @puneetlath maybe you have the answer to that question as it's getting quite late for @Beamanator. |
@marcaaron updated the step
to be between user B & C It looks like the room admin always is sent the personal details of users as they join the room 👍 |
Works well, but I removed the onyx data manually (does not look critical to relay on the backend not to send the personaldetails) Kooha-2023-06-19-21-07-50.mp4 |
@s77rt would you mind testing android and posting screens? That's the last one I haven't tested and if you are reviewing I can check out some other things. |
Works well Kooha-2023-06-19-21-30-38.mp4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🚀
(checklist filled by @marcaaron)
We did not find an internal engineer to review this PR, trying to assign a random engineer to #20956... Please reach out for help on Slack if no one gets assigned! |
Fix "user is typing..." indicator - key by accountID (cherry picked from commit b25a014)
…-21029 🍒 Cherry pick PR #21029 to staging 🍒
🚀 Cherry-picked to staging by https://github.com/luacmartins in version: 1.3.29-4 🚀
@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes. |
QA'd on staging, everything looks good - except I wasn't able to test NOT having a |
🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.29-11 🚀
|
🚀 Deployed to staging by https://github.com/luacmartins in version: 1.3.32-1 🚀
|
🚀 Deployed to production by https://github.com/thienlnam in version: 1.3.32-5 🚀
|
Details
Fixed Issues
$ #20956
Tests
*@expensify.com
account and can log in to ConciergeMake sure display name shows in "is typing" indicator
Screen.Recording.2023-06-19.at.4.27.17.PM.mov
Make sure
"Someone"
shows in "is typing" indicatorMake sure login shows in "is typing" indicator
Make sure "Multiple users are typing" indicator still works
Screen.Recording.2023-06-19.at.4.47.39.PM.mov
Make sure Concierge live-chatting isn't broken
Offline tests
"User is typing" indicator does not show offline, so no tests needed here
QA Steps
Same as above - Concierge part has to be internal QA'd
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Desktop, Android, Web Chrome
Display name:
Login:
Someone:
Concierge:
Mobile Web - Chrome
Mobile Web - Safari
iOS