cleanup for GSD layout

[parasharrajat]

@marcaaron Please review.

Fixes

fixes #2123

Details

Following up on the changes mentioned #2015 (review)

Tested On

• Web
• Mobile Web
• Desktop
• iOS
• Android

Internal Code changes thus no screenshots.

[parasharrajat]

Updated. Thanks.

[marcaaron]

Thanks for the changes looks much better. Have one more thought and then I'll stop bugging you 😅

[shawnborton]

@parasharrajat see my comment over here: #2123 (comment)

In case we want to fix that while you are addressing clean up items here.

[parasharrajat]

@shawnborton Thanks for mapping that issue to the PR. It's been taken care of.

[parasharrajat]

These variables were removed recently so I have to migrate.

[marcaaron]

@parasharrajat you've got some conflicts here now and please try to remove all inline styles. We should not be passing any objects directly to a style prop. If you need to return a style object based on some props create a helper method and add it to styles.js like we have done here.

https://github.com/Expensify/Expensify.cash/blob/0867cbf5882e416766e120144a9fcee20b219682/src/styles/styles.js#L1370-L1405

[parasharrajat]

@marcaaron Updated. Thanks.

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[roryabraham]

I believe this PR may have caused a regression where the background between the avatars becomes black when the option is selected:

Not Selected	Selected

Note: reproducible on staging but not production so this should be a deploy blocker.

[parasharrajat]

Oh. I think this PR should fix this. Let me check.

[roryabraham]

Oops, ignore me, I was not on the latest staging version.