Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Pressing Enter immediately after pasting a image in the Compose Box closes the modal. #2113

Merged
merged 1 commit into from
Mar 27, 2021

Conversation

parasharrajat
Copy link
Member

@parasharrajat parasharrajat commented Mar 26, 2021

Please review.

Details

A detailed explanation of issue #2063 is here #2063 (comment)

Fixed Issues

Fixes #2063

Tests

  1. Copy an image to the clipboard
  2. Click on compose box in a chat with a user or test account
  3. Paste the image into composing by typing command+v
  4. Immediately tap enter twice or more.
  5. Modal should not close.
  6. After the modal is visible, pressing enter submits the image. (Image will not be submitted until the modal is fully visible we can do this but we come to consent Images not uploading when you hit return immediately after pasting #2063 (comment)).

QA Steps

  1. Perform the above steps to test it.

Tested On

  • Web
  • Mobile Web (Not affected by issue)
  • Desktop
  • iOS (Not affected by issue)
  • Android (Not affected by issue)

Screenshots

Web

video2.mp4

Desktop

screen.mp4

Pressing enter after pasting the image in the compose box does not work and closes the modal
@parasharrajat parasharrajat requested a review from a team as a code owner March 26, 2021 19:12
@botify botify requested review from NikkiWines and removed request for a team March 26, 2021 19:13
Copy link
Contributor

@NikkiWines NikkiWines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works well ✅

@NikkiWines NikkiWines merged commit b5cee79 into Expensify:master Mar 27, 2021
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@parasharrajat parasharrajat deleted the parasharrajat/fix-modal branch November 4, 2022 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Images not uploading when you hit return immediately after pasting
3 participants