Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[No QA] Release pending versions before submitting a new version for review #21366

Merged
merged 3 commits into from
Jun 28, 2023
Merged

[No QA] Release pending versions before submitting a new version for review #21366

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
905fce5
Release pending versions before submitting a new version for review
roryabraham Jun 23, 2023
48125e2
Add code in null safety check
roryabraham Jun 23, 2023
cddb103
Read config values from Appfile
roryabraham Jun 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions fastlane/Fastfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -243,6 +243,25 @@ platform :ios do

desc "Move app to App Store Review"
lane :production do
# Login to Spaceship
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Source: fastlane/fastlane#17539 (comment)

fastlane_require 'spaceship'
teamID = "368M544MTT"
roryabraham marked this conversation as resolved.
Show resolved Hide resolved
Spaceship::ConnectAPI.login(
use_portal: false,
tunes_team_id: teamID,
)

# Find our app
app = Spaceship::ConnectAPI::App.find("com.chat.expensify.chat")
roryabraham marked this conversation as resolved.
Show resolved Hide resolved
if app.nil?
UI.important "not found in team #{teamID} on ASC!"
next
else
# If there's an app that's Pending Developer Release, release it before continuing with the new version
pendingReviewVersion = app.get_pending_release_app_store_version
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs: https://github.com/fastlane/fastlane/blob/master/spaceship/docs/AppStoreConnect.md#release-reviewed-build

version.create_app_store_version_release_request unless version.nil?
end

deliver(
api_key_path: "./ios/ios-fastlane-json-key.json",

Expand Down