Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alphabetize and shorten pronouns #2157

Merged
merged 1 commit into from
Mar 30, 2021
Merged

Alphabetize and shorten pronouns #2157

merged 1 commit into from
Mar 30, 2021

Conversation

timszot
Copy link
Contributor

@timszot timszot commented Mar 30, 2021

Details

Alphabetizes the constants and shortens the strings used for pronouns.

Fixed Issues

Fixes https://github.com/Expensify/Expensify/issues/158312

Tests

  1. Log into app
  2. Click on your profile bubble to open up the settings
  3. Click Preferences
  4. Click the Preferred Pronouns dropdown and confirm the 4 top options are shortened and in alphabetical order

QA Steps

Same as tests above:

  1. Log into app
  2. Click on your profile bubble to open up the settings
  3. Click Preferences
  4. Click the Preferred Pronouns dropdown and confirm the 4 top options are shortened and in alphabetical order

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

image

@timszot timszot requested a review from a team March 30, 2021 17:59
@timszot timszot self-assigned this Mar 30, 2021
@MelvinBot MelvinBot requested review from Beamanator and removed request for a team March 30, 2021 17:59
Beamanator
Beamanator approved these changes Mar 30, 2021
View reviewed changes
Copy link
Contributor

@Beamanator Beamanator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! #LGTM

@Beamanator Beamanator merged commit f534e6a into master Mar 30, 2021
@Beamanator Beamanator deleted the timszot_shortenPronouns branch March 30, 2021 19:17
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Beamanator Beamanator Beamanator approved these changes

Assignees

@timszot timszot

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@timszot @OSBotify @Beamanator