Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Sdk Version to 30 #2162

Merged
merged 1 commit into from
Mar 31, 2021
Merged

Update Sdk Version to 30 #2162

merged 1 commit into from
Mar 31, 2021

Conversation

timszot
Copy link
Contributor

@timszot timszot commented Mar 30, 2021

<If necessary, assign reviewers that know the area or changes well. Feel free to tag any additional reviewers you see fit.>

Details

Updates the compileSdkVersion and targetSdkVersion from 29 to 30 per guidance from Google. This only affects the Android build of the app.

Fixed Issues

Fixes https://github.com/Expensify/Expensify/issues/158346

Tests

I did sanity testing on a physical device for various functionality and didn't witness any crashes

  1. built app to physical device (pixel 3)
  2. log in and sanity test various functionality, send chats, open new chats.

QA Steps

  1. Exploratory tests

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

@timszot timszot requested review from AndrewGable and a team March 30, 2021 22:07
@timszot timszot self-assigned this Mar 30, 2021
@MelvinBot MelvinBot requested review from TomatoToaster and removed request for a team March 30, 2021 22:08
@AndrewGable AndrewGable merged commit 60e4806 into master Mar 31, 2021
@AndrewGable AndrewGable deleted the timszot_targetSdkVersion branch March 31, 2021 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants