Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix max participants text in New Group screen #2189

Merged
merged 4 commits into from
Apr 1, 2021

Conversation

marcaaron
Copy link
Contributor

@marcaaron marcaaron commented Apr 1, 2021

Details

#2103

Fixed Issues (Regression caused by linked PR)

Fixes #2175

Tests

QA Steps

  1. Navigate to Create Group
  2. Select 8 people to add to the group
  3. Verify the max participants text appears at the top of the view

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Screen Shot 2021-03-31 at 2 49 38 PM

iOS

2021-03-31_15-16-20

Android

2021-03-31_15-19-44

@marcaaron marcaaron requested a review from a team as a code owner April 1, 2021 00:49
@marcaaron marcaaron self-assigned this Apr 1, 2021
@MelvinBot MelvinBot requested review from ctkochan22 and removed request for a team April 1, 2021 00:49
@marcaaron marcaaron marked this pull request as draft April 1, 2021 00:50
@marcaaron marcaaron marked this pull request as ready for review April 1, 2021 01:20
@marcaaron
Copy link
Contributor Author

Just a heads up this issue is blocking the E.cash deploy

@ctkochan22 ctkochan22 merged commit 15c2ae4 into master Apr 1, 2021
@ctkochan22 ctkochan22 deleted the marcaaron-fixMaxParticipants branch April 1, 2021 22:31
@OSBotify
Copy link
Contributor

OSBotify commented Apr 1, 2021

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Group Creation - Message that you reached the max participants is not displayed.
3 participants