-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: do not escape HTML special chars for an invite's welcomeNote #21912
Conversation
@0xmiroslav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
We should wait until backend update is deployed to staging. And for regression test, we should invite both email and phone contacts and check both email and SMS. |
@akinwale Did you manage to test this? I haven't changed the backend yet, and after the first glance, we might not need to do any changes there. @0xmiroslav @akinwale Could you also please test this with the other characters that are supposed to be escaped in an HTML string? Let's test all of them for both email and SMS. |
@cristipaval Yes, I did with both an email and SMS recipient. I can include screenshots of the received messages if required.
Based on the documentation for the escape method, that means we'll test with these characters: |
@cristipaval @0xmiroslav Ran the following tests. Test 1It appears that HTML tags are being stripped out by the backend for both emails and SMS (anything between the SMS received (last message in thread) Test 2For the SMS message, backticks were converted to single quotes. All other characters appear to display fine here. |
I reopened this after some internal discussions. We want this solution. I'll add a HOLD on this PR because we need a Web-PR deployed before merging this one. |
FYI: We're close to get the Web-E PR merged. |
This is off hold. @akinwale Could you please merge latest main into this branch and make it ready for @0xmiroslav to test? |
@cristipaval Done! |
@0xmiroslav This is ready for review. Thanks. |
Workspace invite message not received from SMS. |
@0xmiroslav Yes, I did, and I received the SMS messages as expected, as well as the email. |
Wait, I think we limited Twilio to some countries only in staging. @0xmiroslav Could you please try in dev? |
You mean api point to production? |
Sorry, I'm stupid... you don't have access to dev backend. |
@cristipaval US country code for mine. |
That's why it works for you, @akinwale 👍 |
I can do the sms screenshot for you, @0xmiroslav |
Thanks |
Reviewer Checklist
Screenshots/VideosMobile Web - ChromeMobile Web - SafariDesktopiOSAndroidThe SMS screenshot below is added by @cristipaval according to this comment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cristipaval all yours
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/cristipaval in version: 1.3.48-0 🚀
|
🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.48-5 🚀
|
🚀 Deployed to staging by https://github.com/cristipaval in version: 1.3.49-0 🚀
|
🚀 Deployed to production by https://github.com/Beamanator in version: 1.3.49-3 🚀
|
This comment was marked as off-topic.
This comment was marked as off-topic.
@Pluto0104 I think this bug does not create a regression there. here they are fixing just remove the _.escape keyword. |
Details
This removes the escape operation performed on the welcomeNote.
Fixed Issues
$ #20081
PROPOSAL: #20081 (comment)
Tests
Offline tests
N/A
QA Steps
Same as tests.
PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Web
Mobile Web - Chrome
Mobile Web - Safari
Desktop
iOS
Android