Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all inline styles from the codebase #2202

Merged
merged 3 commits into from
Apr 1, 2021

Conversation

marcaaron
Copy link
Contributor

@marcaaron marcaaron commented Apr 1, 2021

Details

Inline styles are not allowed for consistency reasons, but they are being used here and there. This PR fixes the usages.

Fixed Issues

No Issue just routine maintenance

Tests

QA Steps

No specific QA just be on the lookout for any style regressions that might be caused by this PR

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Screen Shot 2021-04-01 at 9 05 53 AM

Mobile Web

2021-04-01_09-18-17

Desktop

2021-04-01_09-17-07

iOS

2021-04-01_09-11-46

Android

2021-04-01_09-15-42

@marcaaron marcaaron self-assigned this Apr 1, 2021
@marcaaron marcaaron requested a review from a team as a code owner April 1, 2021 19:03
@MelvinBot MelvinBot requested review from pecanoro and removed request for a team April 1, 2021 19:03
@marcaaron marcaaron requested a review from roryabraham April 1, 2021 19:03
Copy link
Contributor

@roryabraham roryabraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM and I didn't notice any regressions on web or desktop.

src/pages/home/sidebar/OptionRow.js Show resolved Hide resolved
src/styles/styles.js Show resolved Hide resolved
@roryabraham roryabraham merged commit 94a886a into master Apr 1, 2021
@roryabraham roryabraham deleted the marcaaron-styleCleanUp branch April 1, 2021 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants