Add avatar preview feature #22145

Puneet-here · 2023-07-03T23:59:49Z

Details

Fixed Issues

$ #11197
PROPOSAL: #11197 (comment)

Tests

Go to settings > profile
Click on avatar and add a photo if you don't have any
Click on the avatar again
Verify you see an option to view photo
Verify you can see the avatar preview

Go to settings >worskpaces
Click on a workspace and go to settings
Click on the avatar and add a photo if you don't have any
Click again and verify you see an option to view photo
Verify you can see the avatar preview

Verify that no errors appear in the JS console

Offline tests

Same

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Screen.Recording.2023-07-03.at.1.18.18.PM.mov

Screen.Recording.2023-07-03.at.1.17.24.PM.mov

Mobile Web - Chrome

Screen.Recording.2023-07-05.at.2.50.36.AM.mov

Screen.Recording.2023-07-05.at.2.49.04.AM.mov

Mobile Web - Safari

Screen.Recording.2023-07-03.at.3.48.43.PM.mov

Screen.Recording.2023-07-03.at.3.45.53.PM.mov

Desktop

Screen.Recording.2023-07-03.at.3.57.40.PM.mov

Screen.Recording.2023-07-03.at.3.56.31.PM.mov

iOS

Screen.Recording.2023-07-03.at.3.55.17.PM.mov

Screen.Recording.2023-07-03.at.3.54.24.PM.mov

Android

Screen.Recording.2023-07-03.at.3.41.05.PM.mov

Screen.Recording.2023-07-03.at.3.39.50.PM.mov

melvin-bot · 2023-07-04T00:08:26Z

@rushatgabhane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

rushatgabhane · 2023-07-04T14:05:27Z

@venture1981 please avoid unhelpful comments on issues or PRs.

rushatgabhane · 2023-07-06T15:15:23Z

@Puneet-here could you please resolve the conflicts

Puneet-here · 2023-07-07T09:51:51Z

@rushatgabhane, done!

src/components/AvatarWithImagePicker.js

rushatgabhane · 2023-07-13T04:22:33Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-09-19.at.01.49.35.mov

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

rushatgabhane

@Puneet-here bug: attachment preview doesn't show the image

upload profile photo
click view profile

Expected: attachment preview shows the uploaded photo
Actual: You see attachment icon only

Screen.Recording.2023-07-18.at.10.30.28.mov

Puneet-here · 2023-07-20T11:59:53Z

Is there any extra step. I wasn't able to repro it

Screen.Recording.2023-07-20.at.5.24.30.PM.mov

Screen.Recording.2023-07-20.at.5.28.02.PM.mov

Puneet-here · 2023-07-24T09:13:10Z

Is there any extra step. I wasn't able to repro it

bump @rushatgabhane

rushatgabhane · 2023-07-25T10:44:09Z

@Puneet-here no extra steps, and it's consistently reproducible.

trjExpensify · 2023-07-25T13:41:51Z

Let's keep this moving! What other variables could there be? different file types maybe?

Puneet-here · 2023-07-26T17:50:02Z

I was finally able to reproduce it. So it happens when you open it immediately. You have to be super fast. Looking into the problem.

rushatgabhane · 2023-07-26T17:51:53Z

maybe being offline will consistently reproduce it?

Puneet-here · 2023-07-26T18:27:23Z

maybe being offline will consistently reproduce it?

I tried a slow internet connection and also being offline but it didn't work. You just have to be very fast to repro this. I just tried checking the avatar preview in user profile page and it seems like this is reproducible there as well so I can confirm that this behaviour is already present in our attachment modal and not related to this PR. I think we should open a new ticket for this. It's really hard to repro on user profile page so here's how I would suggest reproducing it-

Login to your account on two devices
In device 1 go to any room and go to members
Click on your own profile to see the user details
At device 2 go to profile page and upload an image
Now on device 1 click on the avatar asap

Puneet-here · 2023-07-31T19:35:35Z

bump @rushatgabhane

rushatgabhane · 2023-08-03T05:39:00Z

@Puneet-here could you please resolve conflicts. thx!

Puneet-here · 2023-08-04T17:14:25Z

Done @rushatgabhane

rushatgabhane · 2023-08-07T20:47:31Z

@Puneet-here Looks like we had more conflicts over the weekend 😅

Puneet-here · 2023-08-08T09:15:26Z

Done @rushatgabhane

rushatgabhane

Bug: mWeb safari - native attachment picker opens on clicking view photo

Screen.Recording.2023-08-09.at.22.17.47.mov

Puneet-here · 2023-08-17T04:06:05Z

@rushatgabhane, I am not sure what the problem was but i found that it only happens when view photo option is on top. I have changed its position to last. Hope it's fine.

rushatgabhane · 2023-08-18T04:34:07Z

@Puneet-here thanks! I think we need to dive deeper. I think view photo option should be the first item in the menu.
cc: @stitesExpensify

Puneet-here · 2023-08-22T09:55:01Z

@rushatgabhane, maybe we should get confirmation from design team.

Puneet-here · 2023-08-28T08:36:31Z

@rushatgabhane, I believe we can move forward with the current change since others don't think strongly about keeping the view photo as the first option?

We can also keep it second in the list if we want.

rushatgabhane · 2023-09-01T04:14:35Z

Okay, sounds good! Let's wait for merge freeze to be over

rushatgabhane

@Puneet-here the merge freeze is officially over! Let's merge with latest main an re-test once, thanks!

…ViewOption

Puneet-here · 2023-09-15T22:55:10Z

Done @rushatgabhane

rushatgabhane

@stitesExpensify LGTM!

checklist - #22145 (comment)

stitesExpensify

LGTM

OSBotify · 2023-09-19T04:08:45Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

ayazhussain79 · 2023-09-19T11:43:05Z

Should the "Preview" header for "Profile avatar" be updated after uploading an image to "Profile picture"?

OSBotify · 2023-09-20T08:45:39Z

🚀 Deployed to staging by https://github.com/stitesExpensify in version: 1.3.72-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-09-22T13:27:34Z

🚀 Deployed to production by https://github.com/thienlnam in version: 1.3.72-11 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fedirjh · 2023-10-16T15:45:53Z

src/pages/settings/Profile/ProfilePage.js

@@ -123,6 +125,9 @@ function ProfilePage(props) {
                    errors={lodashGet(props.currentUserPersonalDetails, 'errorFields.avatar', null)}
                    errorRowStyles={[styles.mt6]}
                    onErrorClose={PersonalDetails.clearAvatarErrors}
+                    previewSource={UserUtils.getFullSizeAvatar(avatarURL, accountID)}
+                    originalFileName={currentUserDetails.originalFileName}


@Puneet-here, @rushatgabhane This line is confusing, does the personal details have an originalFileName prop? the server does not seem to return this prop and it's causing this bug #29647 .

Puneet-here added 6 commits July 4, 2023 05:02

add new translation keys

8548ac7

Update es.js

7e39af5

add avatar preview option

08a9302

make profile avatar viewable

dba176b

add orginalFileName

5643d74

add avatar preview feature at workpace page

d2ca224

Puneet-here marked this pull request as ready for review July 4, 2023 00:08

Puneet-here requested a review from a team as a code owner July 4, 2023 00:08

melvin-bot bot requested review from rushatgabhane and removed request for a team July 4, 2023 00:08

Merge branch 'main' into avatarViewOption

e22931e

rushatgabhane reviewed Jul 7, 2023

View reviewed changes

src/components/AvatarWithImagePicker.js Outdated Show resolved Hide resolved

stitesExpensify self-requested a review July 13, 2023 17:25

rushatgabhane suggested changes Jul 18, 2023

View reviewed changes

Merge branch 'main' into avatarViewOption

06139a0

Merge branch 'main' into avatarViewOption

2d84691

Puneet-here added 2 commits August 8, 2023 14:40

Merge branch 'main' into avatarViewOption

fb931b1

Fix proptype error

b3adbfe

rushatgabhane suggested changes Aug 9, 2023

View reviewed changes

Puneet-here added 2 commits August 17, 2023 09:16

Merge branch 'main' into avatarViewOption

c95567b

fix native attachment picker opening on clicking view photo

f6d1286

rushatgabhane mentioned this pull request Aug 23, 2023

[HOLD for payment 2023-09-29] [Image] Feature Request: Introduce an ability to view workspace picture with a single tap - reported by @chauchausoup #11197

Closed

rushatgabhane suggested changes Sep 11, 2023

View reviewed changes

Puneet-here added 3 commits September 16, 2023 00:52

Merge branch 'main' of https://github.com/Puneet-here/App into avatar…

f5b716a

…ViewOption

Update en.ts

94472de

Update es.ts

be686ac

rushatgabhane approved these changes Sep 18, 2023

View reviewed changes

stitesExpensify approved these changes Sep 19, 2023

View reviewed changes

stitesExpensify merged commit fed1967 into Expensify:main Sep 19, 2023
12 checks passed

jeet-dhandha mentioned this pull request Sep 19, 2023

[$500] Dev: Web - The profile preview header displays "Profile avatar" instead of "Profile picture" #27785

Closed

6 tasks

OSBotify mentioned this pull request Sep 20, 2023

Deploy Checklist: New Expensify 2023-09-20 #27837

Closed

fedirjh reviewed Oct 16, 2023

View reviewed changes

fedirjh mentioned this pull request Oct 16, 2023

[$500] Profile - View Profile photo after Uploading new photo shows attachment preview without name for a breif moment #29647

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add avatar preview feature #22145

Add avatar preview feature #22145

Puneet-here commented Jul 3, 2023 •

edited

Loading

melvin-bot bot commented Jul 4, 2023

rushatgabhane commented Jul 4, 2023

rushatgabhane commented Jul 6, 2023

Puneet-here commented Jul 7, 2023

rushatgabhane commented Jul 13, 2023 •

edited

Loading

rushatgabhane left a comment

Puneet-here commented Jul 20, 2023

Puneet-here commented Jul 24, 2023

rushatgabhane commented Jul 25, 2023 •

edited

Loading

trjExpensify commented Jul 25, 2023

Puneet-here commented Jul 26, 2023

rushatgabhane commented Jul 26, 2023

Puneet-here commented Jul 26, 2023

Puneet-here commented Jul 31, 2023

rushatgabhane commented Aug 3, 2023

Puneet-here commented Aug 4, 2023

rushatgabhane commented Aug 7, 2023 •

edited

Loading

Puneet-here commented Aug 8, 2023

rushatgabhane left a comment •

edited

Loading

Puneet-here commented Aug 17, 2023

rushatgabhane commented Aug 18, 2023 •

edited

Loading

Puneet-here commented Aug 22, 2023

Puneet-here commented Aug 28, 2023 •

edited

Loading

rushatgabhane commented Sep 1, 2023

rushatgabhane left a comment

Puneet-here commented Sep 15, 2023

rushatgabhane left a comment

stitesExpensify left a comment

OSBotify commented Sep 19, 2023

ayazhussain79 commented Sep 19, 2023

OSBotify commented Sep 20, 2023

OSBotify commented Sep 22, 2023

fedirjh Oct 16, 2023

Add avatar preview feature #22145

Add avatar preview feature #22145

Conversation

Puneet-here commented Jul 3, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jul 4, 2023

rushatgabhane commented Jul 4, 2023

rushatgabhane commented Jul 6, 2023

Puneet-here commented Jul 7, 2023

rushatgabhane commented Jul 13, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

rushatgabhane left a comment

Choose a reason for hiding this comment

Puneet-here commented Jul 20, 2023

Puneet-here commented Jul 24, 2023

rushatgabhane commented Jul 25, 2023 • edited Loading

trjExpensify commented Jul 25, 2023

Puneet-here commented Jul 26, 2023

rushatgabhane commented Jul 26, 2023

Puneet-here commented Jul 26, 2023

Puneet-here commented Jul 31, 2023

rushatgabhane commented Aug 3, 2023

Puneet-here commented Aug 4, 2023

rushatgabhane commented Aug 7, 2023 • edited Loading

Puneet-here commented Aug 8, 2023

rushatgabhane left a comment • edited Loading

Choose a reason for hiding this comment

Puneet-here commented Aug 17, 2023

rushatgabhane commented Aug 18, 2023 • edited Loading

Puneet-here commented Aug 22, 2023

Puneet-here commented Aug 28, 2023 • edited Loading

rushatgabhane commented Sep 1, 2023

rushatgabhane left a comment

Choose a reason for hiding this comment

Puneet-here commented Sep 15, 2023

rushatgabhane left a comment

Choose a reason for hiding this comment

stitesExpensify left a comment

Choose a reason for hiding this comment

OSBotify commented Sep 19, 2023

ayazhussain79 commented Sep 19, 2023

OSBotify commented Sep 20, 2023

OSBotify commented Sep 22, 2023

fedirjh Oct 16, 2023

Choose a reason for hiding this comment

Puneet-here commented Jul 3, 2023 •

edited

Loading

rushatgabhane commented Jul 13, 2023 •

edited

Loading

rushatgabhane commented Jul 25, 2023 •

edited

Loading

rushatgabhane commented Aug 7, 2023 •

edited

Loading

rushatgabhane left a comment •

edited

Loading

rushatgabhane commented Aug 18, 2023 •

edited

Loading

Puneet-here commented Aug 28, 2023 •

edited

Loading