Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[No QA] Update documentation regarding hooks usage #2233

Merged
merged 1 commit into from
Apr 6, 2021

Conversation

marcaaron
Copy link
Contributor

@marcaaron marcaaron commented Apr 5, 2021

Details

This PR does two things

  1. Adds an exception to the usage of hooks. Hook from 3rd party libraries will not be permitted if there is no clear or simple alternative to using them.
  2. Static getters and setters are not permitted.

The second one isn't likely to come up too often, but chatted with @tgolen about this one so I think it's worth a quick mention.

Fixed Issues

No Issue but relevant conversation happening here -> https://expensify.slack.com/archives/C01GTK53T8Q/p1617649919372600

Tests

None

QA Steps

None

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

@marcaaron marcaaron requested a review from a team as a code owner April 5, 2021 21:21
@marcaaron marcaaron self-assigned this Apr 5, 2021
@MelvinBot MelvinBot requested review from yuwenmemon and removed request for a team April 5, 2021 21:21
@yuwenmemon yuwenmemon merged commit a5f0ce5 into master Apr 6, 2021
@yuwenmemon yuwenmemon deleted the marcaaron-hooks branch April 6, 2021 01:20
@OSBotify
Copy link
Contributor

OSBotify commented Apr 6, 2021

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants