Update PersonalDetails migration of reportActions to remove email-based data #22432

puneetlath · 2023-07-07T16:10:42Z

Details

Now that the back-end is no longer sending email-based data to reportActions, we update the migration to remove any email-based data that is found. If the equivalent accountID-based data is not found in the reportAction, we simply remove the reportAction from Onyx so that it can be fetched from the API with the needed data next time it is loaded.

Fixed Issues

#21454

Tests

The automated tests should mostly cover this since it's an Onyx migration. However you can also test the various cases manually by:

In the JS console do Onyx.set('reportActions_123', {1: {accountEmail: 'hi', accountID: 1000}});
Check reportActions_123 in application storage and make sure you see what you set
Refresh the page
Make sure that reportActions_123 is now just {1: {accountID: 1000}}
In the JS console do Onyx.set('reportActions_123', {1: {accountEmail: 'hi'}});
Check reportActions_123 in application storage and make sure you see what you set
Refresh the page
Make sure that reportActions_123 is now an empty object
Do a similar test with other keys that are being updated

Verify that no errors appear in the JS console

Offline tests

Same tests work online or offline.

QA Steps

There is nothing in particular to QA for this PR as there are no user-facing changes. Regular regression testing that the app is working as normal should be enough.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

melvin-bot · 2023-07-07T16:39:34Z

@Santhosh-Sellavel Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

puneetlath · 2023-07-07T16:40:29Z

Sorry @Santhosh-Sellavel not sure why it tagged you. @s77rt is the C+ on the issue.

@s77rt the code is ready to review and it can be tested by following the steps described.

We'll hold on merging until 100% of the back-end reportActions email stuff has stopped being sent in production.

s77rt · 2023-07-07T22:20:30Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

s77rt

LGTM! 🚀

melvin-bot · 2023-07-07T22:22:40Z

@pecanoro Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Beamanator

Love it! Can't wait to get this merged!

pecanoro · 2023-07-10T20:41:03Z

Everything looks good, but I don't see any videos or screenshots. I think we should show that the app is still working after making these changes and we don't leave the app in a weird state.

pecanoro · 2023-07-10T21:01:41Z

I tested it, the app seems to be working still! 😄

puneetlath · 2023-07-11T14:48:39Z

Thanks @pecanoro! All blocking issues have been merged. So we will be ready to merge this once they hit production (likely tomorrow)

puneetlath · 2023-07-12T13:31:48Z

This can be merged once the following back-end PRs are on production:

Beamanator · 2023-07-14T12:51:26Z

All web-e PRs we were holding on are in prod! Let's merge! 💪

OSBotify · 2023-07-14T12:55:38Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-07-14T15:00:35Z

🚀 Deployed to staging by https://github.com/Beamanator in version: 1.3.41-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-07-17T19:38:20Z

🚀 Deployed to production by https://github.com/Julesssss in version: 1.3.41-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪
🕸 web 🕸	success ✅

OSBotify · 2023-07-17T19:39:20Z

🚀 Deployed to staging by https://github.com/Beamanator in version: 1.3.42-0 🚀

platform	result
🤖 android 🤖	cancelled 🔪
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪
🕸 web 🕸	cancelled 🔪

OSBotify · 2023-07-17T22:04:12Z

🚀 Deployed to production by https://github.com/Julesssss in version: 1.3.41-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-07-19T18:01:05Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.42-26 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

puneetlath added 4 commits July 7, 2023 11:48

Remove email-based info from reportActions

c5d71d0

Update tests to account for udpated logic

827ab66

Update tests to be less unnecessarily verbose

84607ca

Update comments for updated approach

1ba5a45

puneetlath self-assigned this Jul 7, 2023

Correct childOldestFourAccountIDs to be string

6bca602

puneetlath changed the title ~~Update PersonalDetails migration of reportActions to remove email-based data~~ [HOLD E/E #294647] Update PersonalDetails migration of reportActions to remove email-based data Jul 7, 2023

puneetlath mentioned this pull request Jul 7, 2023

[HOLD for payment 2023-12-07] [HOLD for payment 2023-10-13] [HOLD for payment 2023-07-14] Onyx migration for personalDetails changes #21454

Closed

9 tasks

puneetlath marked this pull request as ready for review July 7, 2023 16:39

puneetlath requested a review from a team as a code owner July 7, 2023 16:39

melvin-bot bot requested review from Santhosh-Sellavel and removed request for a team July 7, 2023 16:39

puneetlath requested review from s77rt and removed request for Santhosh-Sellavel July 7, 2023 16:39

puneetlath requested a review from Beamanator July 7, 2023 19:29

s77rt approved these changes Jul 7, 2023

View reviewed changes

melvin-bot bot requested a review from pecanoro July 7, 2023 22:22

Beamanator approved these changes Jul 10, 2023

View reviewed changes

pecanoro approved these changes Jul 10, 2023

View reviewed changes

Beamanator changed the title ~~[HOLD E/E #294647] Update PersonalDetails migration of reportActions to remove email-based data~~ Update PersonalDetails migration of reportActions to remove email-based data Jul 14, 2023

Beamanator merged commit 0151134 into main Jul 14, 2023

Beamanator deleted the personalDetails-migration-reportActions branch July 14, 2023 12:51

OSBotify mentioned this pull request Jul 14, 2023

Deploy Checklist: New Expensify 2023-07-14 #22896

Closed

45 tasks

OSBotify mentioned this pull request Jul 17, 2023

Deploy Checklist: New Expensify 2023-07-17 #23033

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update PersonalDetails migration of reportActions to remove email-based data #22432

Update PersonalDetails migration of reportActions to remove email-based data #22432

puneetlath commented Jul 7, 2023 •

edited

Loading

melvin-bot bot commented Jul 7, 2023

puneetlath commented Jul 7, 2023 •

edited

Loading

s77rt commented Jul 7, 2023

s77rt left a comment

melvin-bot bot commented Jul 7, 2023

Beamanator left a comment

pecanoro commented Jul 10, 2023

pecanoro commented Jul 10, 2023

puneetlath commented Jul 11, 2023

puneetlath commented Jul 12, 2023 •

edited by Beamanator

Loading

Beamanator commented Jul 14, 2023

OSBotify commented Jul 14, 2023

OSBotify commented Jul 14, 2023

OSBotify commented Jul 17, 2023

OSBotify commented Jul 17, 2023

OSBotify commented Jul 17, 2023

OSBotify commented Jul 19, 2023

Update PersonalDetails migration of reportActions to remove email-based data #22432

Update PersonalDetails migration of reportActions to remove email-based data #22432

Conversation

puneetlath commented Jul 7, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jul 7, 2023

puneetlath commented Jul 7, 2023 • edited Loading

s77rt commented Jul 7, 2023

Reviewer Checklist

Screenshots/Videos

s77rt left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Jul 7, 2023

Beamanator left a comment

Choose a reason for hiding this comment

pecanoro commented Jul 10, 2023

pecanoro commented Jul 10, 2023

puneetlath commented Jul 11, 2023

puneetlath commented Jul 12, 2023 • edited by Beamanator Loading

Beamanator commented Jul 14, 2023

OSBotify commented Jul 14, 2023

OSBotify commented Jul 14, 2023

OSBotify commented Jul 17, 2023

OSBotify commented Jul 17, 2023

OSBotify commented Jul 17, 2023

OSBotify commented Jul 19, 2023

puneetlath commented Jul 7, 2023 •

edited

Loading

puneetlath commented Jul 7, 2023 •

edited

Loading

puneetlath commented Jul 12, 2023 •

edited by Beamanator

Loading