[No QA] Simplify StagingDeployCash comparison URL #2261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jag96
previously approved these changes
Apr 7, 2021
.github/libs/GithubUtils.js
Outdated
| return issueBody; | ||
| }) | ||
| // eslint-disable-next-line no-console | ||
| .catch(err => console.warn('Error generating comparison URL, continuing...', err)); |
There was a problem hiding this comment.
Is this warning still accurate? It sounds like this should be something like Error generating issue body
deetergp
previously approved these changes
Apr 7, 2021
|
Updated the console warning 👍 |
Jag96
approved these changes
Apr 7, 2021
deetergp
approved these changes
Apr 7, 2021
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
I feel like a big dum-dum for not seeing this simplification earlier! Silver lining though: the contributor who worked on the
generateVersionComparisonURLdid set up a good baseline for unit testing theGithubUtilsFixed Issues
Fixes https://github.com/Expensify/Expensify/issues/158542
Tests
StagingDeployCashis not locked.StagingDeployCashshould be updated and the "compare changes" link should be this: production...stagingPlatforms
Github only, no changes in-product.