Hide muted chats from LHN #22717

chiragsalian · 2023-07-11T22:04:44Z

Details

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/295764

Tests

Its easiest to test this with child reports

Send a message on a report. Thread the message such that you are now viewing the child report.
Click on the report header -> settings -> change notification from immediate to mute. (if this auth PR is live, it will be mute by default and then you don't have to change anything)
Confirm when viewing the child report you see it in LHN.
Click on the parent report in LHN or from report header.
Confirm you no longer see child report in the LHN.
Thread the message to go back to the child report. Pin it.
Click on the parent report in LHN or from report header and confirm you can see the child report in LHN because its pinned.

Verify that no errors appear in the JS console

Offline tests

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-07-13.at.3.47.06.PM.mov

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

melvin-bot · 2023-07-13T23:09:55Z

@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

eVoloshchak · 2023-07-17T10:39:33Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-07-17.at.14.50.46.mov

Mobile Web - Chrome

screen-20230717-145810.2.mp4

Mobile Web - Safari

Screen.Recording.2023-07-17.at.14.55.34.mov

Desktop

Screen.Recording.2023-07-17.at.14.52.30.mov

iOS

Screen.Recording.2023-07-17.at.14.54.06.mov

Android

screen-20230717-145952.mp4

eVoloshchak

Looks good and tests well

melvin-bot · 2023-07-17T12:14:28Z

@srikarparsi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

srikarparsi

looks good to me as well!

OSBotify · 2023-07-17T17:38:37Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

srikarparsi · 2023-07-17T18:01:19Z

Hey @chiragsalian! I was reading through the threads discussion after merging this PR because I had an idea for subscribing but then I saw that the conversation about not displaying muted chats was just about threads and not chats whereas this PR stops displaying all muted chats that are unread. This is not expected behavior right? If I have a regular chat with you and mute it, I still want to be able to see it in my LHN right?

OSBotify · 2023-07-17T19:37:59Z

🚀 Deployed to staging by https://github.com/srikarparsi in version: 1.3.42-0 🚀

platform	result
🤖 android 🤖	cancelled 🔪
🖥 desktop 🖥	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪
🕸 web 🕸	cancelled 🔪

OSBotify · 2023-07-19T17:59:44Z

🚀 Deployed to production by https://github.com/jasperhuangg in version: 1.3.42-26 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

chiragsalian · 2023-07-21T18:15:08Z

I think it's fine to hide all muted chats from LHN for now since that's what we'll be implementing for threads. I don't see any reason for the LHN chat behavior to be different between regular chats that are muted and thread chats that are muted.

Let me know if that makes sense or if you were thinking about something else?

mkhutornyi · 2024-08-08T18:39:19Z

src/components/LHNOptionsList/OptionRowLHN.js

+    const isMuted = optionItem.notificationPreference === CONST.REPORT.NOTIFICATION_PREFERENCE.MUTE;
+    if (isMuted && !props.isFocused && !optionItem.isPinned) {
+        return null;
+    }


There's case when muted report has draft comment, which should be displayed in LHN.
#45543

chiragsalian added 2 commits July 11, 2023 15:03

exclude muted chats that are not focused

baf9627

return notification preference in optionList

50a60b7

chiragsalian self-assigned this Jul 11, 2023

chiragsalian added 3 commits July 12, 2023 14:12

check for pinned

4f0db82

Merge branch 'main' into chirag-thread-subscription-logic

308f57e

Merge branch 'main' into chirag-thread-subscription-logic

4d2d58f

chiragsalian changed the title ~~[WIP] Thread subscription logic improvements~~ [WIP] Hide muted chats from LHN Jul 13, 2023

Merge branch 'main' into chirag-thread-subscription-logic

89ca3cc

chiragsalian changed the title ~~[WIP] Hide muted chats from LHN~~ Hide muted chats from LHN Jul 13, 2023

chiragsalian marked this pull request as ready for review July 13, 2023 23:09

chiragsalian requested a review from a team as a code owner July 13, 2023 23:09

melvin-bot bot requested review from eVoloshchak and removed request for a team July 13, 2023 23:09

eVoloshchak approved these changes Jul 17, 2023

View reviewed changes

melvin-bot bot requested a review from srikarparsi July 17, 2023 12:14

srikarparsi approved these changes Jul 17, 2023

View reviewed changes

srikarparsi merged commit 674015c into main Jul 17, 2023

srikarparsi deleted the chirag-thread-subscription-logic branch July 17, 2023 17:34

srikarparsi restored the chirag-thread-subscription-logic branch July 17, 2023 18:01

OSBotify mentioned this pull request Jul 17, 2023

Deploy Checklist: New Expensify 2023-07-17 #23033

Closed

srikarparsi mentioned this pull request Jul 17, 2023

Revert "Hide muted chats from LHN" #23037

Merged

56 tasks

c3024 mentioned this pull request Jul 18, 2023

[$1000] [HOLD for payment] 'announce' room disapears from LHN when changing notification setting to 'Mute' #23100

Closed

6 tasks

srikarparsi mentioned this pull request Jul 25, 2023

Hide All Muted Chats #23521

Merged

58 tasks

This comment was marked as resolved.

Sign in to view

chiragsalian mentioned this pull request Aug 21, 2023

Return early for hidden notification preference #25618

Merged

59 tasks

hungvu193 mentioned this pull request Aug 24, 2023

App shows an unread count of 1 while no unreads appear in LHN #25774

Closed

s-alves10 mentioned this pull request Jan 18, 2024

[$500] IOU - Created IOU is not displayed on LHN #34757

Closed

6 tasks

mkhutornyi reviewed Aug 8, 2024

View reviewed changes

mkhutornyi mentioned this pull request Aug 8, 2024

[HOLD for payment 2024-08-09] [$250] Draft disappears from the LHN when clicking away after starting a thread #45543

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Hide muted chats from LHN #22717

Hide muted chats from LHN #22717

chiragsalian commented Jul 11, 2023 •

edited

Loading

melvin-bot bot commented Jul 13, 2023

eVoloshchak commented Jul 17, 2023 •

edited

Loading

eVoloshchak left a comment

melvin-bot bot commented Jul 17, 2023

srikarparsi left a comment

OSBotify commented Jul 17, 2023

srikarparsi commented Jul 17, 2023 •

edited

Loading

OSBotify commented Jul 17, 2023

OSBotify commented Jul 19, 2023

chiragsalian commented Jul 21, 2023

This comment was marked as resolved.

mkhutornyi Aug 8, 2024

Hide muted chats from LHN #22717

Hide muted chats from LHN #22717

Conversation

chiragsalian commented Jul 11, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jul 13, 2023

eVoloshchak commented Jul 17, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

eVoloshchak left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Jul 17, 2023

srikarparsi left a comment

Choose a reason for hiding this comment

OSBotify commented Jul 17, 2023

srikarparsi commented Jul 17, 2023 • edited Loading

OSBotify commented Jul 17, 2023

OSBotify commented Jul 19, 2023

chiragsalian commented Jul 21, 2023

This comment was marked as resolved.

mkhutornyi Aug 8, 2024

Choose a reason for hiding this comment

chiragsalian commented Jul 11, 2023 •

edited

Loading

eVoloshchak commented Jul 17, 2023 •

edited

Loading

srikarparsi commented Jul 17, 2023 •

edited

Loading