Return a promise #2308
Merged
Return a promise #2308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deetergp
force-pushed
the
scott_fixJobName
branch
from
62cf44c to
6a99d04
Compare
roryabraham
approved these changes
Apr 8, 2021
|
@roryabraham looks like this was merged without passing tests. Please add a note explaining why this was done or remove the |
|
Merging to fix production deploys |
|
It worked! Next, we need to test the various scenarios that can happen... |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR returns the expected promise for
reopenIssueWithCommentas well as improves some variable names incheckDeployBlockers.