Fix wrong last accessed report #23625

bernhardoj · 2023-07-26T11:14:33Z

Details

findLastAccessedReport return the last accessed report to be shown on the report screen. However, the sorting is not working correctly when the item has a null value. This PR filter out null value.

Fixed Issues

$ #20780
PROPOSAL: #20780 (comment)

Tests

A new test was added: sortReportsByLastRead

Same as QA Steps

Verify that no errors appear in the JS console

Offline tests

Requires internet connection to refresh/reload

QA Steps

Web/Desktop

Open any chat
Open Settings
Reload the web/desktop app
Verify the chat in the background shows the chat you open on step 1

Android/iOS/mWeb
Not applicable

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Before:

Screen.Recording.2023-07-26.at.19.04.45.mov

After:

Screen.Recording.2023-07-26.at.19.06.33.mov

Mobile Web - Chrome

Screen.Recording.2023-07-27.at.12.22.44.mov

Mobile Web - Safari

Screen.Recording.2023-07-27.at.12.25.15.mov

Desktop

Before:

Screen.Recording.2023-07-26.at.19.10.55.mov

After:

Screen.Recording.2023-07-26.at.19.11.46.mov

iOS

Screen.Recording.2023-07-27.at.12.24.10.mov

Android

Untitled.mov

melvin-bot · 2023-07-26T11:14:39Z

@abdulrahuman5196 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

bernhardoj · 2023-07-26T11:15:26Z

tests/unit/ReportUtilsTest.js

+                5: {lastReadTime: '2023-07-09 07:15:44.030'},
+                6: {reportID: 6},
+                7: {},
+            };


added more cases where the lastReadTime and/or reportID is undefined

bernhardoj · 2023-07-26T11:17:25Z

I added before and after for the recording to make it clear what is the issue.

About the QA Steps, even though it won't be 100% reliable to reproduce the issue with the steps, at least it should still work as usual after the changes.

src/libs/ReportUtils.js

abdulrahuman5196 · 2023-07-26T19:49:14Z

@bernhardoj And IMO even though the fix is not directly applicable to other platforms, adding videos of just opening reports could be added. This will help us understand we have tested basic functionality around the change in all platforms to avoid regressions. Can we add the same?

bernhardoj · 2023-07-27T04:31:57Z

@abdulrahuman5196 added the recording (open app and report) for mobile.

abdulrahuman5196 · 2023-07-31T08:10:40Z

Reviewing now

abdulrahuman5196 · 2023-07-31T08:36:49Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-07-31.at.1.53.22.PM.mp4

Mobile Web - Chrome

az_recorder_20230731_141301.mp4

Mobile Web - Safari

Untitled.1.mp4

Desktop

Screen.Recording.2023-07-31.at.2.00.05.PM.mp4

iOS

Screen.Recording.2023-07-31.at.2.03.02.PM.mp4

Android

Screen.Recording.2023-07-31.at.2.05.16.PM.mp4

abdulrahuman5196 · 2023-07-31T09:00:33Z

I wasn't able to reproduce this issue for admin/room chat as initially described in the issue.

But I am able to reproduce this issue for other chat type user and workspace created when we add members to workspace. But still I will be approving this change since the original issue is not reprodicible with this fix and this is a valuable/needed change given the analysis of lastReadTime being null.

How should we take the issue for the below mentioned chat type with similar issue? Should I report a separate bug? Or can we create a followup issue directly and take it forward? @Julesssss

Screen.Recording.2023-07-31.at.1.49.01.PM.mp4

Screen.Recording.2023-07-31.at.1.51.23.PM.mp4

Screen.Recording.2023-07-31.at.1.46.46.PM.mp4

abdulrahuman5196 · 2023-07-31T09:01:51Z

@bernhardoj And for offline tests, it should be Same as QA steps since even offline we can reload the page and it will load in offline status.

abdulrahuman5196

Changes looks good and works well. Reviewers checklist is also complete.

All yours. @Julesssss

🎀 👀 🎀
C+ Reviewed

OSBotify · 2023-07-31T09:23:21Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-07-31T18:57:35Z

🚀 Deployed to staging by https://github.com/Julesssss in version: 1.3.48-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-01T23:58:51Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.48-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-02T01:23:21Z

🚀 Deployed to staging by https://github.com/Julesssss in version: 1.3.49-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-03T18:15:48Z

🚀 Deployed to production by https://github.com/Beamanator in version: 1.3.49-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

fix wrong last accessed report

93fd82d

bernhardoj requested a review from a team as a code owner July 26, 2023 11:14

melvin-bot bot requested review from abdulrahuman5196 and removed request for a team July 26, 2023 11:14

bernhardoj commented Jul 26, 2023

View reviewed changes

Julesssss assigned bernhardoj Jul 26, 2023

abdulrahuman5196 reviewed Jul 26, 2023

View reviewed changes

src/libs/ReportUtils.js Show resolved Hide resolved

abdulrahuman5196 approved these changes Jul 31, 2023

View reviewed changes

melvin-bot bot requested a review from Julesssss July 31, 2023 09:04

Julesssss approved these changes Jul 31, 2023

View reviewed changes

Julesssss merged commit 8cdb506 into Expensify:main Jul 31, 2023

OSBotify mentioned this pull request Jul 31, 2023

Deploy Checklist: New Expensify 2023-07-31 #23945

Closed

48 tasks

OSBotify mentioned this pull request Aug 1, 2023

Deploy Checklist: New Expensify 2023-08-01 #24028

Closed

79 tasks

melvin-bot bot mentioned this pull request Aug 1, 2023

[HOLD for payment 2023-08-08] [$1000] Reload on custom room details page after adding member in workspace opens admins room of workspace in background #20780

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix wrong last accessed report #23625

Fix wrong last accessed report #23625

bernhardoj commented Jul 26, 2023 •

edited

Loading

melvin-bot bot commented Jul 26, 2023

bernhardoj Jul 26, 2023

bernhardoj commented Jul 26, 2023

abdulrahuman5196 commented Jul 26, 2023

bernhardoj commented Jul 27, 2023

abdulrahuman5196 commented Jul 31, 2023

abdulrahuman5196 commented Jul 31, 2023 •

edited

Loading

abdulrahuman5196 commented Jul 31, 2023

abdulrahuman5196 commented Jul 31, 2023

abdulrahuman5196 left a comment

OSBotify commented Jul 31, 2023

OSBotify commented Jul 31, 2023

OSBotify commented Aug 1, 2023

OSBotify commented Aug 2, 2023

OSBotify commented Aug 3, 2023

Fix wrong last accessed report #23625

Fix wrong last accessed report #23625

Conversation

bernhardoj commented Jul 26, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jul 26, 2023

bernhardoj Jul 26, 2023

Choose a reason for hiding this comment

bernhardoj commented Jul 26, 2023

abdulrahuman5196 commented Jul 26, 2023

bernhardoj commented Jul 27, 2023

abdulrahuman5196 commented Jul 31, 2023

abdulrahuman5196 commented Jul 31, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

abdulrahuman5196 commented Jul 31, 2023

abdulrahuman5196 commented Jul 31, 2023

abdulrahuman5196 left a comment

Choose a reason for hiding this comment

OSBotify commented Jul 31, 2023

OSBotify commented Jul 31, 2023

OSBotify commented Aug 1, 2023

OSBotify commented Aug 2, 2023

OSBotify commented Aug 3, 2023

bernhardoj commented Jul 26, 2023 •

edited

Loading

abdulrahuman5196 commented Jul 31, 2023 •

edited

Loading