Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix success icon in ReportActionContextMenu #2364

Merged
merged 1 commit into from
Apr 13, 2021
Merged

Fix success icon in ReportActionContextMenu #2364

merged 1 commit into from
Apr 13, 2021

Conversation

roryabraham
Copy link
Contributor

@roryabraham roryabraham commented Apr 13, 2021 •
edited
Loading

Details

Fixes a regression caused by this PR. Shoutout to @parasharrajat for pointing this out in slack.

Fixed Issues

n/a – fixes a regression

Tests / QA Steps

  1. Open the ReportActionContextMenu
  2. Copy a message
  3. Make sure that the arrow becomes green after the message is successfully copied.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

image

Mobile Web

image

Desktop

image

iOS

image

Android

image

@roryabraham roryabraham requested a review from a team April 13, 2021 01:04
@roryabraham roryabraham self-assigned this Apr 13, 2021
@MelvinBot MelvinBot requested review from johnmlee101 and removed request for a team April 13, 2021 01:04
johnmlee101
johnmlee101 approved these changes Apr 13, 2021
View reviewed changes
Copy link
Contributor

@johnmlee101 johnmlee101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice LGTM!

@johnmlee101 johnmlee101 merged commit f8ff884 into master Apr 13, 2021
@johnmlee101 johnmlee101 deleted the Rory-FixSuccessIcon branch April 13, 2021 14:34
@OSBotify OSBotify mentioned this pull request Apr 13, 2021
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnmlee101 johnmlee101 johnmlee101 approved these changes

Assignees

@roryabraham roryabraham

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@roryabraham @johnmlee101