Remove blue border from Ondifo buttons on hover #23699

huzaifa-99 · 2023-07-26T21:56:15Z

Details

Fixed Issues

$ #23278
PROPOSAL: #23278 (comment)

Tests

Go to Workspace -> Add Bank Account
Finish setup till step 3 and click on continue -- you will be taken to the Onfido step
Hover over the passport and driver license buttons -- verify that there is no blue border on hover
Click on any button (passport/driver license) and hover over the 'Get secure link' button -- verify that there is no blue border on hover
Click on the 'Get secure link' button, on the next screen click on 'Get link via SMS' link, there will be a 'Send link' button on the next screen, hover over that button -- verify that there is no blue border on hover

Verify that no errors appear in the JS console

Offline tests

Same as tests above

QA Steps

Same as tests above

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Chrome

Web.Chrome.mp4

Safari

Web.Safari.mp4

Mobile Web - Chrome

mWeb.Chrome.mp4

Mobile Web - Safari

mWeb.Safari.mp4

Desktop

Desktop.mp4

iOS

IOS.Native.mp4

Android

Android.Native.mov

melvin-bot · 2023-07-26T21:56:21Z

@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

huzaifa-99 · 2023-07-27T09:18:49Z

@parasharrajat bump

parasharrajat · 2023-07-27T12:18:27Z

@huzaifa-99 Should we fix this?

Press and drag the cursor out, border is shown.

Screen.Recording.2023-07-27.at.5.47.31.PM.mov

huzaifa-99 · 2023-07-27T12:22:13Z

@parasharrajat we can if required.

The button gets focused when it gets click/press or drag,, so the focus styles get applied. Which is a 3px blue border.

Please lmk what works. Thanks

parasharrajat · 2023-07-27T12:22:29Z

Also, when we do the same on Send Link, it shows a weird blur border.

Screen.Recording.2023-07-27.at.5.49.39.PM.mov

huzaifa-99 · 2023-07-27T12:24:22Z

Also, when we do the same on Send Link, it shows a weird blur border.

Screen.Recording.2023-07-27.at.5.49.39.PM.mov

@parasharrajat same reason as #23699 (comment)

parasharrajat · 2023-07-27T12:55:02Z

Let's make the 3px to 1px to match our styles. Remove the internal white border.

parasharrajat · 2023-07-27T12:56:12Z

Did you try https://github.com/onfido/onfido-sdk-ui/blob/master/UI_CUSTOMIZATION.md

huzaifa-99 · 2023-07-27T12:59:09Z

Did you try https://github.com/onfido/onfido-sdk-ui/blob/master/UI_CUSTOMIZATION.md

Didn't try this, will give it a go and update here.

parasharrajat · 2023-07-27T13:06:04Z

It might require updating the version for Onfido.

huzaifa-99 · 2023-07-27T14:34:58Z

Just got home, it looks like it is actually a box shadow on active state

box-shadow: 0 0 0 2px var(--osdk-color-border-doc-type-button-active)

Screen.Recording.2023-07-27.at.7.30.34.PM.mov

@parasharrajat what do you suggest we do here?

A- Remove it

#onfido-mount button:active { 
    box-shadow:  none 
}

B- Set it to 1px and update color to match focus color

#onfido-mount button:active { 
    box-shadow: 0 0 0 1px var(--osdk-color-border-doc-type-button) 
}

or any other change?

It might require updating the version for Onfido.

We can do that, but I think we would need to test other areas of Onfido and the proper user flow for that. Happy to update if you think its best.

parasharrajat · 2023-07-27T14:50:22Z

Can you try out the variables first and let me know how it goes? There are more on the page I shared, try them. Variables are the proper way if they work.

huzaifa-99 · 2023-07-27T19:46:12Z

I tried that and these are the findings

Hover states can be tweaked with onfido variables (colorBorderDocTypeButtonHover and colorBorderButtonPrimaryHover)
Onfido uses box-shadow for focus, focus-visible and active state, and we cannot tweak these with onfido variables even in the latest version. Some of these state's show inconsistent box-shadow. Also there is some CSS override from the main index.html file
I tested with a random button in the app (outside of onfido flow), and in there we only show blue border for the focus-visible state, both active and focus states don't have any blue border (even tho we apply the focus outline)

If we want all three state (active,focus,focus-visible) to have same blue border, then we can use this css

#onfido-mount button:active,
#onfido-mount button:focus,
#onfido-mount button:focus-visible {
    border-color: transparent !important;  # this is necessary for primary button types to have correct border color
    outline: 0 !important; # this is similar to the one from main HTML file, I added important rule here
    box-shadow: inset 0px 0px 0px 1px #5AB0FF !important; # this is similar to the one from main HTML file, I added important rule here
}

else we can tweak the above CSS to match the one we have in main app

@parasharrajat what are your thoughts?

parasharrajat · 2023-07-27T19:56:42Z

Go ahead. Thanks.

huzaifa-99 · 2023-07-27T19:58:00Z

@parasharrajat just to confirm you mean match the behaviour of onfido buttons with app?

parasharrajat · 2023-07-27T19:59:35Z

It is hard to say until I see those in action.

Hover states can be tweaked with Onfido variables (colorBorderDocTypeButtonHover and colorBorderButtonPrimaryHover)

Use these.

Then apply CSS where variables do not work. Only override the properties that fix both reported bugs. #23699 (comment) #23699 (comment)

huzaifa-99 · 2023-07-27T20:00:13Z

I will update in 30 mins

parasharrajat · 2023-07-27T20:00:36Z

Updated my comment, just so you know....

huzaifa-99 · 2023-07-27T20:01:33Z

ok thank you

huzaifa-99 · 2023-07-27T20:30:19Z

Just a few more minutes

…state

huzaifa-99 · 2023-07-27T20:34:20Z

Updating videos....

huzaifa-99 · 2023-07-27T20:35:13Z

src/components/Onfido/index.css

+
+#onfido-mount .-action--primary:focus,
+#onfido-mount .-action--primary:active {
+ border-color: transparent;


This works without important rule, so i didn't add that

huzaifa-99 · 2023-07-27T21:33:07Z

@parasharrajat I updated test videos and code, now the behaviour is consistent.

huzaifa-99 · 2023-07-28T08:05:27Z

bump @parasharrajat

parasharrajat · 2023-07-28T14:41:02Z

Screenshots

🔲 iOS / native

Screen.Recording.2023-07-28.at.8.26.32.PM.mov

🔲 iOS / Safari

Screen.Recording.2023-07-28.at.8.16.24.PM.mov

🔲 MacOS / Desktop

Screen.Recording.2023-07-28.at.8.15.29.PM.mov

🔲 MacOS / Chrome

Screen.Recording.2023-07-28.at.8.14.38.PM.mov

🔲 Android / Chrome

Screen.Recording.2023-07-28.at.8.27.35.PM.mov

🔲 Android / native

Screen.Recording.2023-07-28.at.8.21.17.PM.mov

parasharrajat

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

🎀 👀 🎀 C+ reviewed

parasharrajat · 2023-07-28T15:26:57Z

That was fast @tgolen

huzaifa-99 · 2023-07-28T15:32:38Z

TYSM guys! 🥳

OSBotify · 2023-07-28T15:34:05Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-07-31T18:58:23Z

🚀 Deployed to staging by https://github.com/tgolen in version: 1.3.48-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-01T23:59:39Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.48-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-02T01:24:09Z

🚀 Deployed to staging by https://github.com/tgolen in version: 1.3.49-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-03T18:16:36Z

🚀 Deployed to production by https://github.com/Beamanator in version: 1.3.49-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Remove blue border from ondifo buttons on hover

438a44f

huzaifa-99 requested a review from a team as a code owner July 26, 2023 21:56

melvin-bot bot requested review from parasharrajat and removed request for a team July 26, 2023 21:56

huzaifa-99 mentioned this pull request Jul 26, 2023

[HOLD for payment 2023-08-08] [$1000] Web - Web – Personal Information– Blue border appears around “Passport” and “License” button. #23278

Closed

6 tasks

Match onfido focus, active and focus-visible states with app buttons …

83dd03f

…state

huzaifa-99 commented Jul 27, 2023

View reviewed changes

Fix onfido buttons focus-visible style on safari

b622779

parasharrajat approved these changes Jul 28, 2023

View reviewed changes

melvin-bot bot requested a review from tgolen July 28, 2023 15:00

tgolen approved these changes Jul 28, 2023

View reviewed changes

tgolen merged commit 1e84793 into Expensify:main Jul 28, 2023
12 checks passed

OSBotify mentioned this pull request Jul 31, 2023

Deploy Checklist: New Expensify 2023-07-31 #23945

Closed

48 tasks

OSBotify mentioned this pull request Aug 1, 2023

Deploy Checklist: New Expensify 2023-08-01 #24028

Closed

79 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove blue border from Ondifo buttons on hover #23699

Remove blue border from Ondifo buttons on hover #23699

huzaifa-99 commented Jul 26, 2023 •

edited

Loading

melvin-bot bot commented Jul 26, 2023

huzaifa-99 commented Jul 27, 2023

parasharrajat commented Jul 27, 2023

huzaifa-99 commented Jul 27, 2023

parasharrajat commented Jul 27, 2023

huzaifa-99 commented Jul 27, 2023

parasharrajat commented Jul 27, 2023 •

edited

Loading

parasharrajat commented Jul 27, 2023

huzaifa-99 commented Jul 27, 2023

parasharrajat commented Jul 27, 2023

huzaifa-99 commented Jul 27, 2023 •

edited

Loading

parasharrajat commented Jul 27, 2023

huzaifa-99 commented Jul 27, 2023

parasharrajat commented Jul 27, 2023

huzaifa-99 commented Jul 27, 2023

parasharrajat commented Jul 27, 2023 •

edited

Loading

huzaifa-99 commented Jul 27, 2023

parasharrajat commented Jul 27, 2023

huzaifa-99 commented Jul 27, 2023

huzaifa-99 commented Jul 27, 2023

huzaifa-99 commented Jul 27, 2023

huzaifa-99 Jul 27, 2023

huzaifa-99 commented Jul 27, 2023

huzaifa-99 commented Jul 28, 2023

parasharrajat commented Jul 28, 2023 •

edited

Loading

parasharrajat left a comment

parasharrajat commented Jul 28, 2023

huzaifa-99 commented Jul 28, 2023

OSBotify commented Jul 28, 2023

OSBotify commented Jul 31, 2023

OSBotify commented Aug 1, 2023

OSBotify commented Aug 2, 2023

OSBotify commented Aug 3, 2023

Remove blue border from Ondifo buttons on hover #23699

Remove blue border from Ondifo buttons on hover #23699

Conversation

huzaifa-99 commented Jul 26, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jul 26, 2023

huzaifa-99 commented Jul 27, 2023

parasharrajat commented Jul 27, 2023

huzaifa-99 commented Jul 27, 2023

parasharrajat commented Jul 27, 2023

huzaifa-99 commented Jul 27, 2023

parasharrajat commented Jul 27, 2023 • edited Loading

parasharrajat commented Jul 27, 2023

huzaifa-99 commented Jul 27, 2023

parasharrajat commented Jul 27, 2023

huzaifa-99 commented Jul 27, 2023 • edited Loading

parasharrajat commented Jul 27, 2023

huzaifa-99 commented Jul 27, 2023

parasharrajat commented Jul 27, 2023

huzaifa-99 commented Jul 27, 2023

parasharrajat commented Jul 27, 2023 • edited Loading

huzaifa-99 commented Jul 27, 2023

parasharrajat commented Jul 27, 2023

huzaifa-99 commented Jul 27, 2023

huzaifa-99 commented Jul 27, 2023

huzaifa-99 commented Jul 27, 2023

huzaifa-99 Jul 27, 2023

Choose a reason for hiding this comment

huzaifa-99 commented Jul 27, 2023

huzaifa-99 commented Jul 28, 2023

parasharrajat commented Jul 28, 2023 • edited Loading

Screenshots

🔲 iOS / native

🔲 iOS / Safari

🔲 MacOS / Desktop

🔲 MacOS / Chrome

🔲 Android / Chrome

🔲 Android / native

parasharrajat left a comment

Choose a reason for hiding this comment

Reviewer Checklist

parasharrajat commented Jul 28, 2023

huzaifa-99 commented Jul 28, 2023

OSBotify commented Jul 28, 2023

OSBotify commented Jul 31, 2023

OSBotify commented Aug 1, 2023

OSBotify commented Aug 2, 2023

OSBotify commented Aug 3, 2023

huzaifa-99 commented Jul 26, 2023 •

edited

Loading

parasharrajat commented Jul 27, 2023 •

edited

Loading

huzaifa-99 commented Jul 27, 2023 •

edited

Loading

parasharrajat commented Jul 27, 2023 •

edited

Loading

parasharrajat commented Jul 28, 2023 •

edited

Loading