Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ReportActionCompose.js #23714

Closed
wants to merge 1 commit into from
Closed

Update ReportActionCompose.js #23714

wants to merge 1 commit into from

Conversation

saalimzafar
Copy link

@saalimzafar saalimzafar commented Jul 27, 2023

Condition to check if space bar is pressed

@saalimzafar saalimzafar requested a review from a team as a code owner July 27, 2023 09:48
@github-actions
Copy link
Contributor

CLA Assistant Lite bot:
Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request

@melvin-bot melvin-bot bot requested review from amyevans and removed request for a team July 27, 2023 09:49
@melvin-bot
Copy link

melvin-bot bot commented Jul 27, 2023

@amyevans Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@amyevans
Copy link
Contributor

Hey @saalimzafar this PR doesn't look like it's associated with any bug/proposal, so I'm going to close it. Check out our contributing guidelines for more information on our processes if you'd like to get involved in the project.

@amyevans amyevans closed this Jul 27, 2023
@saalimzafar
Copy link
Author

Thanks @amyevans for you response. I thought it will resolve this issue "Pressing space key applies focus to composer & scrolls comments at the same time".
I decided to do the shortcut way as downloading all the packages is not feasible for me locally so if anyone from your team wants to check if it will work they can do it easily. If it didn't resolve the issue it's okay will try next time.

@amyevans
Copy link
Contributor

Ah I see okay, you should get some feedback on the proposal in #23508 (sometimes it can take a few days) and if your proposal is selected this PR can be reopened. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants