Fix: App crashes after pressing Backspace/Delete key in Incorrect magic code page #23734

Pujan92 · 2023-07-27T14:26:12Z

Details

Instead of updating the indexes(focused) in onPress we used it in the onFocus to prevent inconsistency in the focused textInput and focused index.

Fixed Issues

$ #23596
PROPOSAL: #23596 (comment)

Tests

On login page(for web/desktop), enter an email/phone number and click Continue
Enter an incorrect magic code
Once an error shows, press and hold the left click of a mouse in any of the input box and drag outside of it and release
Press Backspace/Delete key on the keyboard
Verify that app is not crashing and removes the code from that focused input box

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

On login page(for web/desktop), enter an email/phone number and click Continue
Enter an incorrect magic code
Once an error shows, press and hold the left click of a mouse in any of the input box and drag outside of it and release
Press Backspace/Delete key on the keyboard
Verify that app is not crashing and removes the code from that focused input box

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

Screen.Recording.2023-07-27.at.7.29.14.PM.mp4

Mobile Web - Chrome

anchrome.mp4

Mobile Web - Safari

Simulator.Screen.Recording.-.iPhone.14.-.2023-07-27.at.19.51.34.mp4

Desktop

Screen.Recording.2023-07-27.at.7.48.12.PM.mp4

iOS

Simulator.Screen.Recording.-.iPhone.14.-.2023-07-27.at.19.50.04.mp4

Android

android.mp4

melvin-bot · 2023-07-27T14:26:17Z

@s77rt Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

s77rt · 2023-07-27T18:25:07Z

src/components/MagicCodeInput.js

-        setFocusedIndex(updatedFocusedIndex);
-        setInput(value);
+        inputRefs.current[updatedFocusedIndex].focus();


We used to set the input to value but with this change we won't, the focus method will set the input to an empty string. This does not seem right. Can you please fix this

I intentionally take out the value bcoz I think we need to reset it once the value has been given for the input box. Its impact can be seen in the last input box where the focusedIndex isn't changing if the full code isn't Fulfilled.

Screen.Recording.2023-07-28.at.12.27.09.AM.mp4

s77rt · 2023-07-27T22:10:12Z

src/components/MagicCodeInput.js

@@ -120,9 +119,6 @@ function MagicCodeInput(props) {
            focusMagicCodeInput();


This will set the input to an empty string. I think we can remove the resetFocus method now as it's same as focus

resetFocus is added here for this issue. Are you suggesting that we can use focus method there instead of resetFocus and remove resetFocus here?

I think I agree that we don't need an extra method now, I just committed the changes.

s77rt · 2023-07-28T16:18:25Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mp4

Mobile Web - Chrome

mweb-chrome.mp4

Mobile Web - Safari

mweb-safari.mp4

Desktop

desktop.mp4

iOS

ios.mp4

Android

android.mp4

s77rt

LGTM! 🚀

OSBotify · 2023-07-28T17:41:58Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-07-31T18:58:08Z

🚀 Deployed to staging by https://github.com/hayata-suenaga in version: 1.3.48-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-01T23:59:24Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.48-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-02T01:23:54Z

🚀 Deployed to staging by https://github.com/hayata-suenaga in version: 1.3.49-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-03T18:16:21Z

🚀 Deployed to production by https://github.com/Beamanator in version: 1.3.49-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

used onFocus instead of onPress for MagicInput

5033e49

Pujan92 requested a review from a team as a code owner July 27, 2023 14:26

melvin-bot bot removed the request for review from a team July 27, 2023 14:26

melvin-bot bot requested a review from s77rt July 27, 2023 14:26

Pujan92 mentioned this pull request Jul 27, 2023

[HOLD for payment 2023-08-08] [$1000] Web - App crashes after pressing Backspace/Delete key in Incorrect magic code page #23596

Closed

6 tasks

Pujan92 added 2 commits July 27, 2023 22:42

focus input on change text

e32c93f

removed not required setFocusedIndex call

e7b3e97

s77rt suggested changes Jul 27, 2023

View reviewed changes

minor adjustments to MagicCodeInput

5488702

s77rt approved these changes Jul 28, 2023

View reviewed changes

melvin-bot bot requested a review from hayata-suenaga July 28, 2023 16:19

hayata-suenaga approved these changes Jul 28, 2023

View reviewed changes

hayata-suenaga merged commit 7e5dfb8 into Expensify:main Jul 28, 2023

OSBotify mentioned this pull request Jul 31, 2023

Deploy Checklist: New Expensify 2023-07-31 #23945

Closed

48 tasks

OSBotify mentioned this pull request Aug 1, 2023

Deploy Checklist: New Expensify 2023-08-01 #24028

Closed

79 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix: App crashes after pressing Backspace/Delete key in Incorrect magic code page #23734

Fix: App crashes after pressing Backspace/Delete key in Incorrect magic code page #23734

Pujan92 commented Jul 27, 2023

melvin-bot bot commented Jul 27, 2023

s77rt Jul 27, 2023

Pujan92 Jul 27, 2023 •

edited

Loading

s77rt Jul 27, 2023

Pujan92 Jul 28, 2023

Pujan92 Jul 28, 2023

s77rt commented Jul 28, 2023

s77rt left a comment

OSBotify commented Jul 28, 2023

OSBotify commented Jul 31, 2023

OSBotify commented Aug 1, 2023

OSBotify commented Aug 2, 2023

OSBotify commented Aug 3, 2023

		@@ -120,9 +119,6 @@ function MagicCodeInput(props) {
		focusMagicCodeInput();

Fix: App crashes after pressing Backspace/Delete key in Incorrect magic code page #23734

Fix: App crashes after pressing Backspace/Delete key in Incorrect magic code page #23734

Conversation

Pujan92 commented Jul 27, 2023

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jul 27, 2023

s77rt Jul 27, 2023

Choose a reason for hiding this comment

Pujan92 Jul 27, 2023 • edited Loading

Choose a reason for hiding this comment

s77rt Jul 27, 2023

Choose a reason for hiding this comment

Pujan92 Jul 28, 2023

Choose a reason for hiding this comment

Pujan92 Jul 28, 2023

Choose a reason for hiding this comment

s77rt commented Jul 28, 2023

Reviewer Checklist

Screenshots/Videos

s77rt left a comment

Choose a reason for hiding this comment

OSBotify commented Jul 28, 2023

OSBotify commented Jul 31, 2023

OSBotify commented Aug 1, 2023

OSBotify commented Aug 2, 2023

OSBotify commented Aug 3, 2023

Pujan92 Jul 27, 2023 •

edited

Loading