Fix/21456 - Polish admins-only policy room - Pass arguments properly #23815

rezkiy37 · 2023-07-28T18:13:31Z

Details

This is a regression fix of #21950. A new value was added to buildOptimisticChatReport and it was missed to pass this argument in a few places.
I fixed arguments where other values were passed as writeCapability. Also, decided to use undefined as a default value in buildOptimisticChatReport, because this function generates objects for many other instances, not only a room. I pass writeCapability explicitly.

Fixed Issues

$ #21456, #23638, #23646
PROPOSAL: N/A

Tests

Creating a workspace

Click on your user avatar icon (settings).
Click on "Workspaces".
Open the console.
Click on "New workspace".
Verify that no console errors.

Viewing a chat reply

Open any chat.
Send a message.
Enable the offline mode.
Hover over the sent message and click on "Reply in thread" icon.
Verify that the thread header display the threaded message and "from" link, Composer should be visible.

Viewing a money request

Open any chat.
Click on "+" (actions) to the left of Composer.
Click on "Request money".
Enter any values.
Click on "Request".
Click on "Replies".
Open the console.
Click on the latest money request.
Verify that no console errors.

Creating a room when are an admin

Click on "+" (FAB menu).
Click on "New room".
Select a workspace, where you are an admin.
Verify that a new selector appears - "Who can post" with 2 values: "All members" and "Amins only".
Select any value for the new selector. Fill in the other selectors/inputs as you want (up to you).
Click on "Create room".
The app should redirect you to a new room chat page.
Open the chat settings.
Verify that it has the same values that you entered before.
Repeat one more time, but select the other value for the new selector.

Creating a room when are a member

Click on "+" (FAB menu).
Click on "New room".
Select a workspace, where you are a member.
Verify that there isn't "Who can post" selector.
Fill in the other selectors/inputs as you want (up to you).
Click on "Create room".
The app should redirect you to a new room chat page.
Open the chat settings
Verify that "Who can post" selector is "All members" and other inputs have the same values that you entered before.

Verify that no errors appear in the JS console

Offline tests

Same as Tests

QA Steps

Same as Tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

create.workspace.mov

Reply.mp4

Request.money.mp4

New.room.admins.mp4

New.room.all.mp4

New.room.default.mp4

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

melvin-bot · 2023-07-28T18:20:12Z

@shawnborton @mananjadhav One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

amyevans

LGTM!

amyevans · 2023-07-28T19:15:15Z

@mananjadhav all yours!

mananjadhav · 2023-07-29T18:43:15Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web-policy-admin-regression.mov

Mobile Web - Chrome

mweb-chrome-policy-admin-regression.mov

Mobile Web - Safari

mweb-safari-policy-admin-regression.mov

Desktop

desktop-policy-admin-regression.mov

iOS

ios-policy-admin-regression_i6BMlfl6.mp4

Android

android-policy-admin-regression_s5D1oFuE.mp4

Thanks for the fixes @rezkiy37. I've also tested this in the current PR, @kavimuru.

@amyevans 🎀 👀 🎀 C+ Reviewed.

OSBotify · 2023-07-31T03:30:53Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-07-31T18:57:38Z

🚀 Deployed to staging by https://github.com/amyevans in version: 1.3.48-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Christinadobrzyn · 2023-07-31T21:45:20Z

Hi! Can we confirm if this issue and #23821 will be fixed with this PR?

rezkiy37 · 2023-08-01T11:17:49Z

Hi! Can we confirm if this issue and #23821 will be fixed with this PR?

@Christinadobrzyn, yes, we can confirm. This PR fixes both issues. There was a PR, which introduced these bugs - #21950. We already merge this PR, which fixes it.
I tested on a commit (eb02006) directly before this PR merge into main, in this case both bugs exist. Once I switch to the fix commit (024d210), no bugs anymore.

Example for #23847

Fix.23847.mp4

Example for #23821

Fix.23821.mp4

OSBotify · 2023-08-01T23:58:54Z

🚀 Deployed to production by https://github.com/puneetlath in version: 1.3.48-5 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-02T01:23:24Z

🚀 Deployed to staging by https://github.com/amyevans in version: 1.3.49-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-03T18:15:51Z

🚀 Deployed to production by https://github.com/Beamanator in version: 1.3.49-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Christinadobrzyn · 2023-08-03T23:25:50Z

Side note paying @situchan as a reporter of this regression per the discussion here #23847 (comment)

rezkiy37 added 2 commits July 28, 2023 17:40

pass write capability

d5f231d

pass writeCapability explicitly

cdd844b

rezkiy37 marked this pull request as ready for review July 28, 2023 18:20

rezkiy37 requested a review from a team as a code owner July 28, 2023 18:20

melvin-bot bot requested review from mananjadhav and shawnborton and removed request for a team July 28, 2023 18:20

rezkiy37 mentioned this pull request Jul 28, 2023

[HOLD for payment 2023-08-14] [HOLD for payment 2023-08-08] [HOLD for payment 2023-08-03] [$1000] Polish admins-only policy room feature #21456

Closed

4 tasks

amyevans requested review from amyevans and removed request for shawnborton July 28, 2023 18:51

amyevans approved these changes Jul 28, 2023

View reviewed changes

bernhardoj mentioned this pull request Jul 29, 2023

[$1000] Web - Optimistic expense request page is broken #23847

Closed

6 tasks

mananjadhav approved these changes Jul 29, 2023

View reviewed changes

melvin-bot bot requested a review from amyevans July 29, 2023 18:44

amyevans approved these changes Jul 31, 2023

View reviewed changes

amyevans merged commit 024d210 into Expensify:main Jul 31, 2023
12 of 14 checks passed

rezkiy37 mentioned this pull request Jul 31, 2023

[$1000] [HOLD for payment 2023-08-08] Dev: Web - Console error on create new workspace #23638

Closed

6 tasks

OSBotify mentioned this pull request Jul 31, 2023

Deploy Checklist: New Expensify 2023-07-31 #23945

Closed

48 tasks

Christinadobrzyn mentioned this pull request Jul 31, 2023

Web - Expense request avatar is broken in LHN #23821

Closed

6 tasks

OSBotify mentioned this pull request Aug 1, 2023

Deploy Checklist: New Expensify 2023-08-01 #24028

Closed

79 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix/21456 - Polish admins-only policy room - Pass arguments properly #23815

Fix/21456 - Polish admins-only policy room - Pass arguments properly #23815

rezkiy37 commented Jul 28, 2023 •

edited

Loading

melvin-bot bot commented Jul 28, 2023

amyevans left a comment

amyevans commented Jul 28, 2023

mananjadhav commented Jul 29, 2023 •

edited

Loading

OSBotify commented Jul 31, 2023

OSBotify commented Jul 31, 2023

Christinadobrzyn commented Jul 31, 2023

rezkiy37 commented Aug 1, 2023

OSBotify commented Aug 1, 2023

OSBotify commented Aug 2, 2023

OSBotify commented Aug 3, 2023

Christinadobrzyn commented Aug 3, 2023

Fix/21456 - Polish admins-only policy room - Pass arguments properly #23815

Fix/21456 - Polish admins-only policy room - Pass arguments properly #23815

Conversation

rezkiy37 commented Jul 28, 2023 • edited Loading

Details

Fixed Issues

Tests

Creating a workspace

Viewing a chat reply

Viewing a money request

Creating a room when are an admin

Creating a room when are a member

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Jul 28, 2023

amyevans left a comment

Choose a reason for hiding this comment

amyevans commented Jul 28, 2023

mananjadhav commented Jul 29, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

OSBotify commented Jul 31, 2023

OSBotify commented Jul 31, 2023

Christinadobrzyn commented Jul 31, 2023

rezkiy37 commented Aug 1, 2023

OSBotify commented Aug 1, 2023

OSBotify commented Aug 2, 2023

OSBotify commented Aug 3, 2023

Christinadobrzyn commented Aug 3, 2023

rezkiy37 commented Jul 28, 2023 •

edited

Loading

mananjadhav commented Jul 29, 2023 •

edited

Loading