Fix: 23735 Web - App displays single report in LHN for some time on login with that report link #24204

tienifr · 2023-08-07T10:11:58Z

Details

Fixed Issues

$ #23735
PROPOSAL: #23735 (comment)

Tests

Open the app
Open any report and pin it
Copy the URL
Logout and paste the URL and press enter
Login and observe that app displays report open in step 2 for some time before displaying all the results
Verify that the loaded report and skeletons are shown in LHN until the total reports are loaded

Verify that no errors appear in the JS console

Offline tests

QA Steps

Open the app
Open any report and pin it
Copy the URL
Logout and paste the URL and press enter
Login and observe that app displays report open in step 2 for some time before displaying all the results
Verify that the loaded report and skeletons are shown in LHN until the total reports are loaded

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-08-07.at.16.25.35.mp4

Mobile Web - Chrome

original-C8804E1F-EC9D-41EE-B4F6-A747FE8A6654.1.mp4

Mobile Web - Safari

original-800C73EF-9325-4C28-B11A-B08F07136CF6.mp4

Desktop

Screen.Recording.2023-08-07.at.16.38.45.mp4

iOS

Screen.Recording.2023-08-07.at.17.07.32.mov

Android

logout-compressed.mov

…ith that report link

melvin-bot · 2023-08-09T02:34:36Z

@ArekChr Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

ArekChr · 2023-08-09T08:17:12Z

src/pages/home/sidebar/SidebarLinks.js

@@ -59,6 +62,12 @@ const propTypes = {

    priorityMode: PropTypes.oneOf(_.values(CONST.PRIORITY_MODE)),

+    currentReportID: PropTypes.string,


Missing a code comment explaining that prop.

ArekChr · 2023-08-09T08:17:21Z

src/pages/home/sidebar/SidebarLinks.js

@@ -59,6 +62,12 @@ const propTypes = {

    priorityMode: PropTypes.oneOf(_.values(CONST.PRIORITY_MODE)),

+    currentReportID: PropTypes.string,
+
+    report: PropTypes.shape({


ArekChr · 2023-08-09T12:31:33Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files xare named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

mweb.chrome.mov

Mobile Web - Safari

mweb.safari.mov

Desktop

desktop.mov

iOS

ios.mov

Android

android.mov

ArekChr · 2023-08-09T12:38:53Z

src/pages/home/sidebar/SidebarLinks.js

@@ -213,14 +229,24 @@ class SidebarLinks extends React.PureComponent {
                    </PressableWithoutFeedback>
                </View>
                {this.props.isLoading ? (
-                    <OptionsListSkeletonView shouldAnimate />
+                    <>
+                        {this.props.report.reportID && (


Use lodashGet for reportID

ArekChr

Left small comment, overall LGTM!

tienifr · 2023-08-09T16:40:01Z

@ArekChr Thanks for your review. I just updated the PR to use lodashGet

ArekChr

LGTM!

OSBotify · 2023-08-11T23:28:29Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-08-14T20:03:58Z

🚀 Deployed to staging by https://github.com/aldo-expensify in version: 1.3.54-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-08-14T21:04:14Z

🚀 Deployed to staging by https://github.com/aldo-expensify in version: 1.3.54-0 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-08-17T02:54:50Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 1.3.54-13 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

marcaaron · 2023-08-17T20:26:36Z

This PR caused a regression for ~~native~~ all the platforms...

To reproduce:

Sign in
Background the app
Bring the app back to foreground
Sidebar will show a loading state while reports load

marcaaron · 2023-08-17T20:47:35Z

I think it's this Issue => #24573

mountiny · 2023-08-17T20:48:58Z

@tienifr could you address the regression as PR author please? cc @ArekChr

sobitneupane · 2024-01-03T07:45:46Z

This case was not handled in this PR.

Issue: Login - LHN does not show skeleton placeholder when the page is refreshed while loading

Steps to reproduce:

Go to staging.new.expensify.com
Log in to HT account.
While the page is loading after login, refresh the page.
LHN does not show skeleton placeholder when the page is refreshed while it is still loading.

tienifr added 2 commits August 7, 2023 14:08

fix: 23735

1288112

fix: 23735 App displays single report in LHN for some time on login w…

dfe8cf1

…ith that report link

tienifr changed the title ~~Fix/23735~~ Fix: 23735 Web - App displays single report in LHN for some time on login with that report link Aug 7, 2023

fix: test

43c8ddc

tienifr marked this pull request as ready for review August 9, 2023 02:34

tienifr requested a review from a team as a code owner August 9, 2023 02:34

melvin-bot bot requested review from ArekChr and removed request for a team August 9, 2023 02:34

tienifr mentioned this pull request Aug 9, 2023

[HOLD for payment 2023-09-06] [$1000] Web - App displays single report in LHN for some time on login with that report link #23735

Closed

6 tasks

ArekChr reviewed Aug 9, 2023

View reviewed changes

fix: add comment explaining for props

2dbad8f

ArekChr reviewed Aug 9, 2023

View reviewed changes

fix: use lodash get

2358228

ArekChr approved these changes Aug 10, 2023

View reviewed changes

melvin-bot bot requested a review from aldo-expensify August 10, 2023 07:06

aldo-expensify approved these changes Aug 11, 2023

View reviewed changes

aldo-expensify merged commit ed2c287 into Expensify:main Aug 11, 2023

thiagobrez mentioned this pull request Aug 14, 2023

refactor: SelectionList multiple selection #22622

Merged

62 tasks

tienifr mentioned this pull request Aug 14, 2023

Fix: Composer does not refocus when click the same chat #24360

Merged

57 tasks

OSBotify mentioned this pull request Aug 14, 2023

Deploy Checklist: New Expensify 2023-08-14 #24550

Closed

49 tasks

lanitochka17 mentioned this pull request Aug 15, 2023

[HOLD for payment 2023-09-07] [$1000] Chat - Opened chat does not show up in LHN when LHN is loading #24596

Closed

6 tasks

marcaaron mentioned this pull request Aug 17, 2023

Chat - Chat disappears & shows skeleton when going offline (web) or backgrounding the app (native) #24573

Closed

6 tasks

paultsimura mentioned this pull request Nov 15, 2023

[HOLD for payment 2023-12-18] [$500] Login - LHN does not show skeleton placeholder when the page is refreshed while loading #31366

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix: 23735 Web - App displays single report in LHN for some time on login with that report link #24204

Fix: 23735 Web - App displays single report in LHN for some time on login with that report link #24204

tienifr commented Aug 7, 2023 •

edited

Loading

melvin-bot bot commented Aug 9, 2023

ArekChr Aug 9, 2023

ArekChr Aug 9, 2023

ArekChr commented Aug 9, 2023 •

edited

Loading

ArekChr Aug 9, 2023

ArekChr left a comment

tienifr commented Aug 9, 2023

ArekChr left a comment

OSBotify commented Aug 11, 2023

OSBotify commented Aug 14, 2023

OSBotify commented Aug 14, 2023

OSBotify commented Aug 17, 2023

marcaaron commented Aug 17, 2023 •

edited

Loading

marcaaron commented Aug 17, 2023

mountiny commented Aug 17, 2023

sobitneupane commented Jan 3, 2024

		@@ -59,6 +62,12 @@ const propTypes = {

		priorityMode: PropTypes.oneOf(_.values(CONST.PRIORITY_MODE)),

		currentReportID: PropTypes.string,

Fix: 23735 Web - App displays single report in LHN for some time on login with that report link #24204

Fix: 23735 Web - App displays single report in LHN for some time on login with that report link #24204

Conversation

tienifr commented Aug 7, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Aug 9, 2023

ArekChr Aug 9, 2023

Choose a reason for hiding this comment

ArekChr Aug 9, 2023

Choose a reason for hiding this comment

ArekChr commented Aug 9, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

ArekChr Aug 9, 2023

Choose a reason for hiding this comment

ArekChr left a comment

Choose a reason for hiding this comment

tienifr commented Aug 9, 2023

ArekChr left a comment

Choose a reason for hiding this comment

OSBotify commented Aug 11, 2023

OSBotify commented Aug 14, 2023

OSBotify commented Aug 14, 2023

OSBotify commented Aug 17, 2023

marcaaron commented Aug 17, 2023 • edited Loading

marcaaron commented Aug 17, 2023

mountiny commented Aug 17, 2023

sobitneupane commented Jan 3, 2024

tienifr commented Aug 7, 2023 •

edited

Loading

ArekChr commented Aug 9, 2023 •

edited

Loading

marcaaron commented Aug 17, 2023 •

edited

Loading