Code

Implement report approvals#24639

Code

Merged

luacmartins merged 53 commits intomainExpensify/App:mainfrom youssef_approve_money_requestExpensify/App:youssef_approve_money_requestCopy head branch name to clipboardAug 28, 2023

+344-127

Commits

Commits on Aug 7, 2023

• Add approveMoneyRequest action

  youssef-lr

  committed
  e1c0319

  Copy full SHA for e1c0319

• Add logic for showing the approve/settlement button

  youssef-lr

  committed
  b1e77ab

  Copy full SHA for b1e77ab

Commits on Aug 10, 2023

• Merge branch 'main' into youssef_approve_money_request

  youssef-lr

  committed
  386d9f9

  Copy full SHA for 386d9f9

Commits on Aug 12, 2023

• Add helper methods

  youssef-lr

  committed
  fa1bb92

  Copy full SHA for fa1bb92

• Allow APPROVED action to be displayed

  youssef-lr

  committed
  691ceba

  Copy full SHA for 691ceba

• Fix optimistic data for approved action

  youssef-lr

  committed
  e0da0f3

  Copy full SHA for e0da0f3

• Add missing imports and code tidying up

  youssef-lr

  committed
  f7b422e

  Copy full SHA for f7b422e

• Display APPROVED action text in subtle color

  youssef-lr

  committed
  9a8bef8

  Copy full SHA for 9a8bef8

Commits on Aug 13, 2023

• Display approved reports as approved and not paid

  youssef-lr

  committed
  2d50862

  Copy full SHA for 2d50862

Commits on Aug 16, 2023

• Fix lastMessageText showing duplicate actor name

  youssef-lr

  committed
  e8543c8

  Copy full SHA for e8543c8

• Merge branch 'main' into youssef_approve_money_request

  youssef-lr

  committed
  00fb139

  Copy full SHA for 00fb139

• Code improvement

  youssef-lr

  committed
  1140036

  Copy full SHA for 1140036

• Create new IOU report if the current report is approved

  youssef-lr

  committed
  266cd4c

  Copy full SHA for 266cd4c

• Display translated IOU/Report previews

  youssef-lr

  committed
  5de9792

  Copy full SHA for 5de9792

• Fix bug showing approve button when report is settled

  youssef-lr

  committed
  75e9ed4

  Copy full SHA for 75e9ed4

• Display green dot properly

  youssef-lr

  committed
  508021d

  Copy full SHA for 508021d

• Cleanup

  youssef-lr

  committed
  ecd428a

  Copy full SHA for ecd428a

Commits on Aug 17, 2023

• Clean up

  youssef-lr

  committed
  18c5198

  Copy full SHA for 18c5198

• Merge branch 'main' into youssef_approve_money_request

  youssef-lr

  committed
  4e2a5c1

  Copy full SHA for 4e2a5c1

Commits on Aug 18, 2023

• Use getIOUReportActionMessage to format APPROVED action message

  youssef-lr

  committed
  da32226

  Copy full SHA for da32226

• Add spanish translations

  youssef-lr

  committed
  d75e3f8

  Copy full SHA for d75e3f8

• Code tidying up

  youssef-lr

  committed
  3930802

  Copy full SHA for 3930802

• Fix IOU report being created instead of Expense report

  youssef-lr

  committed
  c7d51cf

  Copy full SHA for c7d51cf

• Code tidying up

  youssef-lr

  committed
  d160aed

  Copy full SHA for d160aed

• Fix bug

  youssef-lr

  committed
  07682c5

  Copy full SHA for 07682c5

• Merge branch 'main' into youssef_approve_money_request

  youssef-lr

  committed
  74b8caf

  Copy full SHA for 74b8caf

• Bug fix

  youssef-lr

  committed
  3b570e2

  Copy full SHA for 3b570e2

Commits on Aug 19, 2023

• Fix code action

  youssef-lr

  committed
  273966c

  Copy full SHA for 273966c

• Fix code actions

  youssef-lr

  committed
  100f03d

  Copy full SHA for 100f03d

• Merge branch 'main' into youssef_approve_money_request

  youssef-lr

  committed
  03cc982

  Copy full SHA for 03cc982

• Linting

  youssef-lr

  committed
  909cd45

  Copy full SHA for 909cd45

Commits on Aug 20, 2023

• Style and translation

  youssef-lr

  committed
  3462084

  Copy full SHA for 3462084

• Add back code removed by mistake

  youssef-lr

  committed
  fca135f

  Copy full SHA for fca135f

• Fix test

  youssef-lr

  committed
  f7382f3

  Copy full SHA for f7382f3

Commits on Aug 21, 2023

• Style fix

  youssef-lr

  committed
  2d3bf23

  Copy full SHA for 2d3bf23

Commits on Aug 22, 2023

• Remove no longer needed helper func

  youssef-lr

  committed
  c134640

  Copy full SHA for c134640

• Merge branch 'main' into youssef_approve_money_request

  youssef-lr

  committed
  216618b

  Copy full SHA for 216618b

• Show Pay button in report preview for admins when report is approved

  youssef-lr

  committed
  21d5783

  Copy full SHA for 21d5783

Commits on Aug 23, 2023

• Merge branch 'main' into youssef_approve_money_request

  youssef-lr

  committed
  10a287a

  Copy full SHA for 10a287a

• Clean up

  youssef-lr

  committed
  03e9513

  Copy full SHA for 03e9513

• Apply suggestions from code review

  Show description for ceff45b
  

  youssef-lr

  and

  luacmartins

  authored
  ceff45b

  Copy full SHA for ceff45b

• Address PR comments

  youssef-lr

  committed
  2e373a8

  Copy full SHA for 2e373a8

Commits on Aug 24, 2023

• Address comments

  youssef-lr

  committed
  95dc9e2

  Copy full SHA for 95dc9e2

• Only display "Pay" button for the admin in the report preview

  youssef-lr

  committed
  15ab698

  Copy full SHA for 15ab698

• Optimise how policy is passed to money request componenets

  youssef-lr

  committed
  e7c4804

  Copy full SHA for e7c4804

Commits on Aug 25, 2023

• Merge branch 'main' into youssef_approve_money_request

  youssef-lr

  committed
  c89f0a6

  Copy full SHA for c89f0a6

Commits on Aug 26, 2023

• Bug fix

  youssef-lr

  committed
  66b6724

  Copy full SHA for 66b6724

• Another bug fix

  youssef-lr

  committed
  4833ce4

  Copy full SHA for 4833ce4

Commits on Aug 28, 2023

• Merge branch 'main' into youssef_approve_money_request

  youssef-lr

  committed
  7dc3738

  Copy full SHA for 7dc3738

• Merge branch 'main' into youssef_approve_money_request

  youssef-lr

  authored
  1b176a9

  Copy full SHA for 1b176a9

• Apply suggestions from code review

  Show description for 575524c
  

  3 peopleauthored
  575524c

  Copy full SHA for 575524c

• Address PR comments

  youssef-lr

  committed
  b341aa1

  Copy full SHA for b341aa1

• Fix lint and approve button style

  youssef-lr

  committed
  577d9ad

  Copy full SHA for 577d9ad