Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Category list helpers #25777
Category list helpers #25777
Changes from all commits
a35200e
4540bf5
22c7397
1b9429e
cb03605
2b22f9c
87f69e8
36fff23
895e9d5
1bc269e
e283151
8307678
846e9b3
f7ff0c6
91d3dde
f7d6e5f
657850f
d0376ec
cc85e52
d9d3e6c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Coming from #29281
This operator didn't order the sub-categories correctly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rezkiy37 I wonder why do we need to check
isChild
here? Can you help explain when you have a chance? ThanksThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, as you can see above there is a definition for
isChild
-= array.length - 1 === index
. So for example there is an optionparent:child
. It automatically setsisDisabled
astrue
forparent
. However, it checksoption.enabled
forchild
. Because onlychild
is an option that can be disabled or enabled.parent
is an option that can be disabled with this example. To enableparent
the app should have a specificparent
option.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TY for your explanation. That makes sense!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(BugZero Checklist) Coming from #42936, We ended up modifying the
isDisabled
condion to have hover effect over selected parent category in the list