Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CP Staging] Stop showing receipt images for cash requests #25800

Merged
merged 5 commits into from
Aug 23, 2023
Merged

[CP Staging] Stop showing receipt images for cash requests #25800

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
941afad
Provide safer access for filename param if it happens to be missing
marcaaron Aug 23, 2023
27cdd58
Show generic receipt image when there is no receipt
marcaaron Aug 23, 2023
5486831
Only show receipt images for receipts that have receiptID
marcaaron Aug 23, 2023
12890a9
All receipts will have a source property so we will use this to tell …
marcaaron Aug 23, 2023
a5c4dea
use state
marcaaron Aug 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/libs/TransactionUtils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ function buildOptimisticTransaction(
* @returns {Boolean}
*/
function hasReceipt(transaction) {
return !_.isEmpty(lodashGet(transaction, 'receipt'));
return Boolean(lodashGet(transaction, 'receipt.receiptID'));
Copy link
Contributor

@luacmartins luacmartins Aug 23, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't create receiptID optimistically, so this change would prevent images from showing before we get a receiptID back from the client

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you respond to me here -> https://expensify.slack.com/archives/C057F53HR40/p1692826510517379?thread_ts=1692826029.393829&cid=C057F53HR40

}

/**
Expand Down
Loading