-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use correct title key for waypoint editor #25808
Conversation
@thesahindia Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Reviewer Checklist
Screenshots/VideosWebScreen.Recording.2023-08-25.at.8.48.45.PM.movMobile Web - ChromeScreen.Recording.2023-08-25.at.8.50.52.PM.movMobile Web - SafariScreen.Recording.2023-08-25.at.9.03.29.PM.movDesktopScreen.Recording.2023-08-25.at.8.58.22.PM.moviOSScreen.Recording.2023-08-25.at.9.01.09.PM.movAndroidScreen.Recording.2023-08-25.at.8.49.23.PM.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
We did not find an internal engineer to review this PR, trying to assign a random engineer to #25730 as well as to this PR... Please reach out for help on Slack if no one gets assigned! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@allroundexperts looking great! One little clean up item and some merge conflicts and then it's good to go.
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/neil-marcellini in version: 1.3.59-0 🚀
|
🚀 Deployed to staging by https://github.com/neil-marcellini in version: 1.3.60-0 🚀
|
🚀 Deployed to staging by https://github.com/neil-marcellini in version: 1.3.60-0 🚀
|
🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.59-5 🚀
|
🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.60-3 🚀
|
Details
This PR updates the waypoint editor such that:
Fixed Issues
$ #25730
PROPOSAL: #25730
Tests
Case 1
+
button in the LHN and request money.Distance
tab and add a stop.Start
,Stop
andFinish
menu items and verify that the waypoint editor page has the correct title.Case 2
+
button in the LHN and request money.Start
menu item.0
to something like10
orabcd
.Verify that a
Not found
page appears and there isn't any related console error.Offline tests
N/A
QA Steps
Case 1
+
button in the LHN and request money.Distance
tab and add a stop.Start
,Stop
andFinish
menu items and verify that the waypoint editor page has the correct title.Case 2
+
button in the LHN and request money.Start
menu item.0
to something like10
orabcd
.Verify that a
Not found
page appears and there isn't any related console error.PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Web
Screen.Recording.2023-08-24.at.4.52.54.AM.mov
Mobile Web - Chrome
Mobile Web - Safari
Screen.Recording.2023-08-24.at.4.54.01.AM.mov
Desktop
Screen.Recording.2023-08-24.at.5.00.27.AM.mov
iOS
Screen.Recording.2023-08-24.at.4.55.43.AM.mov
Android
Screen.Recording.2023-08-24.at.4.56.41.AM.mov