feat: fix the janky request money tab swipe on web #26022

allroundexperts · 2023-08-27T01:47:48Z

Details

This PR fixes the janky behaviour of the IOU request tabs when switching between request types by swiping.

Fixed Issues

$ #25428
PROPOSAL: #25428 (comment)

Tests

Login with an account that has distance request beta turned on.
Click "+" button and select request money
Try to wipe the screen from left to right
Verify that the screen tabs transition smoothly.

Verify that no errors appear in the JS console

Offline tests

Same as above

QA Steps

Same as above

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is correct English and approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-08-27.at.6.25.53.AM.mov

Mobile Web - Chrome

Screen.Recording.2023-08-27.at.6.32.09.AM.mov

Mobile Web - Safari

Screen.Recording.2023-08-27.at.6.29.36.AM.mov

Desktop

Screen.Recording.2023-08-27.at.7.01.05.AM.mov

iOS

Screen.Recording.2023-08-27.at.6.30.06.AM.mov

Android

Screen.Recording.2023-08-27.at.12.42.35.PM.mov

melvin-bot · 2023-08-27T02:04:59Z

@burczu Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

burczu

added two minor comments, well done otherwise

burczu · 2023-08-29T06:36:53Z

src/components/TabSelector/TabSelector.js

@@ -21,10 +22,17 @@ const propTypes = {

    /* Callback fired when tab is pressed */
    onTabPress: PropTypes.func,
+
+    position: PropTypes.shape({


prop description is missing here

burczu · 2023-08-29T06:38:42Z

src/components/TabSelector/TabIcon.js

+
+    /** Animated opacity value while the label is inactive state */
+    // eslint-disable-next-line
+    inactiveOpacity: PropTypes.any,


Why PropTypes.any? couldn't be PropTypes.number? As I see, these props are numbers 0 or 1?

burczu · 2023-08-29T06:42:00Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

26022-web.mp4

Mobile Web - Chrome

26022-web-mobile-chrome.mp4

Mobile Web - Safari

26022-web-mobile-safari.mp4

Desktop

26022-desktop.mp4

iOS

26022-ios.mp4

Android

26022-android.mp4

burczu · 2023-08-29T09:20:01Z

src/components/TabSelector/TabIcon.js

+
+function TabIcon({icon, activeOpacity, inactiveOpacity}) {
+    return (
+        <View>


is this wrapping <View> necessary? wouldn't be fragment (<>) enough?

Yes. Without it, the layout breaks.

burczu · 2023-08-29T09:20:13Z

src/components/TabSelector/TabLabel.js

+
+function TabLabel({title, activeOpacity, inactiveOpacity}) {
+    return (
+        <View>


Same reply.

burczu · 2023-08-29T09:27:05Z

src/components/TabSelector/TabSelectorItem.js

+
+    /** Animated opacity value while the label is in active state */
+    // eslint-disable-next-line
+    activeOpacity: PropTypes.any,


same for above three props - could PropTypes be more specific here?

@burczu This change actually caused a console warning on native platforms.

burczu

Reviewed and tested - I think we are good to go!

OSBotify · 2023-08-30T17:47:44Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-08-31T01:01:42Z

🚀 Deployed to staging by https://github.com/thienlnam in version: 1.3.60-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-08-31T01:45:07Z

🚀 Deployed to staging by https://github.com/thienlnam in version: 1.3.60-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-08-31T22:49:19Z

🚀 Deployed to production by https://github.com/luacmartins in version: 1.3.60-3 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

allroundexperts added 2 commits August 27, 2023 06:36

feat: fix the janky request money tab swipe on web

83d8efb

fix: lint errors

97a8300

allroundexperts marked this pull request as ready for review August 27, 2023 02:04

allroundexperts requested a review from a team as a code owner August 27, 2023 02:04

melvin-bot bot requested review from burczu and removed request for a team August 27, 2023 02:04

allroundexperts mentioned this pull request Aug 27, 2023

[C+ Checklist Needs Completion] [$1000] DEV:Takes time to change topbar(manual to scan, scan to manual) selection in request money #25428

Closed

6 tasks

fix: more refactoring

152d967

burczu reviewed Aug 29, 2023

View reviewed changes

allroundexperts added 2 commits August 30, 2023 00:59

fix: merge with main

fe59f6d

fix: pr comment changes

85e7035

allroundexperts requested a review from burczu August 29, 2023 20:13

burczu approved these changes Aug 30, 2023

View reviewed changes

melvin-bot bot requested a review from thienlnam August 30, 2023 07:46

thienlnam approved these changes Aug 30, 2023

View reviewed changes

thienlnam merged commit 4fee350 into Expensify:main Aug 30, 2023

OSBotify mentioned this pull request Aug 31, 2023

Deploy Checklist: New Expensify 2023-08-31 #26359

Closed

69 tasks

lanitochka17 mentioned this pull request Aug 31, 2023

[$1000] Request money - Tabs jump back and forth when swiping through tabs #26407

Closed

6 tasks

burczu mentioned this pull request Sep 18, 2023

[HOLD for payment 2023-10-27] [$500] Focus does not shift directly from "Manual" option to "Distance" option #27563

Closed

6 tasks

Ollyws mentioned this pull request Sep 27, 2023

[HOLD for payment 2023-10-18] [$1000] Web - Request money - No hover indicator for top tab options #26648

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: fix the janky request money tab swipe on web #26022

feat: fix the janky request money tab swipe on web #26022

allroundexperts commented Aug 27, 2023 •

edited

Loading

melvin-bot bot commented Aug 27, 2023

burczu left a comment

burczu Aug 29, 2023

allroundexperts Aug 29, 2023

burczu Aug 29, 2023

burczu commented Aug 29, 2023 •

edited

Loading

burczu Aug 29, 2023 •

edited

Loading

allroundexperts Aug 29, 2023

burczu Aug 29, 2023

allroundexperts Aug 29, 2023

burczu Aug 29, 2023

allroundexperts Aug 29, 2023

allroundexperts Aug 31, 2023

burczu left a comment

OSBotify commented Aug 30, 2023

OSBotify commented Aug 31, 2023

OSBotify commented Aug 31, 2023

OSBotify commented Aug 31, 2023

feat: fix the janky request money tab swipe on web #26022

feat: fix the janky request money tab swipe on web #26022

Conversation

allroundexperts commented Aug 27, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Aug 27, 2023

burczu left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

burczu commented Aug 29, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

burczu Aug 29, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

burczu left a comment

Choose a reason for hiding this comment

OSBotify commented Aug 30, 2023

OSBotify commented Aug 31, 2023

OSBotify commented Aug 31, 2023

OSBotify commented Aug 31, 2023

allroundexperts commented Aug 27, 2023 •

edited

Loading

burczu commented Aug 29, 2023 •

edited

Loading

burczu Aug 29, 2023 •

edited

Loading