-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/17365 nostrikethrough solution #26176
Fix/17365 nostrikethrough solution #26176
Conversation
src/components/HTMLEngineProvider/HTMLRenderers/EditedRenderer.js
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, looks good!
@aimane-chnaif Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Performance Tests failing. Did it came from this PR? |
@aimane-chnaif tbh not sure why 😕 |
@aimane-chnaif could it be because I changed withNetwork to useNetwork? |
@aimane-chnaif now I have some different errors, so I guess the useNetwork was not the problem 🤔 |
I'll be OOO from tomorrow, but if any changes are required, someone from my team can take it over. |
@aimane-chnaif I'm taking this over while @koko57 is OOO. Tests were failing because of Just sent the fix, let me know if you need anything else done here! |
@aimane-chnaif Friendly bump here, in case you missed it |
@aimane-chnaif Friendly reminder 🙂 I'm back so I can take it over. |
Sure. Was put on hold for merge freeze. |
@aimane-chnaif all conflicts resolved and synced with newest main |
@aimane-chnaif friendly bump 🙂 everything's up to date |
@aimane-chnaif merged with latest main |
Sorry for delay. Reviewing in a few hrs |
Before-fix and after-fix comparison on iOS, mSafari: Screen.Recording.2023-09-18.at.8.15.49.AM.mov |
Reviewer Checklist
Screenshots/VideosWebweb.mov |
@koko57 please fix conflict and re-test |
@aimane-chnaif done! 🙂 |
re-test is also done too? |
@aimane-chnaif yes, everything works |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
🚀 Deployed to staging by https://github.com/AndrewGable in version: 1.3.72-0 🚀
|
🚀 Deployed to production by https://github.com/thienlnam in version: 1.3.72-11 🚀
|
Details
Fixed Issues
$ #17365
PROPOSAL: #17365 (comment)
Tests
(edited)
tag is not struck through.Offline tests
N/A
QA Steps
(edited)
tag is not struck through.PR Author Checklist
### Fixed Issues
section aboveTests
sectionOffline steps
sectionQA steps
sectiontoggleReport
and notonIconClick
)myBool && <MyComponent />
.src/languages/*
files and using the translation methodWaiting for Copy
label for a copy review on the original GH to get the correct copy.STYLE.md
) were followedAvatar
, I verified the components usingAvatar
are working as expected)/** comment above it */
this
properly so there are no scoping issues (i.e. foronClick={this.submit}
the methodthis.submit
should be bound tothis
in the constructor)this
are necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);
ifthis.submit
is never passed to a component event handler likeonClick
)StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
)Avatar
is modified, I verified thatAvatar
is working as expected in all cases)ScrollView
component to make it scrollable when more elements are added to the page.main
branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTest
steps.Screenshots/Videos
Web
Mobile Web - Chrome
Mobile Web - Safari
Desktop
iOS
Android