Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't show the Download App Banner until Past Sign in #26182

Merged
merged 13 commits into from
Aug 29, 2023
Merged

Don't show the Download App Banner until Past Sign in #26182

merged 13 commits into from
Aug 29, 2023

Commits on Aug 25, 2023

  1. initial fix

    @grgia
    grgia committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    5af5792 View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2023

  1. Merge branch 'main' into georgia-downloadAppBannerFixes

    @grgia
    grgia committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    04d0195 View commit details
    Browse the repository at this point in the history

  2. fix`

    @grgia
    grgia committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    3b1362d View commit details
    Browse the repository at this point in the history

  3. remove spaces

    @grgia
    grgia committed Aug 28, 2023
    Configuration menu
    Copy the full SHA
    ac3dd94 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2023

  1. Merge branch 'main' into georgia-downloadAppBannerFixes

    @grgia
    grgia committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    9673fde View commit details
    Browse the repository at this point in the history

  2. Show download app modal BEFORE welcome message

    @grgia
    grgia committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    84edf34 View commit details
    Browse the repository at this point in the history

  3. remove debugging statements

    @grgia
    grgia committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    c39de0e View commit details
    Browse the repository at this point in the history

  4. ignore this for non mWeb cases

    @grgia
    grgia committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    1a04732 View commit details
    Browse the repository at this point in the history

  5. pass down isAuthenticated

    @grgia
    grgia committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    b3be15a View commit details
    Browse the repository at this point in the history

  6. Fix lint

    @grgia
    grgia committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    2351c41 View commit details
    Browse the repository at this point in the history

  7. add dependency to useEffect

    @grgia
    grgia committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    460b2e6 View commit details
    Browse the repository at this point in the history

  8. lint

    @grgia
    grgia committed Aug 29, 2023
    Configuration menu
    Copy the full SHA
    5df5de8 View commit details
    Browse the repository at this point in the history

  9. early return, rename to shouldShowDownloadAppBanner

    @grgia
    grgia committed Aug 29, 2023
    1 Configuration menu
    Copy the full SHA
    c0e1409 View commit details
    Browse the repository at this point in the history