Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[No QA] Add previousReportActionID to reportAction type #26236

Merged
merged 2 commits into from
Sep 21, 2023
Merged

[No QA] Add previousReportActionID to reportAction type #26236

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
520a06f
Add previousReportActionID to reportAction type
roryabraham Aug 29, 2023
f713993
Ignore docs directory in tsconfig
roryabraham Aug 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/types/onyx/ReportAction.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,9 @@ type ReportActionBase = {
/** The ID of the reportAction. It is the string representation of the a 64-bit integer. */
reportActionID?: string;

/** The ID of the previous reportAction on the report. It is a string represenation of a 64-bit integer (or null for CREATED actions). */
previousReportActionID?: string;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As stated in the comment, there is a legitimate case for this to be null (i.e: CREATED actions).

Maybe a cleaner implementation would put previousReportActionID: string in the type for non-created actions and previousReportActionID: null in the type for CREATED actions, but right now this isn't configured that way.


actorAccountID?: number;

/** Person who created the action */
Expand Down
2 changes: 1 addition & 1 deletion tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,6 @@
"skipLibCheck": true,
"incremental": true
},
"exclude": ["**/node_modules/*", "**/dist/*", ".github/actions/**/index.js"],
"exclude": ["**/node_modules/*", "**/dist/*", ".github/actions/**/index.js", "**/docs/*"],
"include": ["src", "desktop", "web", "docs", "assets", "config", "tests", "jest", "__mocks__", ".github/**/*", ".storybook/**/*"]
}
Loading