Replace receipt #26508

luacmartins · 2023-09-01T18:12:05Z

Details

Adds the ability to replace transaction receipts

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/295248

Tests

Request money via Scan option
Tap the report preview
Tap the request preview
Tap the receipt image
When the modal opens, tap the three dot menu at the top
Select replace
verify that receipt selector opens in the right hand modal
Select a new receipt
Verify that the receipt is updated
Log out and log back in
Verify that the new receipt still shows up

Verify that no errors appear in the JS console

Offline tests

Same as tests

QA Steps

Same as tests

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

I'm having issues building iOS and android native at the moment. I'll try to upload the videos later.

Web

web.mov

Mobile Web - Chrome

chrome.mov

Mobile Web - Safari

safari.mov

Desktop

desktop.mov

iOS

ios.mov

Android

android.mov

This reverts commit 356f371.

luacmartins · 2023-09-19T01:44:34Z

Ok, I think the web issues are gone after merging main. Gonna look into the cross platform issue now

luacmartins · 2023-09-19T04:11:25Z

I was able to test on iOS and I do see the image being updated on web.

Android simulator is giving me a lot of headaches with the bad internet connection in Bali, so I'm not able to reliably test this condition. This PR is blocking others, so given that it's working on all platforms but android I think we should go ahead and merge this PR and then address the issue in a follow up if we encounter it on staging

ios.web.mov

Gonals

Code looks good! Just one question and I'll jump to testing

Gonals · 2023-09-19T04:16:14Z

src/components/AttachmentModal.js

@@ -331,6 +338,10 @@ function AttachmentModal(props) {
 }}
 onModalHide={(e) => {
 props.onModalHide(e);
+ if (onModalHideCallbackRef.current) {


What does this do?

Gonals · 2023-09-19T05:28:53Z

Tests well, but Android is also being a pain for me. I'm ok merging this

burczu · 2023-09-19T06:30:40Z

I don't know what to do with this. For me it works very unpredictable and I'm not sure if I want to take responsibility for approving this...

burczu · 2023-09-19T06:41:00Z

Another issue, this time on iOS:

Screen.Recording.2023-09-19.at.08.37.37.mov

MariaHCD · 2023-09-19T09:48:14Z

@burczu could you clarify what you mean by:

For me it works very unpredictable

Happy to help test here, if needed, @luacmartins.

burczu · 2023-09-19T10:13:27Z

@MariaHCD I encountered some issues (you can see my comments in the thread above), that I don't see resolved. If you like to test it, go on - maybe it's the matter of my environment. Right now I'm struggling with Android build so I can't get back to this PR at the moment.

burczu · 2023-09-19T11:53:02Z

@luacmartins I've cleaned my environment and re-tested everything with new user. Web is now working as expeced, as well as on Android. The only issue I have is with iOS - please see this comment. It sometimes work but in most cases it throws an error of "Unhandled Promise Rejection".

luacmartins · 2023-09-20T06:49:01Z

That error points to this fetch call failing with a Networks request failed error. We have this issue to better handle errors in readFileAsync so I don't think that's a blocker for this issue.

luacmartins · 2023-09-20T06:49:22Z

@MariaHCD I'd love another review here so we can get this merged asap.

burczu

Alright, I was able to successfully replace the image on iOS so I think I can approve it... I'm not sure how improving error handling will fix the issue with rejecting this Promise, because I guess the question is why it is rejected not how it is handled...

melvin-bot · 2023-09-20T07:27:46Z

@Li357 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2023-09-20T07:27:50Z

🎯 @burczu, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #27835.

luacmartins · 2023-09-20T07:43:58Z

Yea, that makes sense. I'll investigate that as part of the other issue!

OSBotify · 2023-09-20T07:49:27Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-09-20T08:43:18Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 1.3.72-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-09-22T13:25:13Z

🚀 Deployed to production by https://github.com/thienlnam in version: 1.3.72-11 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

Li357 · 2023-10-06T04:15:30Z

src/components/AttachmentModal.js

+ icon: Expensicons.Camera,
+ text: props.translate('common.replace'),
+ onSelected: () => {
+ onModalHideCallbackRef.current = () => Navigation.navigate(ROUTES.getEditRequestRoute(props.report.reportID, CONST.EDIT_REQUEST_FIELD.RECEIPT));


This caused #27903 when navigating to the replace receipt screen not from within a tab navigator, i.e. whenever clicking from the three dots menu.

hoangzinh · 2023-10-10T23:16:32Z

src/pages/EditRequestReceiptPage.js

+ <HeaderWithBackButton
+ title={translate('common.receipt')}
+ onBackButtonPress={Navigation.goBack}
+ />
+ <DragAndDropProvider>
+ <ReceiptSelector
+ route={route}
+ transactionID={transactionID}
+ />
+ </DragAndDropProvider>


This causes an inconsistency issue here where the Green drag and drop area does not show in full-screen #28014

create EditRequestReceiptPage

d2f3e5f

luacmartins self-assigned this Sep 1, 2023

luacmartins added 5 commits September 1, 2023 13:58

rm EditRequestReceiptPage

6c96baf

add three dot menu

c1bd0b1

use correct anchor position

3c2594a

add overlay

3a69d70

adjust offset

8116a8e

luacmartins changed the title ~~create EditRequestReceiptPage~~ Replace receipt Sep 1, 2023

luacmartins added 18 commits September 5, 2023 12:25

Merge branch 'main' into cmartins-replaceReceipt

f5234ac

add replace callback

6ea483c

add comment

eb50cd0

use attachmentmodal in reportActionItemImage

356f371

Revert "use attachmentmodal in reportActionItemImage"

1c54e59

This reverts commit 356f371.

create EditRequestReceiptPage

84ef3bd

create route const, add onSubmit callback, navigate to correct route

2ac57b7

rm double onyx usage

945d500

add onyx back, add dropui provider

f4392a1

add props

125117b

pass replaceReceipt callback to ReceiptSelector

95fc8c2

create IOU.replaceReceipt

23acf54

dismiss modal

69ac668

resolve navigation issue

24b38e6

use correct file path and name

43c08f5

replace in open state

435bb61

Merge branch 'main' into cmartins-replaceReceipt

e735569

fix styles

a1c8657

luacmartins marked this pull request as ready for review September 11, 2023 05:40

luacmartins requested a review from a team as a code owner September 11, 2023 05:40

melvin-bot bot requested review from rushatgabhane and removed request for a team September 11, 2023 05:41

Merge branch 'main' into cmartins-replaceReceipt

35d51ab

Gonals reviewed Sep 19, 2023

View reviewed changes

Gonals approved these changes Sep 19, 2023

View reviewed changes

burczu approved these changes Sep 20, 2023

View reviewed changes

melvin-bot bot requested a review from Li357 September 20, 2023 07:27

melvin-bot bot mentioned this pull request Sep 20, 2023

Payment issue for E/App PR#26508 #27835

Closed

luacmartins merged commit a29650f into main Sep 20, 2023
13 of 16 checks passed

luacmartins deleted the cmartins-replaceReceipt branch September 20, 2023 07:44

OSBotify mentioned this pull request Sep 20, 2023

Deploy Checklist: New Expensify 2023-09-20 #27837

Closed

lanitochka17 mentioned this pull request Sep 20, 2023

[$500] [HOLD for payment 2023-10-02] [HOLD for payment 2023-09-29] RM - App crashed when tap replace receipt #27903

Closed

6 tasks

Li357 reviewed Oct 6, 2023

View reviewed changes

hoangzinh reviewed Oct 10, 2023

View reviewed changes

hoangzinh mentioned this pull request Oct 10, 2023

[HOLD for payment 2023-10-12] [HOLD for payment 2023-10-10] [$500] Web - Green drag and drop area does not show in full screen #28014

Closed

6 tasks

mananjadhav mentioned this pull request Oct 27, 2023

[HOLD for payment 2023-10-24] [$500] iOS - Receipt replace popup camera click button is overlapping with home bar #28145

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Replace receipt #26508

Replace receipt #26508

luacmartins commented Sep 1, 2023 •

edited

Loading

luacmartins commented Sep 19, 2023 •

edited

Loading

luacmartins commented Sep 19, 2023

Gonals left a comment

Gonals Sep 19, 2023

Gonals commented Sep 19, 2023

burczu commented Sep 19, 2023 •

edited

Loading

burczu commented Sep 19, 2023

MariaHCD commented Sep 19, 2023

burczu commented Sep 19, 2023

burczu commented Sep 19, 2023 •

edited

Loading

luacmartins commented Sep 20, 2023

luacmartins commented Sep 20, 2023

burczu left a comment

melvin-bot bot commented Sep 20, 2023

melvin-bot bot commented Sep 20, 2023

luacmartins commented Sep 20, 2023

OSBotify commented Sep 20, 2023

OSBotify commented Sep 20, 2023

OSBotify commented Sep 22, 2023

Li357 Oct 6, 2023

hoangzinh Oct 10, 2023

Replace receipt #26508

Replace receipt #26508

Conversation

luacmartins commented Sep 1, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

luacmartins commented Sep 19, 2023 • edited Loading

luacmartins commented Sep 19, 2023

Gonals left a comment

Choose a reason for hiding this comment

Gonals Sep 19, 2023

Choose a reason for hiding this comment

Gonals commented Sep 19, 2023

burczu commented Sep 19, 2023 • edited Loading

burczu commented Sep 19, 2023

MariaHCD commented Sep 19, 2023

burczu commented Sep 19, 2023

burczu commented Sep 19, 2023 • edited Loading

luacmartins commented Sep 20, 2023

luacmartins commented Sep 20, 2023

burczu left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Sep 20, 2023

melvin-bot bot commented Sep 20, 2023

luacmartins commented Sep 20, 2023

OSBotify commented Sep 20, 2023

OSBotify commented Sep 20, 2023

OSBotify commented Sep 22, 2023

Li357 Oct 6, 2023

Choose a reason for hiding this comment

hoangzinh Oct 10, 2023

Choose a reason for hiding this comment

luacmartins commented Sep 1, 2023 •

edited

Loading

luacmartins commented Sep 19, 2023 •

edited

Loading

burczu commented Sep 19, 2023 •

edited

Loading

burczu commented Sep 19, 2023 •

edited

Loading