fix: logic for waypoint validation

src/components/DistanceRequest.js

@@ -90,8 +90,8 @@ function DistanceRequest({iou, iouType, report, transaction, mapboxAccessToken})
     const previousWaypoints = usePrevious(waypoints);
     const haveWaypointsChanged = !_.isEqual(previousWaypoints, waypoints);
     const doesRouteExist = lodashHas(transaction, 'routes.route0.geometry.coordinates');
-    const shouldFetchRoute = (!doesRouteExist || haveWaypointsChanged) && !isLoadingRoute && TransactionUtils.validateWaypoints(waypoints);
-
+    const validatedWaypoints = TransactionUtils.getValidWaypoints(waypoints);
+    const shouldFetchRoute = (!doesRouteExist || haveWaypointsChanged) && !isLoadingRoute && _.keys(validatedWaypoints).length > 1;
     const waypointMarkers = useMemo(
         () =>
             _.filter(
@@ -149,14 +149,13 @@ function DistanceRequest({iou, iouType, report, transaction, mapboxAccessToken})
         const visibleAreaEnd = lodashGet(event, 'nativeEvent.contentOffset.y', 0) + scrollContainerHeight;
         setShouldShowGradient(visibleAreaEnd < scrollContentHeight);
     };
-
     useEffect(() => {
         if (isOffline || !shouldFetchRoute) {
             return;
         }
 
-        Transaction.getRoute(iou.transactionID, waypoints);
-    }, [shouldFetchRoute, iou.transactionID, waypoints, isOffline]);
+        Transaction.getRoute(iou.transactionID, validatedWaypoints);
+    }, [shouldFetchRoute, iou.transactionID, validatedWaypoints, isOffline]);
 
     useEffect(updateGradientVisibility, [scrollContainerHeight, scrollContentHeight]);
 
@@ -256,7 +255,7 @@ function DistanceRequest({iou, iouType, report, transaction, mapboxAccessToken})
                 style={[styles.w100, styles.mb4, styles.ph4, styles.flexShrink0]}
                 onPress={() => IOU.navigateToNextPage(iou, iouType, reportID, report)}
                 pressOnEnter
-                isDisabled={waypointMarkers.length < 2}
+                isDisabled={_.keys(validatedWaypoints).length < 2}
                 text={translate('common.next')}
             />
         </>

src/libs/TransactionUtils.js

@@ -268,34 +268,44 @@ function getAllReportTransactions(reportID) {
 }
 
 /**
- * Verifies that the provided waypoints are valid
+ * Filters the waypoints which are valid and returns those
  * @param {Object} waypoints
- * @returns {Boolean}
+ * @param {Boolean} reArrangeIndexes
+ * @returns {Object} validated waypoints
  */
-function validateWaypoints(waypoints) {
+function getValidWaypoints(waypoints, reArrangeIndexes = false) {
     const waypointValues = _.values(waypoints);
-
     // Ensure the number of waypoints is between 2 and 25
     if (waypointValues.length < 2 || waypointValues.length > 25) {
-        return false;
+        return {};
     }
 
-    for (let i = 0; i < waypointValues.length; i++) {
-        const currentWaypoint = waypointValues[i];
-        const previousWaypoint = waypointValues[i - 1];
+    let lastWaypointIndex = -1;
 
-        // Check if the waypoint has a valid address
-        if (!currentWaypoint || !currentWaypoint.address || typeof currentWaypoint.address !== 'string' || currentWaypoint.address.trim() === '') {
-            return false;
-        }
+    const validWaypoints = _.reduce(
+        waypointValues,
+        (acc, currentWaypoint, index) => {
+            const previousWaypoint = waypointValues[lastWaypointIndex];
+            // Check if the waypoint has a valid address
+            if (!currentWaypoint || !currentWaypoint.address || typeof currentWaypoint.address !== 'string' || currentWaypoint.address.trim() === '') {
+                return acc;
+            }
 
-        // Check for adjacent waypoints with the same address
-        if (previousWaypoint && currentWaypoint.address === previousWaypoint.address) {
-            return false;
-        }
-    }
+            // Check for adjacent waypoints with the same address
+            if (previousWaypoint && currentWaypoint.address === previousWaypoint.address) {
+                return acc;
+            }
+
+            const validatedWaypoints = {...acc, [`waypoint${reArrangeIndexes ? lastWaypointIndex + 1 : index}`]: currentWaypoint};
+
+            lastWaypointIndex += 1;
+
+            return validatedWaypoints;
+        },
+        {},
+    );
 
-    return true;
+    return validWaypoints;
 }
 
 /*
@@ -325,7 +335,7 @@ export {
     getAllReportTransactions,
     hasReceipt,
     isReceiptBeingScanned,
-    validateWaypoints,
+    getValidWaypoints,
     isDistanceRequest,
     hasMissingSmartscanFields,
 };

src/libs/actions/IOU.js

@@ -530,7 +530,7 @@ function createDistanceRequest(report, participant, comment, created, transactio
             createdChatReportActionID,
             createdIOUReportActionID,
             reportPreviewReportActionID: reportPreviewAction.reportActionID,
-            waypoints: JSON.stringify(transaction.comment.waypoints),
+            waypoints: JSON.stringify(TransactionUtils.getValidWaypoints(transaction.comment.waypoints, true)),
             created,
         },
         onyxData,