Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: download app modal hide permanently when clicked on download #26752

Merged
merged 2 commits into from
Sep 5, 2023
Merged

fix: download app modal hide permanently when clicked on download #26752

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
18259d7
fix: download app modal hide permanently when clicked on download
allroundexperts Sep 5, 2023
c698c08
fix: set state typo in the download app modal component
allroundexperts Sep 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/components/DownloadAppModal.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,8 @@ function DownloadAppModal({isAuthenticated, showDownloadAppBanner}) {
}

const handleOpenAppStore = () => {
setShowDownloadAppModal(false);
setshouldShowBanner(false);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know that it's not your implementation - but maybe you can fix this typo to be setShouldShowBanner

Screenshot 2023-09-05 at 14 20 10

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

Link.openExternalLink(link, true);
};

Expand Down
Loading