Add log when we try to deep link redirect while not authenticated. Don't crash the app. #26839

marcaaron · 2023-09-06T01:20:56Z

Details

Not sure how @davidcardoza got into this state, but the app is crashing for him and he is hitting the deep link redirect code flow. At a minimum, I think we are clearly doing a bad access on an empty response variable. Doesn't answer the question of why we are hitting that code yet. But does explain the JS error in the console logs shared.

Fixed Issues (Add logs for)

https://github.com/Expensify/Expensify/issues/312304

Tests

Set this diff in Web-E to emulate expired session

diff --git a/lib/UserAPI.php b/lib/UserAPI.php
index c748595048a..659263536c1 100644
--- a/lib/UserAPI.php
+++ b/lib/UserAPI.php
@@ -2203,7 +2203,7 @@ class UserAPI
     {
         try {
             return [
-                'shortLivedAuthToken' => Auth::getShortLivedAuthToken($authToken),
+                'jsonCode' => 407
             ];
         } catch (Throwable $e) {

Set this diff in App so we can force calling the method from the web app

diff --git a/src/libs/actions/App.js b/src/libs/actions/App.js
index e77fb98c28..057e3aa4b5 100644
--- a/src/libs/actions/App.js
+++ b/src/libs/actions/App.js
@@ -462,6 +462,8 @@ function beginDeepLinkRedirect(shouldAuthenticateWithCurrentAccount = true) {
     });
 }

+window.beginDeepLinkRedirect = beginDeepLinkRedirect;
+
 /**
  * @param {boolean} shouldAuthenticateWithCurrentAccount Optional, indicates whether default authentication method (shortLivedAuthToken) should be used
  */

Call method from JS console
Verify that the alert happens

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Navigate to NewDot on staging web
Install the staging desktop app
Sign into NewDot on staging web
Refresh the page to trigger the deep link flow to the desktop app (if Chrome asks to open the page in the desktop app allow it to do so)
Verify you get redirected and the desktop app opens
Back in staging web invalidate credentials via the preferences pane
Refresh the page again to trigger the deep link flow
Verify the app does not crash and there are no errors in the JS console.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Web

not relevant to other platforms besides web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

… this code

melvin-bot · 2023-09-06T02:14:02Z

@cead22 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

cead22 · 2023-09-06T21:36:44Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

marcaaron · 2023-09-06T21:54:49Z

Updated the test steps for QA because they were pretty vague thanks @cead22 🙇

marcaaron · 2023-09-07T20:02:52Z

We discovered these warnings in the console:

#26986

The error about React 18 is being looked into here: #11680

Various compilation warnings here (I had to create a few):

#26988
#26987
#26989
#26990
#26991
#26992
#26092

marcaaron · 2023-09-11T21:33:10Z

Removing the hold here as the feature freeze is over

davidcardoza · 2023-09-14T21:38:14Z

@marcaaron Are we good to merge this PR?

marcaaron · 2023-09-15T20:20:48Z

Waiting for @cead22.

cead22 · 2023-09-18T05:09:42Z

I'm still getting into a loop when testing this

cead22 · 2023-09-18T06:10:23Z

I was finally able to test and get the log line to show, sorry for the delay, I'm not sure why this wasn't working for me before

OSBotify · 2023-09-18T06:17:40Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-09-18T10:39:00Z

🚀 Deployed to staging by https://github.com/cead22 in version: 1.3.71-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-09-20T08:11:30Z

🚀 Deployed to production by https://github.com/thienlnam in version: 1.3.71-12 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

Add a log for Doza so that we can try to figure out why he is hitting…

34a2fdb

… this code

marcaaron self-assigned this Sep 6, 2023

marcaaron added 2 commits September 5, 2023 15:59

add more params

c5cc1c8

Add more to the comment

e4d3e4a

marcaaron marked this pull request as ready for review September 6, 2023 02:13

marcaaron requested a review from a team as a code owner September 6, 2023 02:13

melvin-bot bot removed the request for review from a team September 6, 2023 02:14

melvin-bot bot requested a review from cead22 September 6, 2023 02:14

run prettier

58efdcb

davidcardoza approved these changes Sep 6, 2023

View reviewed changes

marcaaron changed the title ~~Add log when we try to deep link redirect while not authenticated. Don't crash the app.~~ [HOLD merge freeze] Add log when we try to deep link redirect while not authenticated. Don't crash the app. Sep 6, 2023

cead22 changed the title ~~[HOLD merge freeze] Add log when we try to deep link redirect while not authenticated. Don't crash the app.~~ [HOLD feature freeze] Add log when we try to deep link redirect while not authenticated. Don't crash the app. Sep 6, 2023

marcaaron changed the title ~~[HOLD feature freeze] Add log when we try to deep link redirect while not authenticated. Don't crash the app.~~ Add log when we try to deep link redirect while not authenticated. Don't crash the app. Sep 11, 2023

cead22 approved these changes Sep 18, 2023

View reviewed changes

cead22 merged commit ea5f461 into main Sep 18, 2023
18 checks passed

cead22 deleted the marcaaron-addLogForDoza branch September 18, 2023 06:12

OSBotify mentioned this pull request Sep 18, 2023

Deploy Checklist: New Expensify 2023-09-18 #27654

Closed

91 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add log when we try to deep link redirect while not authenticated. Don't crash the app. #26839

Add log when we try to deep link redirect while not authenticated. Don't crash the app. #26839

marcaaron commented Sep 6, 2023 •

edited

Loading

melvin-bot bot commented Sep 6, 2023

cead22 commented Sep 6, 2023 •

edited

Loading

marcaaron commented Sep 6, 2023

marcaaron commented Sep 7, 2023

marcaaron commented Sep 11, 2023

davidcardoza commented Sep 14, 2023

marcaaron commented Sep 15, 2023

cead22 commented Sep 18, 2023

cead22 commented Sep 18, 2023

OSBotify commented Sep 18, 2023

OSBotify commented Sep 18, 2023

OSBotify commented Sep 20, 2023

Add log when we try to deep link redirect while not authenticated. Don't crash the app. #26839

Add log when we try to deep link redirect while not authenticated. Don't crash the app. #26839

Conversation

marcaaron commented Sep 6, 2023 • edited Loading

Details

Fixed Issues (Add logs for)

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Sep 6, 2023

cead22 commented Sep 6, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

marcaaron commented Sep 6, 2023

marcaaron commented Sep 7, 2023

marcaaron commented Sep 11, 2023

davidcardoza commented Sep 14, 2023

marcaaron commented Sep 15, 2023

cead22 commented Sep 18, 2023

cead22 commented Sep 18, 2023

OSBotify commented Sep 18, 2023

OSBotify commented Sep 18, 2023

OSBotify commented Sep 20, 2023

marcaaron commented Sep 6, 2023 •

edited

Loading

cead22 commented Sep 6, 2023 •

edited

Loading