create the Expensify card page #26915

pasyukevich · 2023-09-06T21:13:33Z

Details

Fixed Issues

$ #22873
PROPOSAL:

Tests

Add useEffect with test data to the InitialSettingsPage

 useEffect(() => {
        window.Onyx.merge(`cardList`, {
            'virtual': {
                cardID: 234523452345,
                state: 3,
                bank: 'Expensify',
                availableSpend:10000,
        domainName: 'Expensify',
        lastFourPAN: '',
        isVirtual: true,
        cardholderFirstName: "Test",
        cardholderLastName: "Test",
            }, 'physical': {
                cardID: 234523452345,
                state: 3,
                bank: '1000',
                availableSpend:10000,
        domainName: 'Expensify',
        lastFourPAN: '2345',
        isVirtual: false,
            },
        });

        Navigation.navigate(ROUTES.getWalletCardRoute('expensify'));
    }, []);

Open app
Press on your Avatar, observe the card settings
Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mp4

Mobile Web - Chrome

Untitled.mp4

Mobile Web - Safari

ios-web.mp4

Desktop

desktop.mov

iOS

ios-native.mp4

Android

android.card.native.webm

src/components/CardPreview.js

src/pages/settings/Wallet/ExpensifyCardPage.js

src/components/CardPreview.js

src/languages/es.ts

src/pages/settings/Wallet/ExpensifyCardPage.js

pac-guerreiro · 2023-09-11T10:10:11Z

cc @grgia

melvin-bot · 2023-09-11T10:10:57Z

@narefyev91 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

narefyev91 · 2023-09-12T13:05:44Z

@pac-guerreiro can you please fill checklist and record video - does this PR ready to be reviewed?

pasyukevich · 2023-09-14T13:38:17Z

Rebased to solve conflicts

narefyev91 · 2023-09-15T08:39:54Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

webmov.mov

Mobile Web - Chrome

android-web.mov

Mobile Web - Safari

ios-web.mov

Desktop

desktop.mov

iOS

ios.mov

Android

android.mov

narefyev91 · 2023-09-15T08:45:13Z

@joekaufmanexpensify Hey! Most of the logic working fine. During testing discovered a crash - if user will directly navigate to this page without either virtual or physical card - code will be broken - @pasyukevich already working on the fix
Reference:

Also we need to ask design team to review current page @shawnborton :
IOS:

Android:

Web/Desktop:

pasyukevich · 2023-09-15T09:25:26Z

@narefyev91 applied fix to prevent app crash

shawnborton · 2023-09-18T05:31:18Z

Feels good to me. Can you show me an example with a really long card holder name though?

grgia · 2023-09-18T05:44:27Z

@pasyukevich heads up on merge conflicts!

grgia · 2023-09-18T05:48:51Z

@pasyukevich
A tip if you're not already using this method, but you can also merge onyx directly from the console

i.e.

        Onyx.merge(`cardList`, {
            'virtual': {
                cardID: 234523452345,
                state: 3,
                bank: 'Expensify',
                availableSpend:10000,
        domainName: 'Expensify',
        maskedPan: '•••• •••• •••• ••••',
        isVirtual: true,
        cardholderFirstName: "Test",
        cardholderLastName: "Test",
            }, 'physical': {
                cardID: 234523452345,
                state: 3,
                bank: '1000',
                availableSpend:10000,
        domainName: 'Expensify',
        maskedPan: '•••• •••• •••• 2345',
        isVirtual: false,
            },
        });

narefyev91

Crash was fixed
LGTM!
🎀 👀 🎀 C+ reviewed

grgia · 2023-09-18T07:34:47Z

@pasyukevich when a user navigates to the card page without a physical or virtual card, let's show the page not found page instead. You can reference this pattern in LoungeAccessPage.js

JKobrynski · 2023-09-22T07:01:11Z

@grgia conflict fixed!

marcaaron

These changes look pretty great to me overall 👍

marcaaron · 2023-09-25T04:18:57Z

src/components/CardPreview.js

+        legalFirstName: PropTypes.string,
+        legalLastName: PropTypes.string,
+    }),
+    session: PropTypes.shape({


Can we add a doc above this for completeness?

marcaaron · 2023-09-25T04:31:03Z

src/components/CardPreview.js

+};
+
+function CardPreview({privatePersonalDetails: {legalFirstName, legalLastName}, session: {email}}) {
+    usePrivatePersonalDetails();


NAB, but maybe this should be useFetchPrivatePersonalDetails() or something that maybe better explains what this does. Started some conversation here but not a blocker for this PR.

marcaaron · 2023-09-25T04:53:58Z

There are some conflicts again, thanks!

pasyukevich · 2023-09-25T09:00:16Z

@marcaaron conflicts solved

grgia · 2023-09-25T09:45:52Z

Testing locally now!

grgia

Changes look good, thank you!

grgia · 2023-09-25T12:08:46Z

@narefyev91 could you take a look at the latest changes before I merge

narefyev91 · 2023-09-25T12:09:55Z

@narefyev91 could you take a look at the latest changes before I merge

sure thing - will do asap

narefyev91

LGTM!

OSBotify · 2023-09-26T01:01:02Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

tgolen · 2023-09-26T01:44:50Z

src/ROUTES.ts

@@ -7,149 +7,168 @@ import CONST from './CONST';

 // prettier-ignore
 export default {
-    HOME:                                       '',


Why was all the whitespace removed from this file? It was intentional and this file is now difficult to read.

OSBotify · 2023-09-28T19:20:28Z

🚀 Deployed to staging by https://github.com/grgia in version: 1.3.75-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-02T17:24:23Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.75-12 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

mountiny · 2023-10-02T17:42:12Z

Should these be marked as No QA as they cannot be QAed in staging?

OSBotify · 2023-10-02T17:53:01Z

🚀 Deployed to staging by https://github.com/grgia in version: 1.3.76-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-03T15:53:58Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.76-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

blazejkustra · 2023-10-20T12:38:41Z

src/libs/CardUtils.ts

+ * @returns collection of assigned cards grouped by domain
+ */
+function getDomainCards(cardList: Record<string, OnyxTypes.Card>) {
+    // eslint-disable-next-line you-dont-need-lodash-underscore/filter


Underscore/Lodash should no longer be used in Typescript files @pasyukevich

sobitneupane · 2024-02-02T09:05:37Z

This issue was not handled in this PR.

Issue: "Physical card number" row is showing when the user has not completed their shipping details yet

It was handled by https://github.com/Expensify/App/pull/34040/files.

pasyukevich force-pushed the feature/expensify-card branch from 3093612 to 9d995fb Compare September 7, 2023 06:30

BeeMargarida reviewed Sep 8, 2023

View reviewed changes

pac-guerreiro force-pushed the feature/expensify-card branch from 9d995fb to 449b339 Compare September 8, 2023 14:30

gedu reviewed Sep 8, 2023

View reviewed changes

src/components/CardPreview.js Outdated Show resolved Hide resolved

gedu reviewed Sep 8, 2023

View reviewed changes

src/components/CardPreview.js Outdated Show resolved Hide resolved

gedu reviewed Sep 8, 2023

View reviewed changes

src/languages/es.ts Outdated Show resolved Hide resolved

gedu reviewed Sep 8, 2023

View reviewed changes

src/pages/settings/Wallet/ExpensifyCardPage.js Outdated Show resolved Hide resolved

pac-guerreiro force-pushed the feature/expensify-card branch from ba54c75 to 0ce9139 Compare September 8, 2023 16:15

pasyukevich marked this pull request as ready for review September 11, 2023 10:10

pasyukevich requested a review from a team as a code owner September 11, 2023 10:10

melvin-bot bot removed the request for review from a team September 11, 2023 10:10

melvin-bot bot requested a review from narefyev91 September 11, 2023 10:10

pac-guerreiro force-pushed the feature/expensify-card branch from 0ce9139 to 760fcb3 Compare September 11, 2023 10:43

pac-guerreiro mentioned this pull request Sep 12, 2023

[HOLD for payment 2023-10-09] [ECard Settings] - Create the Expensify card page #22873

Closed

pasyukevich force-pushed the feature/expensify-card branch 2 times, most recently from 426f347 to 9e92a54 Compare September 14, 2023 13:35

pasyukevich force-pushed the feature/expensify-card branch from 3e7b2db to b1d193e Compare September 15, 2023 10:56

grgia self-requested a review September 18, 2023 05:44

narefyev91 approved these changes Sep 18, 2023

View reviewed changes

marcaaron previously approved these changes Sep 25, 2023

View reviewed changes

marcaaron assigned pasyukevich Sep 25, 2023

pasyukevich added 2 commits September 25, 2023 10:35

Merge branch 'main' into feature/expensify-card

2f92e75

add testID for expensify card page

a22a2d6

pasyukevich dismissed marcaaron’s stale review via a22a2d6 September 25, 2023 08:44

add doc for session

a823f1a

pasyukevich requested review from grgia and marcaaron September 25, 2023 09:04

grgia approved these changes Sep 25, 2023

View reviewed changes

grgia requested a review from narefyev91 September 25, 2023 12:08

narefyev91 approved these changes Sep 25, 2023

View reviewed changes

grgia merged commit f23241d into Expensify:main Sep 26, 2023
13 checks passed

tgolen reviewed Sep 26, 2023

View reviewed changes

OSBotify mentioned this pull request Sep 28, 2023

Deploy Checklist: New Expensify 2023-09-28 #28412

Closed

OSBotify mentioned this pull request Oct 2, 2023

Deploy Checklist: New Expensify 2023-10-02 #28635

Closed

blazejkustra reviewed Oct 20, 2023

View reviewed changes

sobitneupane mentioned this pull request Feb 2, 2024

[HOLD for payment 2024-01-18] [Card Settings] 🐛 "Physical card number" row is showing when the user has not completed their shipping details yet #33510

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

create the Expensify card page #26915

create the Expensify card page #26915

pasyukevich commented Sep 6, 2023 •

edited

Loading

pac-guerreiro commented Sep 11, 2023

melvin-bot bot commented Sep 11, 2023

narefyev91 commented Sep 12, 2023

pasyukevich commented Sep 14, 2023

narefyev91 commented Sep 15, 2023

narefyev91 commented Sep 15, 2023

pasyukevich commented Sep 15, 2023

shawnborton commented Sep 18, 2023

grgia commented Sep 18, 2023

grgia commented Sep 18, 2023

narefyev91 left a comment

grgia commented Sep 18, 2023

JKobrynski commented Sep 22, 2023

marcaaron left a comment

marcaaron Sep 25, 2023

pasyukevich Sep 25, 2023

marcaaron Sep 25, 2023

marcaaron commented Sep 25, 2023

pasyukevich commented Sep 25, 2023

grgia commented Sep 25, 2023

grgia left a comment

grgia commented Sep 25, 2023

narefyev91 commented Sep 25, 2023

narefyev91 left a comment

OSBotify commented Sep 26, 2023

tgolen Sep 26, 2023 •

edited

Loading

OSBotify commented Sep 28, 2023

OSBotify commented Oct 2, 2023

mountiny commented Oct 2, 2023

OSBotify commented Oct 2, 2023

OSBotify commented Oct 3, 2023

blazejkustra Oct 20, 2023

sobitneupane commented Feb 2, 2024 •

edited

Loading

create the Expensify card page #26915

create the Expensify card page #26915

Conversation

pasyukevich commented Sep 6, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

pac-guerreiro commented Sep 11, 2023

melvin-bot bot commented Sep 11, 2023

narefyev91 commented Sep 12, 2023

pasyukevich commented Sep 14, 2023

narefyev91 commented Sep 15, 2023

Reviewer Checklist

Screenshots/Videos

narefyev91 commented Sep 15, 2023

pasyukevich commented Sep 15, 2023

shawnborton commented Sep 18, 2023

grgia commented Sep 18, 2023

grgia commented Sep 18, 2023

narefyev91 left a comment

Choose a reason for hiding this comment

grgia commented Sep 18, 2023

JKobrynski commented Sep 22, 2023

marcaaron left a comment

Choose a reason for hiding this comment

marcaaron Sep 25, 2023

Choose a reason for hiding this comment

pasyukevich Sep 25, 2023

Choose a reason for hiding this comment

marcaaron Sep 25, 2023

Choose a reason for hiding this comment

marcaaron commented Sep 25, 2023

pasyukevich commented Sep 25, 2023

grgia commented Sep 25, 2023

grgia left a comment

Choose a reason for hiding this comment

grgia commented Sep 25, 2023

narefyev91 commented Sep 25, 2023

narefyev91 left a comment

Choose a reason for hiding this comment

OSBotify commented Sep 26, 2023

tgolen Sep 26, 2023 • edited Loading

Choose a reason for hiding this comment

OSBotify commented Sep 28, 2023

OSBotify commented Oct 2, 2023

mountiny commented Oct 2, 2023

OSBotify commented Oct 2, 2023

OSBotify commented Oct 3, 2023

blazejkustra Oct 20, 2023

Choose a reason for hiding this comment

sobitneupane commented Feb 2, 2024 • edited Loading

pasyukevich commented Sep 6, 2023 •

edited

Loading

tgolen Sep 26, 2023 •

edited

Loading

sobitneupane commented Feb 2, 2024 •

edited

Loading