Fix: 26339 Workspace - Unable to remove error reported member #26975

tienifr · 2023-09-07T15:43:40Z

Details

Fixed Issues

$ #26339
PROPOSAL: #26339 (comment)

Tests

Go to app
Tap profile icon
Tap workspace
Tap any created workspace
Tap members
Tap invite
Tap any invalid number (+84566123459@expensify.sms)
Tap invite
Tap on close button in workspace members page
Select error reported member and tap remove
Navigate back to general settings page
Refresh page
Tap workspace
Tap members
Verify that the invalid member is removed

Verify that no errors appear in the JS console

Offline tests

Same as above

QA Steps

Go to app
Tap profile icon
Tap workspace
Tap any created workspace
Tap members
Tap invite
Tap any invalid number (+84566123459@expensify.sms)
Tap invite
Tap on close button in workspace members page
Select error reported member and tap remove
Navigate back to general settings page
Refresh page
Tap workspace
Tap members
Verify that the invalid member is removed

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-09-07.at.22.38.32.mov

Mobile Web - Chrome

374610762_9949966298407927_3944890432015582513_n.mp4

Mobile Web - Safari

374592903_6648663498560589_1011807065365875651_n.mp4

Desktop

Screen.Recording.2023-09-07.at.22.05.18.mov

iOS

Screen.Recording.2023-09-07.at.22.58.04.mov

Android

Screen.Recording.2023-09-11.at.16.53.00.mov

melvin-bot · 2023-09-07T15:59:02Z

@jjcoffee Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

tienifr · 2023-09-07T16:03:03Z

@jjcoffee I created the PR. Some notes:

I think we should use accountID: Number(accountID) instead of keyForList for more understandable
I update clearAddMemberError a bit to make the remove WS invalid member feature works for now. After this issue is merged, I can create other PR to revert these changes

jjcoffee · 2023-09-08T15:26:28Z

src/libs/actions/Policy.js

@@ -747,11 +747,16 @@ function clearDeleteMemberError(policyID, accountID) {
 * @param {Number} accountID
 */
 function clearAddMemberError(policyID, accountID) {
- Onyx.merge(`${ONYXKEYS.COLLECTION.POLICY_MEMBERS}${policyID}`, {
+ Onyx.set(`${ONYXKEYS.PERSONAL_DETAILS_LIST}`, {
+ ...allPersonalDetails,


Unsure why this change is here?

We also need to remove invalid user in PERSONAL_DETAILS_LIST. That why I want to use Onyx.set here to set the new personalDetails

jjcoffee · 2023-09-08T15:26:52Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

chrome-desktop-2023-09-26_16.22.54.mp4

Mobile Web - Chrome

android-chrome.mp4

Mobile Web - Safari

ios-safari-2023-09-11_14.38.33.mp4

Desktop

mac-desktop-2023-09-11_14.46.17.mp4

iOS

ios-native-2023-09-11_14.43.03.mp4

Android

android-native.mp4

jjcoffee · 2023-09-08T15:28:29Z

@tienifr The testing steps are a bit unclear, can you just copy them from the issue and maybe add an example of an invalid number to add?

jjcoffee · 2023-09-08T15:28:55Z

@tienifr Also it looks like you're missing a vid for Android.

jjcoffee · 2023-09-11T09:07:26Z

@tienifr Can you merge main and retest (per this comment on Slack)? Also still missing that video for Android 😄

tienifr · 2023-09-11T09:53:51Z

@jjcoffee I've merged with main, re-tested and added Android video.

jjcoffee · 2023-09-11T12:40:43Z

Tap confirm Remove

@tienifr I don't think we need this step?

tienifr · 2023-09-12T02:35:36Z

That's right. Updated

jjcoffee · 2023-09-12T07:30:27Z

@tienifr Can you revert the workaround for deleting the Onyx data, as we're gonna hold on this PR Expensify/react-native-onyx#333

tienifr · 2023-09-12T10:39:23Z

updated

tienifr · 2023-09-26T08:01:14Z

@jjcoffee @dangrous The react-native-onyx@1.0.89 works well. Can you please help check again?

jjcoffee · 2023-09-26T08:49:41Z

@tienifr Sweet! I'll retest later today.

jjcoffee · 2023-09-26T14:24:44Z

@tienifr Can you update the test steps to include a new failing number? The current one is valid. I used +84566123459@expensify.sms.

tienifr · 2023-09-26T15:07:44Z

@jjcoffee Thanks for pointing that out, I updated

jjcoffee

Tests well!

dangrous

easy enough!

OSBotify · 2023-09-28T02:55:26Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-09-28T19:16:51Z

🚀 Deployed to staging by https://github.com/dangrous in version: 1.3.75-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-02T17:20:47Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.75-12 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-10-02T17:49:22Z

🚀 Deployed to staging by https://github.com/dangrous in version: 1.3.76-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-03T15:50:19Z

🚀 Deployed to production by https://github.com/mountiny in version: 1.3.76-6 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

fix: 26339 Unable to remove error reported WS member

164a12a

tienifr force-pushed the fix/26339 branch from f8a7d90 to 164a12a Compare September 7, 2023 15:50

tienifr marked this pull request as ready for review September 7, 2023 15:58

tienifr requested a review from a team as a code owner September 7, 2023 15:58

melvin-bot bot requested review from jjcoffee and removed request for a team September 7, 2023 15:59

jjcoffee reviewed Sep 8, 2023

View reviewed changes

This was referenced Sep 8, 2023

[HOLD for payment 2023-09-18] [$1000] Both English & Spanish Emoji are present while making default language spanish #25735

Closed

[PAID] [$500] Workspace - Unable to remove error reported member #26339

Closed

Merge branch 'main' of https://github.com/tienifr/App into fix/26339

6870494

revert unnecessary change

5b8bc01

tienifr added 4 commits September 19, 2023 17:09

Merge branch 'main' into fix/26339

464679b

Merge branch 'main' into fix/26339

9579506

Merge branch 'main' into fix/26339

373a6ef

bump react native onyx version 1.0.89

951a9ff

jjcoffee approved these changes Sep 27, 2023

View reviewed changes

melvin-bot bot requested a review from dangrous September 27, 2023 08:33

dangrous approved these changes Sep 28, 2023

View reviewed changes

dangrous merged commit df57326 into Expensify:main Sep 28, 2023
16 checks passed

OSBotify mentioned this pull request Sep 28, 2023

Deploy Checklist: New Expensify 2023-09-28 #28412

Closed

OSBotify mentioned this pull request Oct 2, 2023

Deploy Checklist: New Expensify 2023-10-02 #28635

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix: 26339 Workspace - Unable to remove error reported member #26975

Fix: 26339 Workspace - Unable to remove error reported member #26975

tienifr commented Sep 7, 2023 •

edited

Loading

melvin-bot bot commented Sep 7, 2023

tienifr commented Sep 7, 2023 •

edited

Loading

jjcoffee Sep 8, 2023

tienifr Sep 11, 2023

jjcoffee commented Sep 8, 2023 •

edited

Loading

jjcoffee commented Sep 8, 2023

jjcoffee commented Sep 8, 2023

jjcoffee commented Sep 11, 2023

tienifr commented Sep 11, 2023 •

edited

Loading

jjcoffee commented Sep 11, 2023

tienifr commented Sep 12, 2023

jjcoffee commented Sep 12, 2023

tienifr commented Sep 12, 2023

tienifr commented Sep 26, 2023

jjcoffee commented Sep 26, 2023

jjcoffee commented Sep 26, 2023

tienifr commented Sep 26, 2023

jjcoffee left a comment

dangrous left a comment

OSBotify commented Sep 28, 2023

OSBotify commented Sep 28, 2023

OSBotify commented Oct 2, 2023

OSBotify commented Oct 2, 2023

OSBotify commented Oct 3, 2023

Fix: 26339 Workspace - Unable to remove error reported member #26975

Fix: 26339 Workspace - Unable to remove error reported member #26975

Conversation

tienifr commented Sep 7, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Sep 7, 2023

tienifr commented Sep 7, 2023 • edited Loading

jjcoffee Sep 8, 2023

Choose a reason for hiding this comment

tienifr Sep 11, 2023

Choose a reason for hiding this comment

jjcoffee commented Sep 8, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

jjcoffee commented Sep 8, 2023

jjcoffee commented Sep 8, 2023

jjcoffee commented Sep 11, 2023

tienifr commented Sep 11, 2023 • edited Loading

jjcoffee commented Sep 11, 2023

tienifr commented Sep 12, 2023

jjcoffee commented Sep 12, 2023

tienifr commented Sep 12, 2023

tienifr commented Sep 26, 2023

jjcoffee commented Sep 26, 2023

jjcoffee commented Sep 26, 2023

tienifr commented Sep 26, 2023

jjcoffee left a comment

Choose a reason for hiding this comment

dangrous left a comment

Choose a reason for hiding this comment

OSBotify commented Sep 28, 2023

OSBotify commented Sep 28, 2023

OSBotify commented Oct 2, 2023

OSBotify commented Oct 2, 2023

OSBotify commented Oct 3, 2023

tienifr commented Sep 7, 2023 •

edited

Loading

tienifr commented Sep 7, 2023 •

edited

Loading

jjcoffee commented Sep 8, 2023 •

edited

Loading

tienifr commented Sep 11, 2023 •

edited

Loading