-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Implement new layout in About page #27241
Merged
Merged
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
0a851ed
about page animation changes
Pujan92 11dba93
lint fix
Pujan92 f084d4e
added close button
Pujan92 e88c246
Merge branch 'main' into fix/26779
Pujan92 fb8e153
Merge branch 'main' into fix/26779
Pujan92 84a6779
route to screen changes
Pujan92 259219e
minor change
Pujan92 92dd54b
added header text
Pujan92 9210b9a
Merge branch 'main' into fix/26779
Pujan92 cf0b853
Merge branch 'main' into fix/26779
Pujan92 2c97df4
merge conflict resolved
Pujan92 4f57a69
added new animation file
Pujan92 18c53e6
Merge branch 'main' into fix/26779
Pujan92 b332108
about page lottie changes
Pujan92 dc4d585
prettier
Pujan92 fa560b1
double entry fixed
Pujan92 dd27043
added usecallback for overlayContent
Pujan92 4152524
prettier
Pujan92 064ec6c
comment fix
Pujan92 e01d5b4
Merge remote-tracking branch 'upstream/main' into fix/26779
Pujan92 9c9d03f
Merge remote-tracking branch 'upstream/main' into fix/26779
Pujan92 418768f
comment added
Pujan92 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a comment explaining the reason
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure whether we require comment here bcoz isn't useCallback without dependencies descriptive enough to only create a function on the mount?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I meant on why we are disabling the lint rule e.g. you can just write
styles do not change