Deprecate paypal #27308

mountiny · 2023-09-13T06:56:35Z

Details

In this PR we are removing everything Paypal, historical report actions which are tied to paying using Paypal should change to Elsewhere

Fixed Issues

$ #26368

Tests

Checkout main
Set up two accounts so they have PayPal address added
Request and Pay with Paypal between them
Checkout this branch
Go to the payment method page
Verify everything works normal there
Go to the paid IOU report between the two users
Verify the message says paid elsewhere
Request another money request
Verify you cannot pay with paypal
Verify you can pay elsewhere just fine
Request another payment
This time pay from the Report Preview in the DM instead from the IOU report
Verify this worked fine
Verify there are no new console errors

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify you can pay for money requests successfully

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Worked fine locally, added only the web screenshot as the test steps are more exploratory and @burczu has done a lot of testing and verified it works fine

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

melvin-bot · 2023-09-13T06:57:29Z

@burczu Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mountiny · 2023-09-13T07:00:50Z

@burczu could you please help me and test this PR with couple of paypal scenarios switching between main and this branch when users already had the paypal account added? So this would not break anything when we deploy this?

I will write them down in the tests section

mountiny · 2023-09-13T07:14:31Z

@burczu Added, could you please play around with various scenarios where one account has paypal and the other one does not, both accounts dont have paypal, both account have paypalon main and then switch to this branch and just, making sure nothing breaks.

Thank you!

burczu · 2023-09-13T07:39:33Z

@mountiny Do we have some paypal test accounts I could use?

mountiny · 2023-09-13T07:46:02Z

@burczu you can use whatever string you want, there is no validation, its not smart

burczu · 2023-09-14T08:48:19Z

Hey @mountiny! I did some tests as you've asked:

first on main:

set up paypal account on user A, requested money as user B, and paid with PayPal as user A - no issues
set up paypal account on user B, requested money as user A, and paid with PayPal as user B - no issues
once again requested money as user B (both users has PayPal accounts now), and paid as user A - no issues
once again requested money as user A (both users has PayPal accounts now), but didn't pay yet to check how it will behave after switching branches

then switched to this branch

checked the request from user A on user B account - only "Pay elsewhere" option is available, payment works without issues
reviewed previous PayPal requests - it says "Paid elsewhere", didn't observe any issues
requested another payment, checked that only "Pay elsewhere" option is available in IOU report, payment works without issues
requested one more payment, checked that only "Pay elsewhere" option is available in DM, payment works without issues

If you have an idea for any other tests I could perform, please let me know.

mountiny · 2023-09-14T11:07:28Z

@burczu that looks great, I cant think of any other, did you not see any error messages in the console?

burczu · 2023-09-14T11:11:21Z

@mountiny There was some console errors, but I think they are unrelated because they show up while opening report not while dealing with payments.

mountiny · 2023-09-14T11:14:29Z

There is the paypal used in the settlementButton which can be rendered when opening the report, would you be able to confirm if this is happening on main ?

burczu · 2023-09-15T09:43:18Z

@mountiny Checked on this branch and on main and this console log shows up on both (but not every time you open report, it seems to be random):

I don't think it's related to paypal changes.

mountiny · 2023-09-15T11:33:27Z

@burczu This is already on main so I agree

mountiny · 2023-09-15T11:35:34Z

@burczu would you be able to complete the checklist on this one today, seems like the testing has already been done quite thoroughly! Thanks!

burczu · 2023-09-15T11:36:20Z

@mountiny I think it's possible, but you need to complete your list first ;)

burczu · 2023-09-15T11:44:26Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Mobile Web - Chrome

Mobile Web - Safari

Desktop

iOS

Android

burczu · 2023-09-15T11:47:42Z

@mountiny please check checkboxes under Tests and QA Steps + Screenshots/Videos are missing.

mountiny · 2023-09-18T03:36:13Z

@burczu Update with a screenshot of web, I think we can proceed with only that as you have tested this properly and I have done various tests locally too, but its probably not that valuable for me to record all of that exploratory testing. Can you please approve if you are happy with the code. Thank you!

mountiny · 2023-09-18T03:45:30Z

Updated with a fix one issue I have noticed

burczu

Reviewed, tested and approved.

melvin-bot · 2023-09-18T07:12:26Z

@arosiclair Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

OSBotify · 2023-09-19T01:50:01Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-09-20T08:46:09Z

🚀 Deployed to staging by https://github.com/arosiclair in version: 1.3.72-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-09-22T13:28:04Z

🚀 Deployed to production by https://github.com/thienlnam in version: 1.3.72-11 🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

mountiny added 4 commits September 13, 2023 13:48

Remove paypal button from the settlementButton

b132eff

Remove from the wallet page

b59586d

Remove paypal from AddPaymentMethodMenu

19a4b25

Remove Paypal

6a4eb66

mountiny self-assigned this Sep 13, 2023

mountiny marked this pull request as ready for review September 13, 2023 06:57

mountiny requested a review from a team as a code owner September 13, 2023 06:57

melvin-bot bot requested review from burczu and removed request for a team September 13, 2023 06:57

mountiny added 2 commits September 13, 2023 15:11

Run prettier

0e82698

Fix lint

0a61577

Fix linter

1300677

Merge branch 'main' into vit-deprecatePaypal

c00e927

Merge main

12ba6f9

Decouple the isSettled logic from settled message

ae6f8b7

burczu approved these changes Sep 18, 2023

View reviewed changes

melvin-bot bot requested a review from arosiclair September 18, 2023 07:12

arosiclair approved these changes Sep 19, 2023

View reviewed changes

arosiclair merged commit 0680e5d into main Sep 19, 2023
12 checks passed

arosiclair deleted the vit-deprecatePaypal branch September 19, 2023 01:43

OSBotify mentioned this pull request Sep 20, 2023

Deploy Checklist: New Expensify 2023-09-20 #27837

Closed

melvin-bot bot mentioned this pull request Sep 22, 2023

Deprecate Paypal.me in product now that we're launching in-app payments and have settle-up elsewhere #26368

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Deprecate paypal #27308

Deprecate paypal #27308

mountiny commented Sep 13, 2023 •

edited

Loading

melvin-bot bot commented Sep 13, 2023

mountiny commented Sep 13, 2023

mountiny commented Sep 13, 2023

burczu commented Sep 13, 2023

mountiny commented Sep 13, 2023

burczu commented Sep 14, 2023

mountiny commented Sep 14, 2023

burczu commented Sep 14, 2023

mountiny commented Sep 14, 2023

burczu commented Sep 15, 2023 •

edited

Loading

mountiny commented Sep 15, 2023

mountiny commented Sep 15, 2023

burczu commented Sep 15, 2023

burczu commented Sep 15, 2023 •

edited

Loading

burczu commented Sep 15, 2023

mountiny commented Sep 18, 2023

mountiny commented Sep 18, 2023

burczu left a comment

melvin-bot bot commented Sep 18, 2023

OSBotify commented Sep 19, 2023

OSBotify commented Sep 20, 2023

OSBotify commented Sep 22, 2023

Deprecate paypal #27308

Deprecate paypal #27308

Conversation

mountiny commented Sep 13, 2023 • edited Loading

Details

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Sep 13, 2023

mountiny commented Sep 13, 2023

mountiny commented Sep 13, 2023

burczu commented Sep 13, 2023

mountiny commented Sep 13, 2023

burczu commented Sep 14, 2023

mountiny commented Sep 14, 2023

burczu commented Sep 14, 2023

mountiny commented Sep 14, 2023

burczu commented Sep 15, 2023 • edited Loading

mountiny commented Sep 15, 2023

mountiny commented Sep 15, 2023

burczu commented Sep 15, 2023

burczu commented Sep 15, 2023 • edited Loading

Reviewer Checklist

Screenshots/Videos

burczu commented Sep 15, 2023

mountiny commented Sep 18, 2023

mountiny commented Sep 18, 2023

burczu left a comment

Choose a reason for hiding this comment

melvin-bot bot commented Sep 18, 2023

OSBotify commented Sep 19, 2023

OSBotify commented Sep 20, 2023

OSBotify commented Sep 22, 2023

mountiny commented Sep 13, 2023 •

edited

Loading

burczu commented Sep 15, 2023 •

edited

Loading

burczu commented Sep 15, 2023 •

edited

Loading