Upgrade `react-native-sdk` to v8.3.0 #27432

shubham1206agra · 2023-09-14T11:45:44Z

Details

Fixed Issues

$ #14678
PROPOSAL: #14678 (comment)

Tests / QA Steps

Open Settings > Workspaces > Select any workspace > Connect Bank Account > Add manually
Complete step 1-3 to open the Onfido page
Ensure camera permissions are set to Only while using the App
Minimize the app (by heading to the home screen)
Reopen the app and confirm that no camera "permission not granted dialog" appears
Carefully look for any regressions in the Onfido flows in general

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android / native
- Android / Chrome
- iOS / native
- iOS / Safari
- MacOS / Chrome / Safari
- MacOS / Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I verified the translation was requested/reviewed in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- If we are not using the full Onyx data that we loaded, I've added the proper selector in order to ensure the component only re-renders when the data it is using changes
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG))
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR author checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

Screen.Recording.2023-09-14.at.5.27.55.PM.mov

Mobile Web - Chrome

NA

Mobile Web - Safari

NA

Desktop

NA

iOS

Screen.Recording.2023-09-18.at.2.02.07.PM.mov

Android

Screen.Recording.2023-10-13.at.8.22.50.PM.mov

… into upgrade-rn-sdk

melvin-bot · 2023-09-14T11:45:49Z

@robertKozik Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

shubham1206agra · 2023-09-18T08:35:56Z

@robertKozik I am unable to do test this on emulator due to problem with playstore.
I think you need to use real device to test this (I am unable to take a screen record from the physical device)

robertKozik · 2023-09-19T10:30:55Z

@shubham1206agra What problem with play store? Maybe I can help :)

shubham1206agra · 2023-09-19T10:32:13Z

It's after plaid connection. Play Store is opened and the progress is lost for step 1

shubham1206agra · 2023-09-20T09:55:59Z

@robertKozik Any updates here

shubham1206agra · 2023-09-22T05:00:37Z

@robertKozik ??

robertKozik · 2023-09-22T07:13:52Z

Sorry coming back to that PR! 👀

robertKozik · 2023-09-22T09:59:31Z

I think we should extend the test cases to cover the entire Onfido flow. After all, we are bumping the library, so checking the whole process would be prudent

shubham1206agra · 2023-09-22T12:11:31Z

This requires physical iOS device cause simulator's camera is disabled by default

shubham1206agra · 2023-09-25T05:29:28Z

@robertKozik ??

robertKozik · 2023-09-25T06:56:10Z

I'll take care of testing on the physical devices, but will need a little more time to do so. Until then, please update the screenshots/videos for all platforms, to show up how the onfido flow is behaving (until the point where you cannot access further).

shubham1206agra · 2023-10-12T13:28:04Z

@robertKozik I think we should complete this cause this has taken a month already.

robertKozik · 2023-10-12T14:06:19Z

Yeah, I'm on it right now 👀

robertKozik · 2023-10-12T16:37:35Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(themeColors.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Web

web.mov

Mobile Web - Chrome

android.web.mov

Mobile Web - Safari

ios.web.mov

Desktop

Screen.Recording.2023-10-12.at.18.34.28.mov

iOS

ios.mov

Android

android.mov

android.2.mov

robertKozik

Looks good to me. However, we should remain vigilant for any potential regressions. I wasn't able to comprehensively cover the Onfido flow with tests.

marcaaron · 2023-10-12T19:48:03Z

Reopen the app and observe that a camera permission not granted dialog appears

Isn't this the bug we are trying to fix? Why is it listed as a test step for QA to observe? 🤔

marcaaron

@shubham1206agra please post pictures + videos of Android

Also, please update the test steps and make sure at least one of those videos validates that this bug has been fixed.

shubham1206agra · 2023-10-13T01:33:43Z

Reopen the app and observe that a camera permission not granted dialog appears

Isn't this the bug we are trying to fix? Why is it listed as a test step for QA to observe? 🤔

My bad. I have just corrected the step

shubham1206agra · 2023-10-13T07:19:50Z

@robertKozik Can you tell me how did you test the Android?

robertKozik · 2023-10-13T07:50:45Z

@shubham1206agra Actually I didn't do anything unusual. It worked for me in emulator with no setup

shubham1206agra · 2023-10-13T14:55:07Z

@marcaaron I have updated the Android video

shubham1206agra · 2023-10-13T14:55:19Z

You can merge this PR now

OSBotify · 2023-10-13T18:54:01Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2023-10-13T21:10:10Z

🚀 Deployed to staging by https://github.com/marcaaron in version: 1.3.84-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-16T21:10:35Z

🚀 Deployed to production by https://github.com/francoisl in version: 1.3.84-10 🚀

platform	result
🤖 android 🤖	skipped 🚫
🖥 desktop 🖥	skipped 🚫
🍎 iOS 🍎	skipped 🚫
🕸 web 🕸	skipped 🚫

OSBotify · 2023-10-16T21:46:55Z

🚀 Deployed to production by https://github.com/francoisl in version: 1.3.84-10 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

OSBotify · 2023-10-16T21:49:51Z

🚀 Deployed to staging by https://github.com/marcaaron in version: 1.3.85-0 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

OSBotify · 2023-10-17T23:14:36Z

🚀 Deployed to production by https://github.com/francoisl in version: 1.3.85-4 🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	failure ❌
🕸 web 🕸	success ✅

shubham1206agra added 3 commits September 13, 2023 12:30

upgrade rn-sdk to 8.3.0

f730d9c

upgrade rn-sdk to 8.3.0

05d5103

Merge branch 'upgrade-rn-sdk' of https://github.com/shubham1206agra/App…

120335f

… into upgrade-rn-sdk

shubham1206agra requested a review from a team as a code owner September 14, 2023 11:45

melvin-bot bot requested review from robertKozik and removed request for a team September 14, 2023 11:45

Merge branch 'Expensify:main' into upgrade-rn-sdk

8a925c3

shubham1206agra and others added 3 commits September 26, 2023 11:03

Merge branch 'main' into upgrade-rn-sdk

cf3b631

Merge branch 'Expensify:main' into upgrade-rn-sdk

6bcb466

merge main

f85beea

robertKozik approved these changes Oct 12, 2023

View reviewed changes

melvin-bot bot requested a review from marcaaron October 12, 2023 16:39

marcaaron requested changes Oct 12, 2023

View reviewed changes

Merge branch 'Expensify:main' into upgrade-rn-sdk

902faf0

marcaaron assigned shubham1206agra Oct 13, 2023

marcaaron approved these changes Oct 13, 2023

View reviewed changes

marcaaron merged commit 969e7f7 into Expensify:main Oct 13, 2023
17 checks passed

OSBotify mentioned this pull request Oct 13, 2023

Deploy Checklist: New Expensify 2023-10-13 #29585

Closed

97 tasks

OSBotify mentioned this pull request Oct 16, 2023

Deploy Checklist: New Expensify 2023-10-16 #29717

Closed

melvin-bot bot mentioned this pull request Oct 16, 2023

[HOLD for payment 2023-10-23] [HOLD for payment 2023-10-23] [$1000] Pressing Onfido back button on native app show a Camera permission not granted dialog #14678

Closed

1 task

lanitochka17 mentioned this pull request Oct 17, 2023

[$500] iOS - BA - When minimizing the app on the Onfido page, the process is restarted #29820

Closed

6 tasks

shubham1206agra deleted the upgrade-rn-sdk branch February 6, 2024 03:02

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade `react-native-sdk` to v8.3.0 #27432

Upgrade `react-native-sdk` to v8.3.0 #27432

shubham1206agra commented Sep 14, 2023 •

edited by marcaaron

Loading

melvin-bot bot commented Sep 14, 2023

shubham1206agra commented Sep 18, 2023

robertKozik commented Sep 19, 2023

shubham1206agra commented Sep 19, 2023

shubham1206agra commented Sep 20, 2023

shubham1206agra commented Sep 22, 2023

robertKozik commented Sep 22, 2023

robertKozik commented Sep 22, 2023

shubham1206agra commented Sep 22, 2023

shubham1206agra commented Sep 25, 2023

robertKozik commented Sep 25, 2023

shubham1206agra commented Oct 12, 2023

robertKozik commented Oct 12, 2023

robertKozik commented Oct 12, 2023

robertKozik left a comment

marcaaron commented Oct 12, 2023

marcaaron left a comment

shubham1206agra commented Oct 13, 2023

shubham1206agra commented Oct 13, 2023

robertKozik commented Oct 13, 2023

shubham1206agra commented Oct 13, 2023

shubham1206agra commented Oct 13, 2023

OSBotify commented Oct 13, 2023

OSBotify commented Oct 13, 2023

OSBotify commented Oct 16, 2023

OSBotify commented Oct 16, 2023

OSBotify commented Oct 16, 2023

OSBotify commented Oct 17, 2023

Upgrade react-native-sdk to v8.3.0 #27432

Upgrade react-native-sdk to v8.3.0 #27432

Conversation

shubham1206agra commented Sep 14, 2023 • edited by marcaaron Loading

Details

Fixed Issues

Tests / QA Steps

PR Author Checklist

Screenshots/Videos

melvin-bot bot commented Sep 14, 2023

shubham1206agra commented Sep 18, 2023

robertKozik commented Sep 19, 2023

shubham1206agra commented Sep 19, 2023

shubham1206agra commented Sep 20, 2023

shubham1206agra commented Sep 22, 2023

robertKozik commented Sep 22, 2023

robertKozik commented Sep 22, 2023

shubham1206agra commented Sep 22, 2023

shubham1206agra commented Sep 25, 2023

robertKozik commented Sep 25, 2023

shubham1206agra commented Oct 12, 2023

robertKozik commented Oct 12, 2023

robertKozik commented Oct 12, 2023

Reviewer Checklist

Screenshots/Videos

robertKozik left a comment

Choose a reason for hiding this comment

marcaaron commented Oct 12, 2023

marcaaron left a comment

Choose a reason for hiding this comment

shubham1206agra commented Oct 13, 2023

shubham1206agra commented Oct 13, 2023

robertKozik commented Oct 13, 2023

shubham1206agra commented Oct 13, 2023

shubham1206agra commented Oct 13, 2023

OSBotify commented Oct 13, 2023

OSBotify commented Oct 13, 2023

OSBotify commented Oct 16, 2023

OSBotify commented Oct 16, 2023

OSBotify commented Oct 16, 2023

OSBotify commented Oct 17, 2023

Upgrade `react-native-sdk` to v8.3.0 #27432

Upgrade `react-native-sdk` to v8.3.0 #27432

shubham1206agra commented Sep 14, 2023 •

edited by marcaaron

Loading