Logic to support closed account receiving a link to set password and for unvalidated and closed accounts to get the email the moment they log into ecash

[chiragsalian]

Details

On HOLD till I get some confirmation in the issue.

Fixed Issues

Fixes https://github.com/Expensify/Expensify/issues/163196

Tests

1. Make sure you have the code from this web-e and auth PR and have done make etc.
2. I would recommend testing on a clean slate which makes this easier i.e., go to sql.sh and run delete from notifications;
3. Go to ecash, click on new chat, enter a new gmail account. Make a note of the email so you don't forgot. Log out.
4. In ecash log into the email that you entered in the previous step and click continue. It should be a closed account so in the network tab you should see reopenAccount request like so,
   
5. Run select * from notifications and confirm you see a "SetCashPassword" template notification.
6. On dev, notification emails won't get send to gmail domains so you'll need to run

update notifications set json =  json_set(json(notifications.json), '$.to', '<your_expensify_email>');

6. Edit this line and replace $this->parameters['to'] with your gmail test account otherwise the validate code won't work
7. In vssh run php /vagrant/Web-Expensify/script/notifyall.php.
8. Check your email. Click on the link.
9. Confirm you are redirected to a setpassword screen like so,
   
10. Enter a password and confirm it works just fine.

QA Steps

None. Its a little involved with multiple flows and cannot be tested on staging so once this is live I'll ask tom to test.

Tested On

• Web
• Mobile Web
• Desktop
• iOS
• Android

Screenshots

Web

Mobile Web

Desktop

iOS

Android

[chiragsalian]

Off HOLD since nothing will break if auth and web aren't live yet and the sooner each part goes live the better. But the complete functionality will only work when all 3 pieces are live - cash, web-e and auth.

[chiragsalian]

i accidentally used puller bear before putting the PR for review so I removed the latest pullerbear assignee.

[chiragsalian]

Bump @Gonals and @AndrewGable for review

[chiragsalian]

Andrew is OOO for the week so adding another reviewer.

[Beamanator]

One spelling fix & a requested comment improvement; neither are blockers though :D

[Beamanator]

NAB; Why are we defaulting login to credentials.login here and in resendValidationLink? Rephrased: When / why would a passed-in login string be different from what's stored in credentials.login?

I believe this has to do with unvalidated / closed accounts (the topic of your PR), but I think it would be useful to make this clear in the function comment

[chiragsalian]

So when you enter an email it hits this flow - https://github.com/Expensify/Expensify.cash/pull/2745/files#diff-283c48b7349b0bf7aba66da8891bc8a9f9df70664bd06e7a875f56b19c6c02f9R126 and credentials.login is not set yet that's why we pass the provided email.

But when you click resent link, it hits this flow - https://github.com/Expensify/Expensify.cash/pull/2745/files#diff-c075eec38f8adc854c238b1d4cfeba1ed3e5de0aa740aa78a658ffe3a53814f9R62 and does not need to pass an email since its in credentials.login. Does that make sense?

[Beamanator]

Giggidy, LGTM 💪

[Luke9389]

😄

[Luke9389]

¡Excillente!

[OSBotify]

🚀 Deployed to staging in version: 1.0.43-5🚀

platform	result
🤖 android 🤖	success ✅
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅

[OSBotify]

🚀 Deployed to production in version: 1.0.44-0🚀

platform	result
🤖 android 🤖	failure ❌
🖥 desktop 🖥	success ✅
🍎 iOS 🍎	success ✅
🕸 web 🕸	success ✅